-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add wishlist drawer #1182
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 81115f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b7c28f0
to
f74f088
Compare
7854316
to
0852aff
Compare
0852aff
to
d13957d
Compare
ce870c6
to
d252350
Compare
d252350
to
0cdcca6
Compare
0cdcca6
to
ae08ecb
Compare
ae08ecb
to
49a7c1b
Compare
49a7c1b
to
30f75c8
Compare
30f75c8
to
a051040
Compare
a051040
to
04dcda9
Compare
04dcda9
to
9fa248a
Compare
9fa248a
to
bf47c4f
Compare
d645da4
to
172fd63
Compare
172fd63
to
2d15290
Compare
2d15290
to
677d9fb
Compare
core/app/[locale]/(default)/account/[tab]/_components/wishlist-sheet/index.tsx
Outdated
Show resolved
Hide resolved
.../[locale]/(default)/account/[tab]/_components/wishlist-sheet/update-wishlists-form/index.tsx
Outdated
Show resolved
Hide resolved
core/app/[locale]/(default)/account/[tab]/_components/wishlist-sheet/wishlist-sheet-content.tsx
Outdated
Show resolved
Hide resolved
677d9fb
to
c236eb2
Compare
This is gonna be a bit of an ask, but we need to refactor this PR to include new (tabs) group and pages, as well as localization changes, and some components were moved around. Lets also make sure we define the fragments were used. |
c236eb2
to
81115f3
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-wkwqwxkq9-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
What/Why?
This pr adds Wishlist Drawer for Catalyst (PDP)
This Drawer help the user to manage wishlists:
Testing
Locally