Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add wishlist drawer #1182

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat(core): add wishlist drawer #1182

merged 1 commit into from
Sep 9, 2024

Conversation

yurytut1993
Copy link
Contributor

What/Why?

This pr adds Wishlist Drawer for Catalyst (PDP)
This Drawer help the user to manage wishlists:

  • creating new wishlist
  • adding new item to wishlist
  • deleting an item from wishlist

Testing

Locally

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 3:26pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 6, 2024 3:26pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:26pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:26pm
catalyst-staging ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:26pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:26pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:26pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:26pm

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 81115f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yurytut1993 yurytut1993 force-pushed the wishlist-drawer branch 2 times, most recently from 7854316 to 0852aff Compare August 9, 2024 14:26
@yurytut1993 yurytut1993 force-pushed the wishlist-drawer branch 2 times, most recently from ce870c6 to d252350 Compare August 9, 2024 14:32
@jorgemoya
Copy link
Contributor

This is gonna be a bit of an ask, but we need to refactor this PR to include new (tabs) group and pages, as well as localization changes, and some components were moved around. Lets also make sure we define the fragments were used.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-wkwqwxkq9-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Copy link
Contributor

@bc-azvierieva bc-azvierieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yurytut1993 yurytut1993 merged commit aab3e03 into wishlist Sep 9, 2024
12 of 14 checks passed
@yurytut1993 yurytut1993 deleted the wishlist-drawer branch September 9, 2024 11:57
yurytut1993 added a commit that referenced this pull request Sep 13, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 13, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 17, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 30, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 30, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants