Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update delete wishlists mutation #1273

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

yurytut1993
Copy link
Contributor

What/Why?

This pr contains changes for delete wishlists mutation interface to be consistent with other wishlist mutations

Testing

Locally

@yurytut1993 yurytut1993 requested a review from a team as a code owner August 16, 2024 12:25
Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: 688b644

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 0:25am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am
catalyst-au ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am
catalyst-integration-customer-access-token ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am
catalyst-test-store ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am
catalyst-uk ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am
catalyst-unstable ⬜️ Ignored (Inspect) Aug 16, 2024 0:25am

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-qctz3jd9s-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@yurytut1993 yurytut1993 merged commit af8503e into wishlist Aug 20, 2024
14 checks passed
@yurytut1993 yurytut1993 deleted the update-delete-wishlists-mutation branch August 20, 2024 10:02
yurytut1993 added a commit that referenced this pull request Sep 13, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 13, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 17, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 30, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 30, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants