feat(core): add wishlist book #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e760b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
yurytut1993
force-pushed
the
wishlist-book
branch
from
848a89a
to
ead6a44
Compare
yurytut1993
force-pushed
the
wishlist-book
branch
from
b49bf7f
to
ce2d7f3
Compare
yurytut1993
force-pushed
the
wishlist-book
branch
from
ce2d7f3
to
6737a8e
Compare
yurytut1993
changed the title
yurytut1993
force-pushed
the
wishlist-book
branch
from
6737a8e
to
5eb4005
Compare
core/app/[locale]/(default)/account/[tab]/_components/addresses-content/address-book.tsx
Outdated
Show resolved
Hide resolved
yurytut1993
force-pushed
the
wishlist-book
branch
from
5eb4005
to
59e4f49
Compare
jorgemoya
reviewed
Jul 2, 2024
core/app/[locale]/(default)/account/[tab]/_actions/delete-wishlists.ts
Outdated
Show resolved
Hide resolved
.../account/[tab]/_components/wishlist-content/create-wishlist-form/_actions/create-wishlist.ts
Outdated
Show resolved
Hide resolved
Comment on lines
25
to
32
| revalidatePath('/account/wishlists', 'page'); | ||
|
|
||
| if (newWishlist) { | ||
| return { | ||
| status: 'success', | ||
| data: newWishlist, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Curious about this behavior. Since we revalidate the path, do we ever use the result from data? 🤔
There was a problem hiding this comment.
We use this right after the mutation works to update state. Revalidate works slower, so using data from mutations makes interface more fast and responsive. The same for deleting wish list - we delete wish list from list right after successful mutation. But we still need retaliate for correct pagination work
|
Closing due to inactivity. Reopen this PR or open a new one if we wish to bring this change in. |
yurytut1993
force-pushed
the
wishlist-book
branch
from
59e4f49
to
12f7538
Compare
yurytut1993
force-pushed
the
wishlist-book
branch
from
12f7538
to
59d2fdf
Compare
yurytut1993
force-pushed
the
wishlist-book
branch
from
59d2fdf
to
42157f1
Compare
|
@yurytut1993 is this ready for rereview? |
yurytut1993
force-pushed
the
wishlist-book
branch
from
42157f1
to
11d9b95
Compare
@jorgemoya testing showed several minor issues - I'll ping you when I fix it |
yurytut1993
force-pushed
the
wishlist-book
branch
from
11d9b95
to
4e760b7
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-6drlwa6ny-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
jorgemoya
approved these changes
Aug 23, 2024
yurytut1993
added a commit
that referenced
this pull request
Sep 13, 2024
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
yurytut1993
added a commit
that referenced
this pull request
Sep 13, 2024
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
yurytut1993
added a commit
that referenced
this pull request
Sep 17, 2024
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
yurytut1993
added a commit
that referenced
this pull request
Sep 30, 2024
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
yurytut1993
added a commit
that referenced
this pull request
Sep 30, 2024
…tructure feat(core): add delete wishlist mutation (#975) feat(core): add create wishlist mutation (#958) feat(core): update customer account modal component (#1001) feat(core): add wishlist items mutation (#1268) feat(core): delete wishlist items mutation (#1269) feat(core): update delete wishlists mutation (#1273) feat(core): update create wishlist mutation (#1272) feat(core): add wishlist book (#998) Add wishlist test (#1314) Update Wishlist test feat(core): add wishlist drawer (#1182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This pr adds wish lists book for customer account.
For now customer can:
Testing
Locally
wishlist-book.mov