Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wishlist mutation #958

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Create wishlist mutation #958

merged 1 commit into from
Jun 13, 2024

Conversation

yurytut1993
Copy link
Contributor

What/Why?

This pr adds create wishlist mutation for customer account

Testing

Locally

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 2:18pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:18pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:18pm
catalyst-ppr ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:18pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:18pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:18pm

Copy link

changeset-bot bot commented May 30, 2024

🦋 Changeset detected

Latest commit: d2df4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 5, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-93zaecmv2-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@yurytut1993 yurytut1993 marked this pull request as ready for review June 5, 2024 14:21
@yurytut1993 yurytut1993 requested a review from a team as a code owner June 5, 2024 14:21
Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to fetch all wishlist data on the mutate or could we simply get back entityId to make sure it was created?

@yurytut1993
Copy link
Contributor Author

yurytut1993 commented Jun 5, 2024

Do we need to fetch all wishlist data on the mutate or could we simply get back entityId to make sure it was created?

@jorgemoya we need to fetch this data to add to the state and to display in wish lists list

@yurytut1993 yurytut1993 merged commit 8054ebc into wishlist Jun 13, 2024
11 of 12 checks passed
@yurytut1993 yurytut1993 deleted the create-wishlist-mutation branch June 13, 2024 11:17
yurytut1993 added a commit that referenced this pull request Sep 13, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 13, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 17, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 30, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
yurytut1993 added a commit that referenced this pull request Sep 30, 2024
…tructure

feat(core): add delete wishlist mutation (#975)

feat(core): add create wishlist mutation (#958)

feat(core): update customer account modal component (#1001)

feat(core): add wishlist items mutation (#1268)

feat(core): delete wishlist items mutation (#1269)

feat(core): update delete wishlists mutation (#1273)

feat(core): update create wishlist mutation (#1272)

feat(core): add wishlist book (#998)

Add wishlist test (#1314)
Update Wishlist test

feat(core): add wishlist drawer (#1182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants