-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/thanos] Creates separate service for grpc port of query module #11051
[bitnami/thanos] Creates separate service for grpc port of query module #11051
Conversation
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @felippe-mendonca I looks very well, I have only two little suggestions. Could you have it a look?
Hey @fmulero! Thanks for your review, I've accept the suggested changes! |
…fication Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]>
…ckward compatibility Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]>
92a36da
to
878c935
Compare
…n of thanos query service Signed-off-by: Felippe Mendonça <[email protected]>
@@ -32,7 +32,7 @@ spec: | |||
loadBalancerSourceRanges: {{- toYaml $query.service.loadBalancerSourceRanges | nindent 4 }} | |||
{{- end }} | |||
ports: | |||
- port: {{ if $query.service.http }}{{ coalesce $query.service.ports.http $query.service.http.port }}{{ else }}{{ $query.service.ports.http }}{{ end }} | |||
- port: {{ $query.service.ports.http }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmulero also changed here, removing the backward compatibility config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Well done!. I am going to run some more tests, if everything goes well your PR will be merge by bitnami-bot.
Signed-off-by: Bitnami Containers <[email protected]>
I have just updated the bitnami images with the latest known immutable tags:
|
…le (bitnami#11051) * [bitnami/thanos] Creates separate service for grpc port of query module Signed-off-by: Felippe Mendonça <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> * [bitnami/thanos] removes backward compatibility of service port specification Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] fixes port spec at query-grpc-service and removes backward compatibility Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] removes backwards compatibility on port configuration of thanos query service Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] Update components versions Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: vaggeliskls <[email protected]>
…le (#11051) * [bitnami/thanos] Creates separate service for grpc port of query module Signed-off-by: Felippe Mendonça <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> * [bitnami/thanos] removes backward compatibility of service port specification Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] fixes port spec at query-grpc-service and removes backward compatibility Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] removes backwards compatibility on port configuration of thanos query service Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] Update components versions Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Fran Mulero <[email protected]>
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Signed-off-by: Felippe Mendonça [email protected]
Description of the change
As previously discussed at #11028, this PR creates a separate Kubernetes Service for Thanos Query gRPC port.
Benefits
Having a separate gRPC service, will be possible to configure this Service with specific annotations in order to make gRPC Ingress works, such as Traefik 2.0.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm