[bitnami/thanos] Creates separate service for grpc port of query module #11051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
requested changes
Jul 8, 2022
There was a problem hiding this comment.
Thanks a lot @felippe-mendonca I looks very well, I have only two little suggestions. Could you have it a look?
Hey @fmulero! Thanks for your review, I've accept the suggested changes! |
…fication Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]>
…ckward compatibility Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]>
felippe-mendonca
force-pushed
the
feat/thanos-query-grpc-service
branch
from
92a36da
to
878c935
Compare
…n of thanos query service Signed-off-by: Felippe Mendonça <[email protected]>
felippe-mendonca
commented
Jul 8, 2022
| @@ -32,7 +32,7 @@ spec: | |||
| loadBalancerSourceRanges: {{- toYaml $query.service.loadBalancerSourceRanges | nindent 4 }} | |||
| {{- end }} | |||
| ports: | |||
| - port: {{ if $query.service.http }}{{ coalesce $query.service.ports.http $query.service.http.port }}{{ else }}{{ $query.service.ports.http }}{{ end }} | |||
| - port: {{ $query.service.ports.http }} | |||
There was a problem hiding this comment.
@fmulero also changed here, removing the backward compatibility config
fmulero
previously approved these changes
Jul 12, 2022
Signed-off-by: Bitnami Containers <[email protected]>
|
I have just updated the bitnami images with the latest known immutable tags:
|
vaggeliskls
pushed a commit
to vaggeliskls/charts
that referenced
this pull request
Jul 21, 2022
…le (bitnami#11051) * [bitnami/thanos] Creates separate service for grpc port of query module Signed-off-by: Felippe Mendonça <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> * [bitnami/thanos] removes backward compatibility of service port specification Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] fixes port spec at query-grpc-service and removes backward compatibility Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] removes backwards compatibility on port configuration of thanos query service Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] Update components versions Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: vaggeliskls <[email protected]>
FraPazGal
pushed a commit
that referenced
this pull request
Jul 25, 2022
…le (#11051) * [bitnami/thanos] Creates separate service for grpc port of query module Signed-off-by: Felippe Mendonça <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> * [bitnami/thanos] removes backward compatibility of service port specification Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] fixes port spec at query-grpc-service and removes backward compatibility Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] removes backwards compatibility on port configuration of thanos query service Signed-off-by: Felippe Mendonça <[email protected]> * [bitnami/thanos] Update components versions Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Fran Mulero <[email protected]>
isantospardo
added a commit
to adfinis/helm-charts
that referenced
this pull request
Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
6 tasks
isantospardo
added a commit
to adfinis/helm-charts
that referenced
this pull request
Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felippe Mendonça [email protected]
Description of the change
As previously discussed at #11028, this PR creates a separate Kubernetes Service for Thanos Query gRPC port.
Benefits
Having a separate gRPC service, will be possible to configure this Service with specific annotations in order to make gRPC Ingress works, such as Traefik 2.0.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm