-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/thanos] Add support for HTTPS and basic auth experimental settings #12404
[bitnami/thanos] Add support for HTTPS and basic auth experimental settings #12404
Conversation
…ttings Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
I have added a new section in the README.md describing how to use this new feature. |
In case it helps, this PR has been tested using the following install commands:
Output:
|
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
| `https.cert` | TLS Certificate for Thanos HTTPS - ignored if existingSecret is provided | `""` | | ||
| `https.ca` | (Optional, used for client) CA Certificate for Thanos HTTPS - ignored if existingSecret is provided | `""` | | ||
| `https.clientAuthType` | Server policy for client authentication using certificates. Maps to ClientAuth Policies. | `""` | | ||
| `auth.basicAuthUsers` | Object containing <user>:<passwords> key-value pairs for each user that will have access via basic authentication | `{}` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is containing passwords, I think we should use a secret, or at least, provide the option to use a secret instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration file is stored in a Secret instead of a configmap because of that reason.
User can provide its configuration file using existingHttpConfigSecret
.
The main issue is that, if the basic authentication is enabled, the password is also needed for the Probes to succeed, and Thanos uses a scratch container, so no logic can be added to handle the password using env variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the README.md section below, where I tried to depict this same situation and the alternatives to that.
Signed-off-by: Miguel Ruiz <[email protected]>
{{/* | ||
Returns Thanos basic auth user and password for the HTTP request. | ||
*/}} | ||
{{- define "thanos.basicAuth" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this part as it is no longer necessary
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Description of the change
Adds support for Thanos HTTPS and basic authentication.
Ref: https://thanos.io/tip/operating/https.md/#running-thanos-with-https-and-basic-authentication
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm