-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/thanos] Add support for image digest apart from tag #11955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Rodriguez Hernandez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
rafariossaa
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rafariossaa
pushed a commit
to rafariossaa/charts
that referenced
this pull request
Sep 13, 2022
…#11955) * [bitnami/thanos] Add support for image digest apart from tag Signed-off-by: Carlos Rodriguez Hernandez <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Carlos Rodriguez Hernandez <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]>
isantospardo
added a commit
to adfinis/helm-charts
that referenced
this pull request
Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
6 tasks
isantospardo
added a commit
to adfinis/helm-charts
that referenced
this pull request
Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
From now on it will be possible to set an
image.digest
instead ofimage.tag
to pull the container image. Please note it is needed to release a bitnami/common version with those changes (see #11830).Once applied the changes, this is the result when setting the
image.digest
parameter in the values.yaml:In the same way, when the
image.digest
is empty (default value), this is the result: