Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] Add support for image digest apart from tag #11955

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Conversation

carrodher
Copy link
Member

Description of the change

From now on it will be possible to set an image.digest instead of image.tag to pull the container image. Please note it is needed to release a bitnami/common version with those changes (see #11830).

Once applied the changes, this is the result when setting the image.digest parameter in the values.yaml:

## Bitnami etcd image version
## ref: https://hub.docker.com/r/bitnami/etcd/tags/
## @param image.registry etcd image registry
## @param image.repository etcd image name
## @param image.tag etcd image tag
## @param image.digest etcd image digest in the way sha256:aa.... Please note this parameter, if set, will override the tag
##
image:    
  registry: docker.io
  repository: bitnami/etcd
  tag: 3.5.4-debian-11-r22
  digest: sha256:507bc997779af5f0419ad917167ba1c9a2ceb936f2c1e82fb0f687e6c1296897
$ helm template . -s templates/statefulset.yaml | grep 'image:'
          image: docker.io/bitnami/etcd@sha256:507bc997779af5f0419ad917167ba1c9a2ceb936f2c1e82fb0f687e6c1296897

In the same way, when the image.digest is empty (default value), this is the result:

## Bitnami etcd image version
## ref: https://hub.docker.com/r/bitnami/etcd/tags/
## @param image.registry etcd image registry
## @param image.repository etcd image name
## @param image.tag etcd image tag
## @param image.digest etcd image digest in the way sha256:aa.... Please note this parameter, if set, will override the tag
##
image:    
  registry: docker.io
  repository: bitnami/etcd
  tag: 3.5.4-debian-11-r22
  digest: ""
$ helm template . -s templates/statefulset.yaml | grep 'image:'
          image: docker.io/bitnami/etcd:3.5.4-debian-11-r22

@carrodher carrodher added verify Execute verification workflow for these changes thanos labels Aug 21, 2022
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafariossaa rafariossaa merged commit 7cd4152 into master Aug 22, 2022
@rafariossaa rafariossaa deleted the thanos branch August 22, 2022 12:04
rafariossaa pushed a commit to rafariossaa/charts that referenced this pull request Sep 13, 2022
…#11955)

* [bitnami/thanos] Add support for image digest apart from tag

Signed-off-by: Carlos Rodriguez Hernandez <[email protected]>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <[email protected]>

Signed-off-by: Carlos Rodriguez Hernandez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
isantospardo added a commit to adfinis/helm-charts that referenced this pull request Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051)
- [Update default prometheusrule value](bitnami/charts#10979)
- [Fix Deprecation Warning of thanos](bitnami/charts#11178)
- [Updating components versions](bitnami/charts@a49e568)
- [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352)
- [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274)
- [Add support for image digest apart from tag](bitnami/charts#11955)
- [Create sharded hpa and pdb for storegateway](bitnami/charts#11426)
- [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549)
- [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
isantospardo added a commit to adfinis/helm-charts that referenced this pull request Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051)
- [Update default prometheusrule value](bitnami/charts#10979)
- [Fix Deprecation Warning of thanos](bitnami/charts#11178)
- [Updating components versions](bitnami/charts@a49e568)
- [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352)
- [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274)
- [Add support for image digest apart from tag](bitnami/charts#11955)
- [Create sharded hpa and pdb for storegateway](bitnami/charts#11426)
- [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549)
- [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants