-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/thanos] Allowed to add labels to query-frontend service and storegateway PVC #11549
[bitnami/thanos] Allowed to add labels to query-frontend service and storegateway PVC #11549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for creating this PR!
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
…eway volume template Signed-off-by: Canh Ngo <[email protected]>
a07d37a
to
9a4efb5
Compare
Rebased from master. |
Sorry for the late reply. I've updated my comment. |
Signed-off-by: Canh Ngo <[email protected]>
…storegateway PVC (bitnami#11549) * (thanos) Allowed to add labels to query-frontend service and storegateway volume template Signed-off-by: Canh Ngo <[email protected]> * (thanos) Do not need to use root context in statefulset.yaml Signed-off-by: Canh Ngo <[email protected]> Signed-off-by: Canh Ngo <[email protected]>
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Signed-off-by: Canh Ngo [email protected]
Description of the change
Benefits
In our multi-tenant K8s clusters , the in-house admission controllers require custom labels must be added to the services and PVCs.
It allows flexible adding labels to K8s objects created by Thanos Helm chart.
Possible drawbacks
No
Applicable issues
No
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm