[bitnami/thanos] Allowed to add labels to query-frontend service and storegateway PVC #11549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alemorcuq
reviewed
Aug 5, 2022
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
…eway volume template Signed-off-by: Canh Ngo <[email protected]>
canhnt
force-pushed
the
thanos-add-labels-to-queryfrontend-and-storegateway
branch
from
a07d37a
to
9a4efb5
Compare
|
Rebased from master. |
|
Sorry for the late reply. I've updated my comment. |
Signed-off-by: Canh Ngo <[email protected]>
alemorcuq
approved these changes
Sep 2, 2022
rafariossaa
pushed a commit
to rafariossaa/charts
that referenced
this pull request
Sep 13, 2022
…storegateway PVC (bitnami#11549) * (thanos) Allowed to add labels to query-frontend service and storegateway volume template Signed-off-by: Canh Ngo <[email protected]> * (thanos) Do not need to use root context in statefulset.yaml Signed-off-by: Canh Ngo <[email protected]> Signed-off-by: Canh Ngo <[email protected]>
isantospardo
added a commit
to adfinis/helm-charts
that referenced
this pull request
Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
6 tasks
isantospardo
added a commit
to adfinis/helm-charts
that referenced
this pull request
Sep 30, 2022
- [Creates separate service for grpc port of query module](bitnami/charts#11051) - [Update default prometheusrule value](bitnami/charts#10979) - [Fix Deprecation Warning of thanos](bitnami/charts#11178) - [Updating components versions](bitnami/charts@a49e568) - [Update URLs to point to the new bitnami/containers monorepo](bitnami/charts#11352) - [Conditionally Set objstore arg and OBJSTORE_CONFIG for Thanos receive](bitnami/charts#11274) - [Add support for image digest apart from tag](bitnami/charts#11955) - [Create sharded hpa and pdb for storegateway](bitnami/charts#11426) - [Allowed to add labels to query-frontend service and storegateway PVC](bitnami/charts#11549) - [Add support for HTTPS and basic auth experimental settings](bitnami/charts#12404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Canh Ngo [email protected]
Description of the change
Benefits
In our multi-tenant K8s clusters , the in-house admission controllers require custom labels must be added to the services and PVCs.
It allows flexible adding labels to K8s objects created by Thanos Helm chart.
Possible drawbacks
No
Applicable issues
No
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm