Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Adds delays for suggestion api (uplift to 1.3) #4441

Closed
wants to merge 4 commits into from
Closed

WIP: Adds delays for suggestion api (uplift to 1.3) #4441

wants to merge 4 commits into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 27, 2020 •
edited
Loading

NOT READY FOR REVIEW; need to resolve 1 broken test and a UI issue

Uplift of #4372
Fixes brave/brave-browser#7709
Fixes brave/brave-browser#6940

NOTE: there was code from two PRs which was partially included. Since the full PR was not uplifted, the issue that PR fixed is NOT fixed.

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

mihaiplesa and others added 3 commits January 27, 2020 13:04
@bsclifton bsclifton added this to the 1.3.x - Beta milestone Jan 27, 2020
@bsclifton bsclifton self-assigned this Jan 27, 2020
@bsclifton bsclifton mentioned this pull request Jan 28, 2020
Merged
4 tasks
@bsclifton
Copy link
Member Author

Closing in favor of #4448

@bsclifton bsclifton closed this Jan 28, 2020
@bsclifton bsclifton deleted the suggestion-api-1.3 branch January 28, 2020 07:21
@bsclifton bsclifton removed this from the 1.3.x - Beta milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey Awaiting requested review from tmancey tmancey will be requested when the pull request is marked ready for review tmancey is a code owner

@kylehickinson kylehickinson Awaiting requested review from kylehickinson kylehickinson will be requested when the pull request is marked ready for review kylehickinson is a code owner

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @mihaiplesa @NejcZdovc