Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add check for new brave_enable_cdm_host_verification config option #1320

Closed
wants to merge 2 commits into from
Closed

WIP: Add check for new brave_enable_cdm_host_verification config option #1320

wants to merge 2 commits into from

Conversation

bsclifton
Copy link
Member

If set to true via .npmrc, Widevine Host Verification will be enabled for the build
This functionality also requires brave/brave-core#515

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bsclifton bsclifton self-assigned this Sep 27, 2018
bsclifton added a commit to brave/brave-core that referenced this pull request Sep 27, 2018
@bsclifton
Add new brave_enable_cdm_host_verification GN flag for enabling wid…
4f71dbd 
…evine host verification

This functionality also requires brave/brave-browser#1320
@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from c50f16f to 0a880e7 Compare September 27, 2018 15:55
@bsclifton bsclifton mentioned this pull request Sep 27, 2018
Closed
11 tasks
@bsclifton
Copy link
Member Author

NOTE: once this is tested, we'll want to rebase/drop 97caff7

@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from 97caff7 to 5f47dc9 Compare October 1, 2018 19:53
@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from 159770e to ee3babc Compare October 2, 2018 15:45
@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from ee3babc to a51436c Compare October 2, 2018 18:58
bsclifton added a commit to brave/brave-core that referenced this pull request Oct 3, 2018
@bsclifton
Add new brave_enable_cdm_host_verification GN flag for enabling wid…
96c0c5f 
…evine host verification

This functionality also requires brave/brave-browser#1320
@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from a51436c to 4321b17 Compare October 4, 2018 09:47
@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from 4321b17 to 5d0ab08 Compare October 6, 2018 07:24
bsclifton added a commit to brave/brave-core that referenced this pull request Oct 6, 2018
@bsclifton
Add new brave_enable_cdm_host_verification GN flag for enabling wid…
416d2bc 
…evine host verification

This functionality also requires brave/brave-browser#1320
bsclifton added a commit to brave/brave-core that referenced this pull request Oct 11, 2018
@bsclifton
Add new brave_enable_cdm_host_verification GN flag for enabling wid…
f3300ff 
…evine host verification

This functionality also requires brave/brave-browser#1320
bsclifton added a commit to brave/brave-core that referenced this pull request Oct 14, 2018
@bsclifton
Re-implement work done originally done with:
681d136 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).

This functionality also requires brave/brave-browser#1320
@bsclifton
Add check for new brave_enable_cdm_host_verification config option
df0d32b 
If set to `true` via .npmrc, Widevine Host Verification will be enabled for the build
This functionality also requires brave/brave-core#515

Fixes #1310
@bsclifton
For testing with CI, set the brave-core branch to brave/brave-core#515
f0cb96e
@bsclifton bsclifton force-pushed the brave_enable_cdm_host_verification branch from c20f5e5 to f0cb96e Compare October 14, 2018 04:40
@bbondy bbondy changed the title Add check for new brave_enable_cdm_host_verification config option WIP: Add check for new brave_enable_cdm_host_verification config option Nov 20, 2018
@bsclifton
Copy link
Member Author

Closing as @simonhong is working on this

@bsclifton bsclifton closed this Mar 22, 2019
@bsclifton bsclifton deleted the brave_enable_cdm_host_verification branch March 22, 2019 00:07
This was referenced Oct 11, 2021
Closed
Closed
Closed
@stephendonner stephendonner mentioned this pull request Oct 11, 2021
Closed
43 tasks
@btlechowski btlechowski mentioned this pull request Oct 11, 2021
Closed
43 tasks
@jimsmt jimsmt mentioned this pull request Oct 14, 2021
Closed
@MrSmallZzy MrSmallZzy mentioned this pull request Oct 15, 2021
Open
@da2x da2x mentioned this pull request Oct 15, 2021
Open
@Peter111111111111 Peter111111111111 mentioned this pull request Oct 17, 2021
Closed
@raydleemsc raydleemsc mentioned this pull request Oct 18, 2021
Open
@leefc01 leefc01 mentioned this pull request Oct 18, 2021
Closed
@c-schubert c-schubert mentioned this pull request Oct 19, 2021
Open
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Oct 19, 2021
Closed
@monroemann monroemann mentioned this pull request Oct 21, 2021
Closed
@eDave56 eDave56 mentioned this pull request Oct 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa Awaiting requested review from mihaiplesa

@yrliou yrliou Awaiting requested review from yrliou

@darkdh darkdh Awaiting requested review from darkdh

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @bbondy