[3] feat(tokens): tokens list, search and management ui #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
changed the title
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @types/[email protected], @uniswap/[email protected], [email protected], [email protected], [email protected] |
…ol/cowswap into refactor/token-search-ui
…ol/cowswap into refactor/token-search-ui
alfetopito
approved these changes
Oct 11, 2023
apps/cowswap-frontend/src/modules/tokensList/containers/TokenSearchResults/index.tsx
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/tokensList/containers/TokenSearchResults/index.tsx
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/tokensList/hooks/useAllTokensBalances.ts
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/tokensList/pure/SelectTokenModal/index.tsx
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/tokensList/pure/SelectTokenModal/index.tsx
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/tokensList/pure/TokensVirtualList/index.tsx
Show resolved
Hide resolved
| const bBalance = balances[b.address] | ||
|
|
||
| // Native always first | ||
| if (getIsNativeToken(a) || getIsNativeToken(b)) return 1 |
There was a problem hiding this comment.
Isn't this saying, even if b is native, a should come first? (because it returns always 1 when either is native)
There was a problem hiding this comment.
It's actually unreal situation. We have only one native token in the list
anxolin
reviewed
Oct 18, 2023
| const balance = balances ? balances[token.address] : null | ||
|
|
||
| if (balance?.loading || balancesLoading) { | ||
| return <styledEl.LoadingRows key={virtualRow.key}>{threeDivs()}</styledEl.LoadingRows> |
There was a problem hiding this comment.
more than threeDivs (their implementation), is better to describe their function: loadingElement
anxolin
approved these changes
Oct 18, 2023
anxolin
approved these changes
Oct 18, 2023
…ol/cowswap into refactor/token-search-ui # Conflicts: # apps/cowswap-frontend/src/modules/tokensList/pure/ModalHeader/index.tsx # apps/cowswap-frontend/src/modules/tokensList/types.ts # yarn.lock
* refactor(tokens): integrate TokenLogo component (#3197) * refactor(tokens): wire up components to new hooks (#3198) * refactor(tokens): remove Uniswap currency entities usage (#3199) * refactor(tokens): use new tokens UI and logic by default (#3200) * fix(tokens): fix e2e tests for tokens updates (#3193) * refactor(tokens): remove legacy code (#3194) * fix(tokens): fix tokens list loading state (#3201)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR touches only files in
modules/tokensList.The module is responsible for tokens UI. See cosmos fixtures here.
The first iteration of UI was add here. This PR complements and fixes it.
To Test
Please, test everything in #3201