Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screen suffix to all screens. #125

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Add Screen suffix to all screens. #125

merged 2 commits into from
Jun 30, 2022

Conversation

pixlwave
Copy link
Member

As discussed, this PR adds Screen to the few screens that were missing it and View where there isn't a clear SwiftUI option. 2 exceptions I've left as they are are MessageComposer TimelineStyler as both seem fine to me, but pointing out for discussion.

I've also updated the template so for ./createScreen SessionVerification SessionVerification the output will be

  • SessionVerificationCoordinator
  • SessionVerificationModels
  • SessionVerificationViewModel
  • SessionVerificationViewModelTests
  • SessionVerificationViewModelProtocol
  • SessionVerificationScreen
  • SessionVerificationScreenUITests

And I've tidied up TemplateScreen a bit more so there's less useless stuff in there from the start.

Happy to take feedback on any of this.

@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 843d289

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks absolutely great to me, 🚢 it!

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #125 (843d289) into develop (83a25d5) will increase coverage by 0.05%.
The diff coverage is 66.10%.

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
+ Coverage    26.86%   26.92%   +0.05%     
===========================================
  Files          154      154              
  Lines        10779    10785       +6     
  Branches      5260     5256       -4     
===========================================
+ Hits          2896     2904       +8     
+ Misses        7799     7797       -2     
  Partials        84       84              
Impacted Files Coverage Δ
...urces/Screens/BugReport/View/BugReportScreen.swift 85.14% <0.00%> (ø)
...ens/RoomScreen/View/MessageComposerTextField.swift 69.02% <0.00%> (+1.20%) ⬆️
...Sources/Screens/Settings/View/SettingsScreen.swift 78.40% <0.00%> (ø)
...reens/SplashScreen/View/SplashScreenPageView.swift 83.87% <0.00%> (ø)
.../SimpleScreenExample/ElementX/TemplateModels.swift 94.11% <ø> (ø)
...leScreenExample/ElementX/TemplateCoordinator.swift 54.54% <66.66%> (ø)
...leScreenExample/ElementX/View/TemplateScreen.swift 75.34% <70.96%> (ø)
...urces/Screens/BugReport/BugReportCoordinator.swift 45.23% <100.00%> (ø)
...Sources/Screens/Settings/SettingsCoordinator.swift 32.75% <100.00%> (ø)
...urces/Screens/SplashScreen/View/SplashScreen.swift 79.87% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a25d5...843d289. Read the comment docs.

@github-actions
Copy link

Changes in 125 (2022-06-30)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
  • Room timeline: Add plain styler and add timeline option in settings screen. (#92)
  • Implement and use background tasks. (#99)

🙌 Improvements

  • Implement new ClientBuilder pattern for login (#120)
  • Flatten the room list by removing the encrypted groups. (#121)
  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add the splash, login and server selection screens from Element iOS along with a UserSessionStore. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)
  • Add localizations to UI tests target and add some checks. (#101)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)
  • Fix Danger's changelog detection. (#74)

Others

  • Add Screen as a suffix to all screens and tidy up the template. (#125)
  • Fix project urls in Towncrier configuration. (#96)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/q1wpfH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants