-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Screen suffix to all screens. #125
Conversation
1e1bf46
to
7d1369d
Compare
Generated by 🚫 Danger Swift against 843d289 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks absolutely great to me, 🚢 it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## develop #125 +/- ##
===========================================
+ Coverage 26.86% 26.92% +0.05%
===========================================
Files 154 154
Lines 10779 10785 +6
Branches 5260 5256 -4
===========================================
+ Hits 2896 2904 +8
+ Misses 7799 7797 -2
Partials 84 84
Continue to review full report at Codecov.
|
Changes in 125 (2022-06-30)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build
Others
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/q1wpfH |
As discussed, this PR adds
Screen
to the few screens that were missing it andView
where there isn't a clear SwiftUI option. 2 exceptions I've left as they are areMessageComposer
TimelineStyler
as both seem fine to me, but pointing out for discussion.I've also updated the template so for
./createScreen SessionVerification SessionVerification
the output will beAnd I've tidied up TemplateScreen a bit more so there's less useless stuff in there from the start.
Happy to take feedback on any of this.