-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2s/merge master #3917
C2s/merge master #3917
Conversation
Improve error handling in mnesia API
Updating migration guide
Co-authored-by: Nelson Vides <[email protected]>
Document hooks refactor
Prepare Release 6.0.0
Added info about GraphQL to main page and user guide
The goal is to add the 'cth_surefire' hook, which will collect test results for CircleCI Insights.
The Insights need results in the JUnit XML format. This is achieved by using the 'cth_surefire' hook.
- Support parallel test failures - Close groups when end_per_suite is skipped or fails - Include group name in error messages
Enable CircleCI Test Insights
Fix common test error handling in cth_surefire
[merge after #3907] Test with OTP 25.2
It happens that handler to extend inbox entries want to fetch extra data for each entry, so if the hook is ran per message, the handler will have to make an extra query for each message, potentially incurring into way too many round trips to the DB. Instead, we can pass the whole buffer to the handler, so that the handler is able to aggregate as best as possible all the entries.
Inbox/extend messages
Simplify filter_room_packet
Remove list with headings in mod_vcard.md
Add a test to check this condition.
Previously missing keys or values would be reported as 'undefined', which could result in a crash (Mnesia) or would be silently converted to binaries (RDBMS).
Check push form fields
Refactored handlers to follow stop convention
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 73.22% // Head: 73.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3917 +/- ##
=====================================================
Coverage 73.22% 73.23%
=====================================================
Files 540 540
Lines 34187 34191 +4
=====================================================
+ Hits 25035 25041 +6
+ Misses 9152 9150 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f1f24db
to
c9141e3
Compare
small_tests_24 / small_tests / c9141e3 small_tests_25 / small_tests / c9141e3 ldap_mnesia_24 / ldap_mnesia / c9141e3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c9141e3 ldap_mnesia_25 / ldap_mnesia / c9141e3 pgsql_mnesia_24 / pgsql_mnesia / c9141e3 dynamic_domains_mysql_redis_25 / mysql_redis / c9141e3 internal_mnesia_25 / internal_mnesia / c9141e3 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c9141e3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c9141e3 riak_mnesia_24 / riak_mnesia / c9141e3 mysql_redis_25 / mysql_redis / c9141e3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c9141e3 inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12497.1>,
[{event_manager,<0.12468.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1514">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12468.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1514">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_backwards_1514">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_backwards_1514">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"15ec8117877ca95f">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12496.1>,
[{event_manager,<0.12475.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_pagination_overrides_form_1515">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12475.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_pagination_overrides_form_1515">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_pagination_overrides_form_1515">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_pagination_overrides_form_1515">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"9efb2bd103e38f03">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_e... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12494.1>,
[{event_manager,<0.12454.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_forwards_1512">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12454.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_forwards_1512">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_forwards_1512">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_forwards_1512">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"a23a4c1faed5aa1c">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-ca... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12498.1>,
[{event_manager,<0.12482.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1516">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12482.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1516">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_fetch_ahead_1516">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_fetch_ahead_1516">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"3cfe173cf6ee3720">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12499.1>,
[{event_manager,<0.12461.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_be_limited_1513">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12461.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_be_limited_1513">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1513">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1513">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"2b98d47cd3de333b">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
... mssql_mnesia_25 / odbc_mssql_mnesia / c9141e3 pgsql_mnesia_25 / pgsql_mnesia / c9141e3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c9141e3 inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12581.1>,
[{event_manager,<0.12558.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_be_limited_1515">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12558.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_be_limited_1515">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_be_limited_1515">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_be_limited_1515">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"446ca090a325b60d">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{in... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12582.1>,
[{event_manager,<0.12551.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_backwards_1514">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12551.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_backwards_1514">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_backwards_1514">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_backwards_1514">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"001f83fc77fffcc9">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extension... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12585.1>,
[{event_manager,<0.12565.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_fetch_ahead_1516">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12565.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_fetch_ahead_1516">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_fetch_ahead_1516">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_fetch_ahead_1516">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"c1f95fc918971a57">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12583.1>,
[{event_manager,<0.12544.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_pagination_overrides_form_1513">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12544.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_pagination_overrides_form_1513">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1513">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1513">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"741c79f144f53f65">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.12584.1>,
[{event_manager,<0.12537.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1512">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12537.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1512">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1512">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1512">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"aecf01f49c6f5d2e">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUI... dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c9141e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Just merge the latest master, which includes fixes to sasl_external, and the docs job