Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #271

Merged
merged 12 commits into from
Jun 24, 2021
Merged

3 ➡️ 4 #271

merged 12 commits into from
Jun 24, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-physics3 to ign-physics4

Branch comparison: ign-physics4...ign-physics3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

claireyywang and others added 10 commits May 3, 2021 15:15
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: anindex <[email protected]>

Co-authored-by: anindex <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Claire Wang <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
* base and entity features
* Add base Cmake and plugin dummy feature
* Replace dummy features with base ones
* Added Simulation Features (#168)
* added features
* [Bullet] Bullet classic, Add sdf entities (#167)
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model
* Kinematics features (#169)
* Kinematic Features
* Free Group Features (#171)
* [bullet] Basic Features (#172)
* Fixed gravity, pose, and corrected some auto variables
* [Bullet] Collision Features (#173)
* Collision working
* [bullet] Add find or construct link (#175)
* Add Find or Construct Link function
* Change function to return entity instead of identity
* Remove loop creating links inside model
* [Bullet] Mesh features (#178)
* Collision working
* [bullet] Joints implementation (#190)
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods
* Add basic tests
* Add missing override keyword
* Updated CMake and replaced using with structs for feature lists
* Save base when adding a mesh
* deleted worlds

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tomas Lorente <[email protected]>
Copied from #262.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* [Citadel] Update tutorials (#204)

Signed-off-by: claireyywang <[email protected]>
Signed-off-by: anindex <[email protected]>

Co-authored-by: anindex <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Claire Wang <[email protected]>
Co-authored-by: Steve Peters <[email protected]>

* Remove tools/code_check and update codecov (#257)

Signed-off-by: Louise Poubel <[email protected]>

* Fix dart deprecation warning (#263)

Copied from #262.

Signed-off-by: Steve Peters <[email protected]>

Co-authored-by: Claire Wang <[email protected]>
Co-authored-by: anindex <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Use [gs]etPrimarySlipCompliance with dart 6.10.0

These APIs are used in the upstream release of dartsim 6.10.0
and have been recently added to our fork, so start using them.

* Improve slip compliance test coverage

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Use [gs]etPrimarySlipCompliance with dart 6.10.0

These APIs are used in the upstream release of dartsim 6.10.0
and have been recently added to our fork, so start using them.

* Improve slip compliance test coverage

Signed-off-by: Steve Peters <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@chapulina chapulina requested a review from mxgrey as a code owner June 22, 2021 23:00
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jun 22, 2021
chapulina added a commit that referenced this pull request Jun 23, 2021
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (ign-physics4@04afa7d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             ign-physics4     #271   +/-   ##
===============================================
  Coverage                ?   74.86%           
===============================================
  Files                   ?      118           
  Lines                   ?     5227           
  Branches                ?        0           
===============================================
  Hits                    ?     3913           
  Misses                  ?     1314           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04afa7d...a1a8f8b. Read the comment docs.

@chapulina
Copy link
Contributor Author

I'd like to highlight the changes that were needed to port Bullet to ign-physics4 in a1a8f8b. It wasn't very obvious what to do from the long compiler errors with lots of templates. I expect external users that have custom physics plugins to run into a similar problems when migrating.

@chapulina chapulina merged commit c6cdea6 into ign-physics4 Jun 24, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch June 24, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants