Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bullet] Bullet classic, Add sdf entities #167

Merged
merged 4 commits into from
Nov 24, 2020

Conversation

Blast545
Copy link
Contributor

Changing internal base representation, and adding features to add/remove links

@Blast545 Blast545 changed the base branch from ign-physics3 to bullet_classic_dev November 20, 2020 20:35
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Nov 20, 2020
@Blast545 Blast545 marked this pull request as ready for review November 24, 2020 16:56
@Blast545 Blast545 removed 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Nov 24, 2020
@Blast545
Copy link
Contributor Author

@Lobotuerk With 37ab82d I added the auxiliar vector we discussed as a nive to have, to save IDs of links in a model, but didn't update the removeModel and similar methods to use it yet.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #167 (37ab82d) into bullet_classic_dev (810f9d9) will decrease coverage by 0.93%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           bullet_classic_dev     #167      +/-   ##
======================================================
- Coverage               81.62%   80.68%   -0.94%     
======================================================
  Files                     110      111       +1     
  Lines                    4043     4090      +47     
======================================================
  Hits                     3300     3300              
- Misses                    743      790      +47     
Impacted Files Coverage Δ
bullet/src/Base.hh 0.00% <0.00%> (ø)
bullet/src/EntityManagementFeatures.cc 0.00% <0.00%> (ø)
bullet/src/SDFFeatures.cc 0.00% <0.00%> (ø)
bullet/src/plugin.cc 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810f9d9...37ab82d. Read the comment docs.

Copy link

@Lobotuerk Lobotuerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blast545 Blast545 merged commit 5a5f1a4 into bullet_classic_dev Nov 24, 2020
@Blast545 Blast545 deleted the bullet_dev/addSDFEntities branch November 24, 2020 21:04
Blast545 added a commit that referenced this pull request Feb 3, 2021
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model

Signed-off-by: Jorge Perez <[email protected]>
Blast545 added a commit that referenced this pull request Feb 12, 2021
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model

Signed-off-by: Jorge Perez <[email protected]>
Blast545 added a commit that referenced this pull request Feb 12, 2021
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model

Signed-off-by: Jorge Perez <[email protected]>
Blast545 added a commit that referenced this pull request Feb 18, 2021
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model

Signed-off-by: Jorge Perez <[email protected]>
Lobotuerk pushed a commit that referenced this pull request May 19, 2021
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tomas Lorente <[email protected]>
Blast545 added a commit that referenced this pull request May 20, 2021
* base and entity features
* Add base Cmake and plugin dummy feature
* Replace dummy features with base ones
* Added Simulation Features (#168)
* added features
* [Bullet] Bullet classic, Add sdf entities (#167)
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model
* Kinematics features (#169)
* Kinematic Features
* Free Group Features (#171)
* [bullet] Basic Features (#172)
* Fixed gravity, pose, and corrected some auto variables
* [Bullet] Collision Features (#173)
* Collision working
* [bullet] Add find or construct link (#175)
* Add Find or Construct Link function
* Change function to return entity instead of identity
* Remove loop creating links inside model
* [Bullet] Mesh features (#178)
* Collision working
* [bullet] Joints implementation (#190)
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods
* Add basic tests
* Add missing override keyword
* Updated CMake and replaced using with structs for feature lists
* Save base when adding a mesh
* deleted worlds

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tomas Lorente <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants