-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bullet] Bullet classic, Add sdf entities #167
Conversation
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
6458fea
to
37ab82d
Compare
@Lobotuerk With 37ab82d I added the auxiliar vector we discussed as a nive to have, to save IDs of links in a model, but didn't update the removeModel and similar methods to use it yet. |
Codecov Report
@@ Coverage Diff @@
## bullet_classic_dev #167 +/- ##
======================================================
- Coverage 81.62% 80.68% -0.94%
======================================================
Files 110 111 +1
Lines 4043 4090 +47
======================================================
Hits 3300 3300
- Misses 743 790 +47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model Signed-off-by: Jorge Perez <[email protected]>
* Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model Signed-off-by: Jorge Perez <[email protected]>
* Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model Signed-off-by: Jorge Perez <[email protected]>
* Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model Signed-off-by: Jorge Perez <[email protected]>
* Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model Signed-off-by: Jorge Perez <[email protected]> Signed-off-by: Tomas Lorente <[email protected]>
* base and entity features * Add base Cmake and plugin dummy feature * Replace dummy features with base ones * Added Simulation Features (#168) * added features * [Bullet] Bullet classic, Add sdf entities (#167) * Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model * Kinematics features (#169) * Kinematic Features * Free Group Features (#171) * [bullet] Basic Features (#172) * Fixed gravity, pose, and corrected some auto variables * [Bullet] Collision Features (#173) * Collision working * [bullet] Add find or construct link (#175) * Add Find or Construct Link function * Change function to return entity instead of identity * Remove loop creating links inside model * [Bullet] Mesh features (#178) * Collision working * [bullet] Joints implementation (#190) * Add placeholders joint features * Iteration to add joints after links * sdfConstructJoint math fixed * added missing dummys * added constraint to the world * Change dummy functions print to debug * fixed position * friction * fixed sdfLinkSearch * Joint velocity command * working version tunnels * added joint position methods * Add basic tests * Add missing override keyword * Updated CMake and replaced using with structs for feature lists * Save base when adding a mesh * deleted worlds Signed-off-by: Jorge Perez <[email protected]> Signed-off-by: Tomas Lorente <[email protected]>
Changing internal base representation, and adding features to add/remove links