Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bullet] Joints implementation #190

Merged
merged 17 commits into from
Jan 12, 2021
Merged

[bullet] Joints implementation #190

merged 17 commits into from
Jan 12, 2021

Conversation

Blast545
Copy link
Contributor

No description provided.

Blast545 and others added 17 commits December 15, 2020 17:13
@Blast545
Add placeholders joint features
7561bf8 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Iteration to add joints after links
b5786c2 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Auxiliar commit, currently not compiling
537f27e 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Fix compilation problems
0e669ba 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Improve comments
3b58f76 
Signed-off-by: Jorge Perez <[email protected]>
@Lobotuerk @Blast545
sdfConstructJoint math fixed
861e92d 
Signed-off-by: Tomas Lorente <[email protected]>
@Lobotuerk
added missing dummys
7d2728f 
Signed-off-by: Tomas Lorente <[email protected]>
@Lobotuerk
added constraint to the world
eda5865 
Signed-off-by: Tomas Lorente <[email protected]>
@Blast545
Change dummy functions print to debug
d0f6e6b 
Signed-off-by: Jorge Perez <[email protected]>
@Lobotuerk
fixed position
7a04cf1 
Signed-off-by: Tomas Lorente <[email protected]>
@Lobotuerk
friction
faa3523 
Signed-off-by: Tomas Lorente <[email protected]>
@Lobotuerk
fixed sdfLinkSearch
ea7ee08 
Signed-off-by: Tomas Lorente <[email protected]>
@Lobotuerk
{}{}working{}{}.append()
431a9e2
Joint velocity command
1fe1b3c 
Signed-off-by: Gonzalo de Pedro <[email protected]>
Minor fix
08372fe 
Signed-off-by: Gonzalo de Pedro <[email protected]>
@Lobotuerk
working version tunnels
f51c0ed 
Signed-off-by: Tomas Lorente <[email protected]>
@Lobotuerk
added joint position methods
3525d57
@Blast545 Blast545 requested a review from mxgrey as a code owner January 12, 2021 18:41
@chapulina chapulina added the Bullet Bullet engine label Jan 12, 2021
Lobotuerk
Lobotuerk approved these changes Jan 12, 2021
View reviewed changes
Copy link

@Lobotuerk Lobotuerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blast545 Blast545 merged commit a2bd1fc into bullet_classic_dev Jan 12, 2021
@Blast545 Blast545 deleted the bulletDev/blast545/JointsImplementation branch January 12, 2021 20:13
Blast545 added a commit that referenced this pull request Jan 19, 2021
@Blast545 @Lobotuerk
[bullet] Joints implementation (#190)
52a7fa0 
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods

Co-authored-by: Tomas Lorente <[email protected]>
Co-authored-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Blast545 added a commit that referenced this pull request Feb 3, 2021
@Blast545 @Lobotuerk
[bullet] Joints implementation (#190)
d15a2b4 
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods

Co-authored-by: Tomas Lorente <[email protected]>
Co-authored-by: Gonzalo de Pedro <[email protected]>
Blast545 added a commit that referenced this pull request Feb 12, 2021
@Blast545 @Lobotuerk
[bullet] Joints implementation (#190)
403c166 
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods

Co-authored-by: Tomas Lorente <[email protected]>
Co-authored-by: Gonzalo de Pedro <[email protected]>
Blast545 added a commit that referenced this pull request Feb 12, 2021
@Blast545 @Lobotuerk
[bullet] Joints implementation (#190)
f243ade 
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods

Co-authored-by: Tomas Lorente <[email protected]>
Co-authored-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Blast545 added a commit that referenced this pull request Feb 18, 2021
@Blast545 @Lobotuerk
[bullet] Joints implementation (#190)
0767648 
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods

Co-authored-by: Tomas Lorente <[email protected]>
Co-authored-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Lobotuerk added a commit that referenced this pull request May 19, 2021
@Blast545 @Lobotuerk
[bullet] Joints implementation (#190)
a30f612 
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods

Co-authored-by: Tomas Lorente <[email protected]>
Co-authored-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tomas Lorente <[email protected]>
Blast545 added a commit that referenced this pull request May 20, 2021
@Blast545
Integrate bullet into ign-physics3 (#208)
0ec547b 
* base and entity features
* Add base Cmake and plugin dummy feature
* Replace dummy features with base ones
* Added Simulation Features (#168)
* added features
* [Bullet] Bullet classic, Add sdf entities (#167)
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model
* Kinematics features (#169)
* Kinematic Features
* Free Group Features (#171)
* [bullet] Basic Features (#172)
* Fixed gravity, pose, and corrected some auto variables
* [Bullet] Collision Features (#173)
* Collision working
* [bullet] Add find or construct link (#175)
* Add Find or Construct Link function
* Change function to return entity instead of identity
* Remove loop creating links inside model
* [Bullet] Mesh features (#178)
* Collision working
* [bullet] Joints implementation (#190)
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods
* Add basic tests
* Add missing override keyword
* Updated CMake and replaced using with structs for feature lists
* Save base when adding a mesh
* deleted worlds

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tomas Lorente <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lobotuerk Lobotuerk Lobotuerk approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey mxgrey is a code owner

Assignees
No one assigned
Labels
Bullet Bullet engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blast545 @Lobotuerk @chapulina