Install the common test executables to libexec #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the cmake code more readable. Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-physics6 #458 +/- ##
============================================
Coverage 75.82% 75.82%
============================================
Files 140 140
Lines 7066 7066
============================================
Hits 5358 5358
Misses 1708 1708 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scpeters
force-pushed
the
scpeters/install_common_tests
branch
from
049886a
to
79b5727
Compare
Signed-off-by: Steve Peters <[email protected]>
Also build the test_lib_loader as static library since the tests link against it. Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
scpeters/install_common_tests
branch
from
79b5727
to
45ddfac
Compare
|
I've updated |
|
this is ready for review |
ahcorde
approved these changes
Dec 9, 2022
azeey
reviewed
Dec 9, 2022
test/common_test/TestLibLoader.hh
Outdated
| } | ||
| } | ||
|
|
||
| std::string gz::physics::TestLibLoader::libToTest = std::string(""); |
There was a problem hiding this comment.
Defining a static variable in a header can be problematic. I recommend putting the variable in a private function and make it a singleton.
private: static std::string& TestLibLoader::LibToTest()
{
static std::string libToTest = "";
return libToTest;
}
Signed-off-by: Steve Peters <[email protected]>
azeey
approved these changes
Dec 12, 2022
scpeters
added a commit
to gazebo-release/gz-physics6-release
that referenced
this pull request
Jan 25, 2023
Follow-up to #15 and gazebosim/gz-physics#458. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #50 (comment)
Summary
This installs the
COMMON_TEST_*executables to a subfolder oflibexecfollowing the pattern used by the standalone executables added in gazebosim/gz-transport#216. This will allow these tests to be used by external implementers ofgz-physicsplugins. Thetest_lib_loaderlibrary is changed to a static library as well since these executables link against it.Remaining tasks:
resourcesfolder used by some testsworldsfolder used by some testsTest it
<prefix>/libexec/gz/physics6/COMMON_TEST_construct_empty_world <prefix>/lib/libgz-physics6-dartsim-plugin.<suffix>Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.