Update SdfGenerator to save light data to file #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
8 tasks
Signed-off-by: Ian Chen <[email protected]>
chapulina
added
editor
Signed-off-by: Ian Chen <[email protected]>
8 tasks
7 tasks
|
@osrf-jenkins retest this please |
nkoenig
approved these changes
Nov 30, 2021
* save joints Signed-off-by: Ian Chen <[email protected]> * use joinPaths Signed-off-by: Ian Chen <[email protected]> * Only output thread_pitch for screw joints Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
|
I'm going to merge this done in order to speed up and consolidate the CI tests. |
nkoenig
pushed a commit
that referenced
this pull request
Dec 1, 2021
* update more model properties and add code to update link properties Signed-off-by: Ian Chen <[email protected]> * update sensors, and add test Signed-off-by: Ian Chen <[email protected]> * Suggestion to #1170 Signed-off-by: Nate Koenig <[email protected]> * update to use new api Signed-off-by: Ian Chen <[email protected]> * use updated api Signed-off-by: Ian Chen <[email protected]> * require sdf 12.2 Signed-off-by: Nate Koenig <[email protected]> * Update SdfGenerator to save light data to file (#1209) * save lights Signed-off-by: Ian Chen <[email protected]> * fix doc Signed-off-by: Ian Chen <[email protected]> * use updated api Signed-off-by: Ian Chen <[email protected]> * Update SdfGenerator to save joint data to file (#1220) * save joints Signed-off-by: Ian Chen <[email protected]> * use joinPaths Signed-off-by: Ian Chen <[email protected]> * Only output thread_pitch for screw joints Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
depends on #gazebosim/sdformat#755
related PR: #1201
Summary
Builds on the work done in #1201, this PR extends the SdfGenerator with the ability to save light data to SDF file. This works for spot, point, and directional lights in the world and also lights attached to links.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge