-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6 ➡️ 7 (main) #1446
6 ➡️ 7 (main) #1446
Conversation
As discussed in #1158, a segfault occurs during exit because Views created as a result of an ECM query by plugins have their destructors stored in the shared library of the plugin. For GUI plugins, the plugins are unloaded from memory before the ECM is destructed, so when it's time to destruct the Views, a segfault occurs because the pointer to the virtual destructor is invalid. This PR is fixes the problem by making View a regular class instead of a template. This ensures that the destructor of View is stored in the core library of ignition-gazebo. As a result, the ECM can be destructed after GUI plugins have been unloaded. Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Ashton Larkin <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Aditya <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]>
To avoid conflicts between different major versions, add the major version to the svg filename.
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Fix CMake version examples and bump plugin version Signed-off-by: methylDragon <[email protected]> * Fix example CMake version Signed-off-by: methylDragon <[email protected]> * Fix typo in docs Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
This PR adds some infrastructure for being able to create comms systems. A comms system lets you send and receive data under the constrains of a given comms model. The comms model specifies when and how messages should be delivered to its destinations. Subscribers create a regular callback via Ignition Transport and send a request to a centralized broker to bind an address, the robot attached to the address and the topic name used as a callback. Publishers fill a Dataframe message specifying the addresses of the sender and destination and set the payload. Then, publishers need to send via Ignition Transport the message to the centralized broker. Besides the general infrastructure, this PR contains two systems: PerfectComms and CommsEndpoint. PerfectComms is an example of a comms system. As required, it implements the ICommsModel interface and it always delivers the messages to their destinations. CommsEndpoint is a helper system that can be optionally attached to a model (see examples/worlds/comms.sdf) and lets you assign an address to a robot and the subscription topic. The system automatically connects with the broker and bind this address/robot for you. You could do this process manually if needed but I think it's convenient for most of the users. Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]>
|
Yup, this needs gazebosim/gz-msgs#244 to go in first and then some nightlies |
* RFComms system Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
4e9a8b4
to
5c7c8fa
Compare
Codecov Report
@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
Coverage 35.01% 35.01%
=======================================
Files 44 44
Lines 2356 2356
=======================================
Hits 825 825
Misses 1531 1531 Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
I'm not sure what's up with the failure on Jenkins Ubuntu:
GitHub actions was able to install all dependencies just fine, and I can't reproduce the issue locally. I've already tried cleaning the workspace. Maybe there's some other caching going on? CC @j-rivero |
Should be fixed by There are |
CI status:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for 2e8892a to work,
gazebosim/gz-sensors#186 and
gazebosim/gz-sensors#212 would also need to be forward ported from ign-sensors
Signed-off-by: Louise Poubel <[email protected]>
Thanks, I think those have already been ported on these PRs A convenient way to check what hasn't been ported yet is to click on the links on this table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, hopefully no errors other than these : #1446 (comment)
6 ➡️ 7
ign-gazebo6
tomain
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)