Add override for proxy_intercept_errors when using Custom HTTP Errors

[chriss-de]

This PR adds a new flag to the global ConfigMap configurations and Ingress Annotations to disable the proxy_intercept_errors setting in nginx.conf when using CustomHTTPErrors.

What this PR does / why we need it:

The motivation behind this change is to enable the use case outlined in #8376. We would like to be able to override the default nginx error pages (e.g. 503 service unavailable and 404 not found) with a custom error page without intercepting genuine error responses from proxied services.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #8376
solves #9026
solves #8435

How Has This Been Tested?

Added unit tests to cover this change. Tested in our datacenter and confirmed fix by applying annotations for proxy-intercept-errors and custom-http-errors.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Added annotation to control if proxy-intercept-errors are enabled when custom-http-errors are enabled.
Added configmap option to control if proxy-intercept-errors are enabled when custom-http-errors are enabled in configmap.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: chriss-de (6f9b17d, 3ab85e6)

[k8s-ci-robot]

@chriss-de: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @chriss-de. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chriss-de
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval by writing /assign @tao12345666333 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chriss-de]

Also solves #9211

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 651b846 Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 (Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 #9398)
• 17d8266 Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Bump github.com/prometheus/common from 0.37.0 to 0.39.0 #9416)
• 6070c8b Bump ossf/scorecard-action from 2.0.6 to 2.1.0 (Bump ossf/scorecard-action from 2.0.6 to 2.1.0 #9422)
• 07db499 Bump actions/dependency-review-action from 3.0.1 to 3.0.2 (Bump actions/dependency-review-action from 3.0.1 to 3.0.2 #9424)
• bd283b6 Bump goreleaser/goreleaser-action from 3.2.0 to 4.1.0 (Bump goreleaser/goreleaser-action from 3.2.0 to 4.1.0 #9426)
• 87146d6 Bump actions/checkout from 3.1.0 to 3.2.0 (Bump actions/checkout from 3.1.0 to 3.2.0 #9425)
• 7ef5e1a Bump github/codeql-action from 2.1.36 to 2.1.37 (Bump github/codeql-action from 2.1.36 to 2.1.37 #9423)
• cd80cb6 Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 (Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 #9421)
• a667c93 Bump golang.org/x/crypto from 0.3.0 to 0.4.0 (Bump golang.org/x/crypto from 0.3.0 to 0.4.0 #9397)
• 54dd88a Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Bump golang.org/x/crypto from 0.4.0 to 0.5.0 #9494)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chriss-de]

I screwed it up by doing a merge instead of rebase. my bad.

I'll open up a new PR because I don't know how to fix it otherwise.