Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Symbols #403

Merged
merged 35 commits into from
Aug 6, 2014
Merged

Symbols #403

merged 35 commits into from
Aug 6, 2014

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Aug 6, 2014

Moves text and icons to a shared render type

@kkaefer
Copy link
Contributor Author

kkaefer commented Aug 6, 2014

Comparison JS vs. native:

out
out2

@kkaefer
Copy link
Contributor Author

kkaefer commented Aug 6, 2014

Font differences on native vs. JS could be rounding issues during buffer creation. JS doesn't properly switch to GL_NEAREST when not panning/rotating, so the icons look blurry there.

@mourner
Copy link
Member

mourner commented Aug 6, 2014

So awesome! I can't believe you've put such a crazy amount of porting work in such a short time.

@mourner
Copy link
Member

mourner commented Aug 6, 2014

JS doesn't properly switch to GL_NEAREST when not panning/rotating, so the icons look blurry there.

Regression? Lets ticket.

kkaefer added a commit that referenced this pull request Aug 6, 2014
@kkaefer kkaefer merged commit 6dc3911 into master Aug 6, 2014
@ansis
Copy link
Contributor

ansis commented Aug 6, 2014

amazing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants