sync with master fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application Security Groups now GA
…ase-rson-updates resource/azurerm_sql_database: Fix requested_service_objective_name updates
This was missing from the original implementation and is required if you want to manually mark servers as active
resource/application_Gateway: Add minimum_servers to probe resource
Virtual Network Gateway - fixing a set error
* Initial support for Azure Key Vault Policy resource * Updated to fix the test broken from updating the source code. We don't need to wait for keyvaults creationg as we aren't creating keyvaults * Addressed PR comments * Return nil on a delete for the shared delete/update function * Removed reference to old code * Starting to address PR comments * Starting to address PR comments * Working my way through the PR comments * Fixed some of the tests * Ran make fmt * Fixed website links * Updated route test to fail * Updated to support importing an access policy * Updated to support importing of the resource and some enhanced tests * Reverted route_test to not fail for this pr * Working through pr comments * Updated for PR comments as well as added several unittests for the key_vault_access_policy shared helper library * Ran make fmt * Refactoring the helpers into the `helpers/schema` folder Ensuring we only lock on the Key Vault name, since the access policy doesn't matter for locking purposes if we lock on the entire KeyVault ``` $ acctests azurerm TestAccAzureRMKeyVaultAccessPolicy_ === RUN TestAccAzureRMKeyVaultAccessPolicy_basic --- PASS: TestAccAzureRMKeyVaultAccessPolicy_basic (222.29s) === RUN TestAccAzureRMKeyVaultAccessPolicy_multiple --- PASS: TestAccAzureRMKeyVaultAccessPolicy_multiple (228.28s) === RUN TestAccAzureRMKeyVaultAccessPolicy_update --- PASS: TestAccAzureRMKeyVaultAccessPolicy_update (238.59s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 689.209s ``` * Adding import tests / clarifying the import docs Tests pass: ``` $ acctests azurerm TestAccAzureRMKeyVaultAccessPolicy_import === RUN TestAccAzureRMKeyVaultAccessPolicy_importBasic --- PASS: TestAccAzureRMKeyVaultAccessPolicy_importBasic (225.81s) === RUN TestAccAzureRMKeyVaultAccessPolicy_importMultiple --- PASS: TestAccAzureRMKeyVaultAccessPolicy_importMultiple (218.71s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 444.557s ``` * Handling the case of an AppID and no AppID being specified / refactoring tests * Fixing the error message * Documentation fixes
…torage scheduler_job: Added storage queue support
…ace-sas new resource: azurerm_servicebus_namespace_authorization_rule
…ules New Resource: `azurerm_data_lake_store_firewall_rule`
* azurerm_storage_account: limit tag names to 128 characters * fixing the imports
…ng-props azurerm_automation_schedule - Add missing properties for the advanced schedule
New data source: azurerm_log_analytics_workspace
application gateway docs: url_path_map -> url_path_map_name
* Added max_pods to agent_pool_profiles in azurerm_kubernetes_cluster * Added ForceNew and Default to max_pods * Added max_pods to data_source_kubernetes_cluster agent_profile * Updated the docs to include max_pods * Fixed my terrible English. (I'm a flawed person) * Changed max_pods to computed field * Fixed max_pods field (added optional flag back in) * Conditionally passing max_pods to SDK * Removed default pod count from documentation * Added test coverage for max_pods * Fixed intentation * Trying to fix indentations
* Added kubernetes_cluster advanced network creation * Changed network_profile from TypeSet to TypeList * Added kubernetes_cluster advanced network creation * Changed network_profile from TypeSet to TypeList * Updated ForceNew attributes on kubernetes_cluster.network_profile params * Added advanced network read functionality * Added tests for kubernetes_cluster.network_profile * Fixed indentations * Fixed function name in tests * Fixed property name in test * Fixed variable name * working on data source for kubernetes cluster * Fixed issue with datasource not working * Added network_policy and fixed read * Removed network_policy as unsupported * Added example of advanced networking * Added test for data_source * Made address space more sensible * Removing kubenet test. This is default when network_profile is not specified. We already test this. * Made network_plugin a mandatory field. Better to make this explicit. * Updated documentation to include network_profile * Fixing the build * Added ForceNew to network_profile * Made the docs a little clearer * Documenting a required field * Rephrasing the data sources * Making the `network_profile` block computed Tests pass: ``` $ acctests azurerm TestAccAzureRMKubernetesCluster_basic === RUN TestAccAzureRMKubernetesCluster_basic --- PASS: TestAccAzureRMKubernetesCluster_basic (1329.57s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 1329.613s ``` * Fixing the field we're asserting on * Conditionally expanding the network_profile block. The ip fields are now Computed too * Validation to ensure that a Subnet ID is assigned to the cluster when the network_profile blocks specified Example: ``` Error: Error running plan: 1 error(s) occurred: * azurerm_kubernetes_cluster.test: 1 error(s) occurred: * azurerm_kubernetes_cluster.test: If a `network_profile` block is specified, the Agent Pools must be attached to a Subnet ``` * Updating the documentation to mention the new behaviour * Adding independent tests for Kubenet and Azure networking profiles * Conditional validation of the `docker_bridge_cidr`, `dns_service_ip` and `service_cidr` fields. * Updating the docs * Fixing the tests * Adding back in the changes from PR #1502 since they were lost in the merge * Renaming the methods to `addonProfiles` to match the sdk * fixing the quotes
…work_plugin is set to 'azure'. (#1763) * Added validation for pod_cidr * Changed wording of error message
martinbjorgan
pushed a commit
that referenced
this pull request
Aug 15, 2018
Fixes for `azurerm_policy_definition`
martinbjorgan
pushed a commit
that referenced
this pull request
Aug 15, 2018
martinbjorgan
pushed a commit
that referenced
this pull request
Aug 15, 2018
martinbjorgan
pushed a commit
that referenced
this pull request
Oct 13, 2020
* init * add client.go. fix check test package sh * init add client + go mod addition * working client * initial work for virtual desktop workspace * init host pool resource * add host pool resource * add app group * add workspace application group association resource * update association tests * update app association and host pool * added documentation desktopvirtualization * Update virtual desktop resources * simpler error step for testing association
katbyte
pushed a commit
that referenced
this pull request
Oct 29, 2020
Changes after first pull request
martinbjorgan
pushed a commit
that referenced
this pull request
Nov 2, 2020
Fixed bug when deleting a policy
martinbjorgan
pushed a commit
that referenced
this pull request
Jan 18, 2021
Ensure conditionally required identity fields are valid
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.