sync with master fork #1

Application Security Groups now GA

…pdates

…ase-rson-updates resource/azurerm_sql_database: Fix requested_service_objective_name updates

…lient_protocols`, introduced to the resource in #946 Fixes #1496

This was missing from the original implementation and is required if you want to manually mark servers as active

resource/application_Gateway: Add minimum_servers to probe resource

Virtual Network Gateway - fixing a set error

* Initial support for Azure Key Vault Policy resource * Updated to fix the test broken from updating the source code. We don't need to wait for keyvaults creationg as we aren't creating keyvaults * Addressed PR comments * Return nil on a delete for the shared delete/update function * Removed reference to old code * Starting to address PR comments * Starting to address PR comments * Working my way through the PR comments * Fixed some of the tests * Ran make fmt * Fixed website links * Updated route test to fail * Updated to support importing an access policy * Updated to support importing of the resource and some enhanced tests * Reverted route_test to not fail for this pr * Working through pr comments * Updated for PR comments as well as added several unittests for the key_vault_access_policy shared helper library * Ran make fmt * Refactoring the helpers into the `helpers/schema` folder Ensuring we only lock on the Key Vault name, since the access policy doesn't matter for locking purposes if we lock on the entire KeyVault ``` $ acctests azurerm TestAccAzureRMKeyVaultAccessPolicy_ === RUN TestAccAzureRMKeyVaultAccessPolicy_basic --- PASS: TestAccAzureRMKeyVaultAccessPolicy_basic (222.29s) === RUN TestAccAzureRMKeyVaultAccessPolicy_multiple --- PASS: TestAccAzureRMKeyVaultAccessPolicy_multiple (228.28s) === RUN TestAccAzureRMKeyVaultAccessPolicy_update --- PASS: TestAccAzureRMKeyVaultAccessPolicy_update (238.59s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 689.209s ``` * Adding import tests / clarifying the import docs Tests pass: ``` $ acctests azurerm TestAccAzureRMKeyVaultAccessPolicy_import === RUN TestAccAzureRMKeyVaultAccessPolicy_importBasic --- PASS: TestAccAzureRMKeyVaultAccessPolicy_importBasic (225.81s) === RUN TestAccAzureRMKeyVaultAccessPolicy_importMultiple --- PASS: TestAccAzureRMKeyVaultAccessPolicy_importMultiple (218.71s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 444.557s ``` * Handling the case of an AppID and no AppID being specified / refactoring tests * Fixing the error message * Documentation fixes

…torage scheduler_job: Added storage queue support

…ace-sas new resource: azurerm_servicebus_namespace_authorization_rule

…ules New Resource: `azurerm_data_lake_store_firewall_rule`

* azurerm_storage_account: limit tag names to 128 characters * fixing the imports

cosmos db account - fixes for #1525

Fix to not drop MySQL and PostgreSQL DB when storage_mb value is changed

…#1535) * Ensuring Key Vault Key's detect when the parent Key Vault's have been deleted Also adds tests for the other resources * Adding debug lines

…1534) * Remove tags validate in preConfig TestAccAzureRMKeyVault_update * validate preConfig tags.%=0 in TestAccAzureRMKeyVault_update

* Add an AD Application provider. Split from PR #961. * Rename resource to azurerm_azuread_application and update function names to match. * Address code review comments. * Remove Password/Key Credentials to turn them into resources. * Refactoring: - updating the acceptance tests to prefix the name with `acctest` so it's easily identifyable - wrapping the error messages to display more useful information - ensuring we disable apps or other tenants before deleting them - making available_to_other_tenants / oauth2_allow_implicit_flow not computed - updating the docs ``` $ acctests azurerm TestAccAzureRMActiveDirectoryApplication_ === RUN TestAccAzureRMActiveDirectoryApplication_importBasic --- PASS: TestAccAzureRMActiveDirectoryApplication_importBasic (38.38s) === RUN TestAccAzureRMActiveDirectoryApplication_importComplete --- PASS: TestAccAzureRMActiveDirectoryApplication_importComplete (25.42s) === RUN TestAccAzureRMActiveDirectoryApplication_basic --- PASS: TestAccAzureRMActiveDirectoryApplication_basic (20.18s) === RUN TestAccAzureRMActiveDirectoryApplication_availableToOtherTenants --- PASS: TestAccAzureRMActiveDirectoryApplication_availableToOtherTenants (21.60s) === RUN TestAccAzureRMActiveDirectoryApplication_complete --- PASS: TestAccAzureRMActiveDirectoryApplication_complete (20.19s) === RUN TestAccAzureRMActiveDirectoryApplication_update --- PASS: TestAccAzureRMActiveDirectoryApplication_update (39.92s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 165.735s ```

…er (#1546)

Tests pass: ``` $ acctests azurerm TestAccDataSourceAzureRMAzureADApplication_ === RUN TestAccDataSourceAzureRMAzureADApplication_byObjectId --- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectId (19.70s) === RUN TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete --- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete (22.12s) === RUN TestAccDataSourceAzureRMAzureADApplication_byName --- PASS: TestAccDataSourceAzureRMAzureADApplication_byName (33.22s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 75.073s ```

…ion.html.markdown

…-app New Data Source: `azurerm_azuread_application`

…1563) Fixes: #822 This follows the work in the API to allow types like web, other, java, store, phone and ios ``` ▶ acctests azurerm TestAccAzureRMApplicationInsights_ === RUN TestAccAzureRMApplicationInsights_importBasicWeb --- PASS: TestAccAzureRMApplicationInsights_importBasicWeb (99.07s) === RUN TestAccAzureRMApplicationInsights_importBasicOther --- PASS: TestAccAzureRMApplicationInsights_importBasicOther (96.48s) === RUN TestAccAzureRMApplicationInsights_basicWeb --- PASS: TestAccAzureRMApplicationInsights_basicWeb (84.27s) === RUN TestAccAzureRMApplicationInsights_basicJava --- PASS: TestAccAzureRMApplicationInsights_basicJava (79.28s) === RUN TestAccAzureRMApplicationInsights_basicOther --- PASS: TestAccAzureRMApplicationInsights_basicOther (73.29s) === RUN TestAccAzureRMApplicationInsights_basicPhone --- PASS: TestAccAzureRMApplicationInsights_basicPhone (73.88s) === RUN TestAccAzureRMApplicationInsights_basicStore --- PASS: TestAccAzureRMApplicationInsights_basicStore (68.69s) === RUN TestAccAzureRMApplicationInsights_basiciOS --- PASS: TestAccAzureRMApplicationInsights_basiciOS (76.30s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 651.307s ```

…ional values (#1565) Fixes: #1537 This was a simple fix to make sure that we were not passing empty strings to the API. When passing empty strings, it was including those strings in the subscription rule We should only set the part of the rule if it is required as, technically, a rule of sys.To = `` is actually value

VMSS: changed sku property from a set to list to help with #930

…1567) Fixes: 1328 Modelled on that of app_service

…e_ttl (#1568) Fixes: #1566 This wasn't being passed to the Create func even though the user could define it

It appears that - was omitted from the possible character in snapshot names. It doesn't seem like there is any issue when using - in the name, as I was able to create snapshots with dashes both from the portal and through this plugin (with this patch applied).

New Resource - azurerm_servicebus_queue_authorization_rule

* Support in-place update of app service slots - Upgrade to 2018-02-01 of the App Service API - Remove `ForceNew` on several slot attributes and update them in place * Translate IP restrictions addresses in new web app API - Translate between CIDR-format IP addresses (a.b.c.d/x) and IP/subnet mask combination - Add additional test IP restriction to capture CIDR address translation

* resource/app_service: Add support for site_config FtpsState Fixes: #1467 * Update app_service.html.markdown

* resource/app_service_slot: Add support for enabling MSI Fixes: #1268 * App Service -> App Service Slot

#1544) This fix was originally contributed by @sophos-jeff in #1349 but has been split-out This allows Azure CLI auth to be used to accessing Key Vaults, which fixes #656.

Fixes: #580

* Added imageRegistryCredentials to container group * Update docs to add image_registry_credentials * Added test and fixes from pr #1509 * Fix up review feedback * Further tests and tweaks * Reverting the LinuxBasic test Tests pass: ``` $ acctests azurerm TestAccAzureRMContainerGroup_linuxBasic === RUN TestAccAzureRMContainerGroup_linuxBasic --- PASS: TestAccAzureRMContainerGroup_linuxBasic (86.67s) === RUN TestAccAzureRMContainerGroup_linuxBasicUpdate --- PASS: TestAccAzureRMContainerGroup_linuxBasicUpdate (107.92s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 194.641s ```

@APErebus

* Do not load WEBSITE_CONTENT app settings when on a consumption plan * Inverse the dynamic plan check, thanks @APErebus * '%s' -> %q for safety * Add a nil check * Added tests to ensure the settings are removed: ``` $ acctests azurerm TestAccAzureRMFunctionApp_basic === RUN TestAccAzureRMFunctionApp_basic --- PASS: TestAccAzureRMFunctionApp_basic (111.90s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 111.938s ``` ``` $ acctests azurerm TestAccAzureRMFunctionApp_consumptionPlan === RUN TestAccAzureRMFunctionApp_consumptionPlan --- PASS: TestAccAzureRMFunctionApp_consumptionPlan (143.36s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 143.406s ```

* added new resource resource_arm_servicebus_queue_authorization_rule * updates & add docs * Update service bus topic auth rule tests * new resource - azurerm_eventhub_namespace_authorizzation_rule * Documentation fixes * Switching to use the Namespaces client * Consistency * Fixing a test failure

Improve awkward wording in `quota` description

Fixes #1470 (comment)

* Vendoring the Logic App SDK * New Resource: `azurerm_logic_app_workflow` Tests pass: ``` $ acctests azurerm TestAccAzureRMLogicAppWorkflow_ === RUN TestAccAzureRMLogicAppWorkflow_empty --- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s) === RUN TestAccAzureRMLogicAppWorkflow_tags --- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s) === RUN TestAccAzureRMLogicAppWorkflow_actionHTTP --- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 256.212s ``` Fixes #610 * Upgrading Logic Apps to v18.0.0 of the Azure SDK for Go * Moving Actions and Triggers out to separate objects ``` $ acctests azurerm TestAccAzureRMLogicAppWorkflow_ === RUN TestAccAzureRMLogicAppWorkflow_importEmpty --- PASS: TestAccAzureRMLogicAppWorkflow_importEmpty (71.95s) === RUN TestAccAzureRMLogicAppWorkflow_importTags --- PASS: TestAccAzureRMLogicAppWorkflow_importTags (69.51s) === RUN TestAccAzureRMLogicAppWorkflow_empty --- PASS: TestAccAzureRMLogicAppWorkflow_empty (66.77s) === RUN TestAccAzureRMLogicAppWorkflow_tags --- PASS: TestAccAzureRMLogicAppWorkflow_tags (81.51s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 289.789s ``` * New Resource: `azurerm_logic_app_action_http` Tests pass: ``` $ acctests azurerm TestAccAzureRMLogicAppActionHttp_ === RUN TestAccAzureRMLogicAppActionHttp_basic --- PASS: TestAccAzureRMLogicAppActionHttp_basic (65.75s) === RUN TestAccAzureRMLogicAppActionHttp_headers --- PASS: TestAccAzureRMLogicAppActionHttp_headers (61.97s) === RUN TestAccAzureRMLogicAppActionHttp_disappears --- PASS: TestAccAzureRMLogicAppActionHttp_disappears (77.38s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 205.136s ``` * New Resources: `azurerm_logic_app_trigger_http_request` / `azurerm_logic_app_trigger_recurrence` - Adding documentation for all of the resources - Making the test check functions more generic * New Resource: `azurerm_logic_app_action_custom` * New Resource: `azurerm_logic_app_trigger_custom` * Adding an example of how to use a logic app * New Data Source: `azurerm_logic_app_workflow` ``` $ acctests azurerm TestAccDataSourceAzureRMLogicAppWorkflow_ === RUN TestAccDataSourceAzureRMLogicAppWorkflow_basic --- PASS: TestAccDataSourceAzureRMLogicAppWorkflow_basic (69.73s) === RUN TestAccDataSourceAzureRMLogicAppWorkflow_tags --- PASS: TestAccDataSourceAzureRMLogicAppWorkflow_tags (67.28s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 137.042s ``` * Fixing issues raised during code review * Adding a customizeDiff for http requests * Returning an error rather than removing the state

Load Balancer: making the `subnet_id` a nilable field

docs/r/application_gateway: clarify path based routing

…xisting resource (#1598) * Fixes for #1597 * jeffreycline

Added changes to MySQL and PostgreSQL

* Making the messaging highlight consistent * New Resources: `azurerm_notification_hub` & `azurerm_notification_hub_namespace` * Fixing a merge conflict * Vendoring v18.0.0 of the Notification Hubs SDK * Sidebar: making the message highlight consistent * Adding placeholders for the documentation * Fixing Notification Hub Namespaces ``` $ acctests azurerm TestAccAzureRMNotificationHubNamespace_ === RUN TestAccAzureRMNotificationHubNamespace_importFree --- PASS: TestAccAzureRMNotificationHubNamespace_importFree (134.35s) === RUN TestAccAzureRMNotificationHubNamespace_free --- PASS: TestAccAzureRMNotificationHubNamespace_free (126.57s) === RUN TestAccAzureRMNotificationHubNamespace_updateSku --- PASS: TestAccAzureRMNotificationHubNamespace_updateSku (143.16s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 404.111s ``` * New Data Source: `azurerm_notification_hub_namespace` ``` $ acctests azurerm TestAccDataSourceAzureRMNotificationHubNamespace_free === RUN TestAccDataSourceAzureRMNotificationHubNamespace_free --- PASS: TestAccDataSourceAzureRMNotificationHubNamespace_free (130.03s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 130.081s ``` * New Resource `azurerm_notification_hub` ``` $ acctests azurerm TestAccAzureRMNotificationHub_basic === RUN TestAccAzureRMNotificationHub_basic --- PASS: TestAccAzureRMNotificationHub_basic (284.22s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 284.273s ``` * New Data Source: `azurerm_notification_hub` ``` ``` * Working around a bug where APNS/GCM credentials couldn't be removed Renaming the fields to better match the portal/terms used in Apple/Google Dev Portals * Better documenting the Token field * New Resource: `azurerm_notification_hub_authorization_rule` Tests pass: ``` ``` * Polling on our own, since the delete Future's broken Tests pass: ``` $ acctests azurerm TestAccAzureRMNotificationHubNamespace_ === RUN TestAccAzureRMNotificationHubNamespace_importFree --- PASS: TestAccAzureRMNotificationHubNamespace_importFree (71.04s) === RUN TestAccAzureRMNotificationHubNamespace_free --- PASS: TestAccAzureRMNotificationHubNamespace_free (73.17s) === RUN TestAccAzureRMNotificationHubNamespace_updateSku --- PASS: TestAccAzureRMNotificationHubNamespace_updateSku (86.43s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 230.677s ``` * Fixing a bug in the tests * Adding an acceptance test to ensure the access keys are set * Adding a link to the bug * Making SKU Name Force-New due to a difference in the API ``` azurerm_notification_hub_namespace.test: Error creating/updating Notification Hub Namesapce "acctestnhn-4049058900878420170" (Resource Group "acctestrg-4049058900878420170"): notificationhubs.NamespacesClient#CreateOrUpdate: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="Conflict" Message="Namespace acctestnhn-4049058900878420170 is in state Created. Cannot update the property" ``` * repeatidly triggering deletes * Removing dead code / adding a comment for why we re-trigger deletion * Moving the APNS Endpoints to Constants

* New Resource: `azurerm_azuread_service_principal` Tests pass: ``` $ acctests azurerm TestAccAzureRMActiveDirectoryServicePrincipal_ === RUN TestAccAzureRMActiveDirectoryServicePrincipal_importBasic --- PASS: TestAccAzureRMActiveDirectoryServicePrincipal_importBasic (24.04s) === RUN TestAccAzureRMActiveDirectoryServicePrincipal_basic --- PASS: TestAccAzureRMActiveDirectoryServicePrincipal_basic (17.61s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 41.701s ``` * New Data Source: `azurerm_azuread_service_principal` Tests pass: ``` $ acctests azurerm TestAccDataSourceAzureRMAzureADServicePrincipal_ === RUN TestAccDataSourceAzureRMAzureADServicePrincipal_byApplicationId --- PASS: TestAccDataSourceAzureRMAzureADServicePrincipal_byApplicationId (34.96s) === RUN TestAccDataSourceAzureRMAzureADServicePrincipal_byDisplayName --- PASS: TestAccDataSourceAzureRMAzureADServicePrincipal_byDisplayName (23.48s) === RUN TestAccDataSourceAzureRMAzureADServicePrincipal_byObjectId --- PASS: TestAccDataSourceAzureRMAzureADServicePrincipal_byObjectId (62.43s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 120.900s ``` * New Resource: `azurerm_azuread_service_principal_password` Tests pass: ``` $ acctests azurerm TestAccAzureRMActiveDirectoryServicePrincipalPassword_ === RUN TestAccAzureRMActiveDirectoryServicePrincipalPassword_basic --- PASS: TestAccAzureRMActiveDirectoryServicePrincipalPassword_basic (36.08s) === RUN TestAccAzureRMActiveDirectoryServicePrincipalPassword_customKeyId --- PASS: TestAccAzureRMActiveDirectoryServicePrincipalPassword_customKeyId (26.22s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 62.335s ``` * Fixing the broken objectID test ``` $ acctests azurerm TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete === RUN TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete --- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete (33.13s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 33.179s ```

Additional checks for network_rules during read

…e_analytics_firewall_rule

* update to build with latest terraform provider code * update tests * follow up * fixes for notification operation and scale value int to string * Update to the newer SDK types. * Add autoscale setting to the provider. * Fix the coding style of test cases. * Fix styles of resource definition code. * Initial refactoring to remove crashes * Moving to the undeprecated SDK * Refactoring to avoid crashes / ensure fields are always set * `time_zone` -> `timezone` to match the other resources. Removing `frequency` since it needs defaulting * Rewriting the documentation / fixing making the highlights consistent * Removing a remnant of the frequency field * Setting custom_emails correctly / defaulting timezones to UTC * Monitoring -> Monitor * Adding a test for multipleprofiles / additional cleanup Tests pass: ``` $ acctests azurerm TestAccAzureRMAutoScaleSetting_multipleProfiles === RUN TestAccAzureRMAutoScaleSetting_multipleProfiles --- PASS: TestAccAzureRMAutoScaleSetting_multipleProfiles (410.92s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 411.254s ``` * Linking to the timezone list

…s-account_firewall new resources: azurerm_data_lake_analytics_account & azurerm_data_lake_analytics_firewall_rule

* Add maintainers list to ReadMe just like Google provider. * Add team members GitHub alias. * Add alias of Hashicorp. * Add Paul's alias as well. * Make sure the format is correct. * Update README.md

This reverts commit 4dbb58d.

Revert "Add maintainers list to README (#1260)"

- Add support for the minimum TLS version used for clients connecting to an app service or slot - Add tests for app service and slot resources, data source, and import

…_schedule` resource

…e `azurerm_automation_schedule` resource

…roperties of the `azurerm_automation_schedule` resource

…n_schedule` in case of state change to remove

Data Lake Store File

…_listener (#1636)

…1623) * initial commit of datalake store encryption settings * Cleanup after merge and got disabling encryption to work * r/DataLakeStore: Support for Firewall/Encryption Tests pass: ``` $ acctests azurerm TestAccAzureRMDataLakeStore_ === RUN TestAccAzureRMDataLakeStore_basic --- PASS: TestAccAzureRMDataLakeStore_basic (147.99s) === RUN TestAccAzureRMDataLakeStore_tier --- PASS: TestAccAzureRMDataLakeStore_tier (140.91s) === RUN TestAccAzureRMDataLakeStore_encryptionDisabled --- PASS: TestAccAzureRMDataLakeStore_encryptionDisabled (126.77s) === RUN TestAccAzureRMDataLakeStore_firewallUpdate --- PASS: TestAccAzureRMDataLakeStore_firewallUpdate (253.79s) === RUN TestAccAzureRMDataLakeStore_withTags --- PASS: TestAccAzureRMDataLakeStore_withTags (161.95s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 831.835s ``` * d/DataLakeStore: support for Encryption/Firewall Rules Tests pass: ``` $ acctests azurerm TestAccDataSourceAzureRMDataLakeStore_ === RUN TestAccDataSourceAzureRMDataLakeStore_basic --- PASS: TestAccDataSourceAzureRMDataLakeStore_basic (150.71s) === RUN TestAccDataSourceAzureRMDataLakeStore_tier --- PASS: TestAccDataSourceAzureRMDataLakeStore_tier (143.18s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 294.220s ``` * Clarfiying the data lake docs

…te of the `azurerm_automation_schedule` resource

azurerm_servicebus_topic name now allows the ~ character

* Add 'azurerm_container_image' data source * Add 'azurerm_container_image' documentation * Fix data source implementation and test * Fix datasource docs * Add link to datasource docs * Fixes in data source * Remove unused Schema fields * Return error if resource is not found * Ensuring the data source exists, rather than the resource

* Added kubernetes_cluster advanced network creation * Changed network_profile from TypeSet to TypeList * Added kubernetes_cluster advanced network creation * Changed network_profile from TypeSet to TypeList * Updated ForceNew attributes on kubernetes_cluster.network_profile params * Added advanced network read functionality * Added tests for kubernetes_cluster.network_profile * Fixed indentations * Fixed function name in tests * Fixed property name in test * Fixed variable name * working on data source for kubernetes cluster * Fixed issue with datasource not working * Added network_policy and fixed read * Removed network_policy as unsupported * Added example of advanced networking * Added test for data_source * Made address space more sensible * Removing kubenet test. This is default when network_profile is not specified. We already test this. * Made network_plugin a mandatory field. Better to make this explicit. * Updated documentation to include network_profile * Fixing the build * Added ForceNew to network_profile * Made the docs a little clearer * Documenting a required field * Rephrasing the data sources * Making the `network_profile` block computed Tests pass: ``` $ acctests azurerm TestAccAzureRMKubernetesCluster_basic === RUN TestAccAzureRMKubernetesCluster_basic --- PASS: TestAccAzureRMKubernetesCluster_basic (1329.57s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 1329.613s ``` * Fixing the field we're asserting on * Conditionally expanding the network_profile block. The ip fields are now Computed too * Validation to ensure that a Subnet ID is assigned to the cluster when the network_profile blocks specified Example: ``` Error: Error running plan: 1 error(s) occurred: * azurerm_kubernetes_cluster.test: 1 error(s) occurred: * azurerm_kubernetes_cluster.test: If a `network_profile` block is specified, the Agent Pools must be attached to a Subnet ``` * Updating the documentation to mention the new behaviour * Adding independent tests for Kubenet and Azure networking profiles * Conditional validation of the `docker_bridge_cidr`, `dns_service_ip` and `service_cidr` fields. * Updating the docs * Fixing the tests

* adding support for node_resource_group * Fixing syntax error * Changing language in documentation

Storage Share Quota and Import Support

At present the documentation states that `ip_configuration`.`private_ip_address_allocation` can have have a value of `Dynamic` or `Standard`. `Standard` is incorrect, `Static` is correct.

…d there (#1654)

…group Import Support for Container Groups

azurerm_network_interface - ip_configuration - private_ip_address_allocation - types correction in documentation

…unning (#1657) Fixes #1254

Fixes #1645

Syncing from TF

* Adding an example of using a remote-exec provisioner on linux * Adding an example of using WinRM to run commands on a machine * Adding an example of a VM with Unmanaged Disks * Example of provisioning a Managed Disks VM from a Custom Image (ported from the VM Docs) * Example of provisioning a Basic VM with Managed Disks * Correctly documenting the delete methods * Adding an example of attaching data disks to a vm * Fixing the readme * Updating the VM Docs to be clearer * Fixing a bug in the attach disks demo * additional validation for the vm resource * Switching over to Standard_F2's for the examples

* Adding azure service fabric resource * Vendoring `2018-02-01` of the ServiceFabric SDK * Adding back in the client definition / changes needed to get it to compile * Renaming to Service Fabric Cluster * Registering the Microsoft.ServiceFabric client * Refactoring Service Fabric Clusters to use nested objects * Service Fabric Cluster; fixes, import support and acceptance tests Tests pass: ``` $ acctests azurerm TestAccAzureRMServiceFabricCluster_ === RUN TestAccAzureRMServiceFabricCluster_basic --- PASS: TestAccAzureRMServiceFabricCluster_basic (65.66s) === RUN TestAccAzureRMServiceFabricCluster_addOnFeatures --- PASS: TestAccAzureRMServiceFabricCluster_addOnFeatures (54.47s) === RUN TestAccAzureRMServiceFabricCluster_certificate --- PASS: TestAccAzureRMServiceFabricCluster_certificate (68.11s) === RUN TestAccAzureRMServiceFabricCluster_clientCertificateThumbprint --- PASS: TestAccAzureRMServiceFabricCluster_clientCertificateThumbprint (59.19s) === RUN TestAccAzureRMServiceFabricCluster_diagnosticsConfig --- PASS: TestAccAzureRMServiceFabricCluster_diagnosticsConfig (82.73s) === RUN TestAccAzureRMServiceFabricCluster_fabricSettings --- PASS: TestAccAzureRMServiceFabricCluster_fabricSettings (61.09s) === RUN TestAccAzureRMServiceFabricCluster_fabricSettingsRemove --- PASS: TestAccAzureRMServiceFabricCluster_fabricSettingsRemove (76.76s) === RUN TestAccAzureRMServiceFabricCluster_nodeTypeCustomPorts --- PASS: TestAccAzureRMServiceFabricCluster_nodeTypeCustomPorts (67.23s) === RUN TestAccAzureRMServiceFabricCluster_nodeTypesMultiple --- PASS: TestAccAzureRMServiceFabricCluster_nodeTypesMultiple (65.39s) === RUN TestAccAzureRMServiceFabricCluster_nodeTypesUpdate --- PASS: TestAccAzureRMServiceFabricCluster_nodeTypesUpdate (65.42s) === RUN TestAccAzureRMServiceFabricCluster_tags --- PASS: TestAccAzureRMServiceFabricCluster_tags (62.97s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 729.355s ``` * Documenting the Service Fabric Cluster resource * Documenting the `cluster_endpoint` field

* Adding retry functionality to role assignment * Fixing formatting issue * bumping the timeout to 5m

- formatting for data lake store - indentation for scheduler job - removing unnecessary backslashes for VMSS

Under 'Argument Reference', there is a typo on the redis_configuration snippet.

There's an extra underscore in the header/title, and it doesn't match the actual name of the resource.

docs/kubernetes_cluster: Fix inaccurate kube_config_raw description

@tombuildsstuff

* tokens invalid when az and terraform run on different timezones * tokens invalid when az and terraform run on different timezones More specifically, - adapt @tombuildsstuff's (thanks, that's better) stylistic requests.

* update VMSS docs to include ip_forwarding (fixes #1709) * Updating to include the default value

…#1717)

Update azurerm_lb_nat_rule with azurestasck PR review requests

…otocol

…to reduce depth of the `azurerm_automation_schedule` resource

* Remove validation logic for kubenet network plugin. * 🐛 (Azure Kubernete resource.) Update the validation logic of network_profile setting. The docker_bridge_cidr, dns_service_ip, service_cidr should be either all empty or all non-empty. Closes #1648 * 🐛 (data source of AKS.) Fix the compiling error of tests of data source for AKS. Updated the test confiuration code for data source of AKS to use new refactored functions. * 🐛 (AKS resource.) Format error. Fix the formatting error while running gofmt on AKS resource related files. * 📝 (AKS resource documentation.) Fix the error messsage for network profile setting. Change the description of error message to be more readable. * ♻️ (AKS resource.) Refactor the validation logic throuhg removing deep nested code. Use early return to remove deeply nested if-else block. * ♻️ (Test code of AKS resource.) Rename test case name. TestAzureRMKubernetesCluster_agentPoolName was a unit test, which should not have Acc in the naming. * ♻️ (AKS resource testing.) Refactor the test case configuration functions. Ignore the setting of empty string values. * 🐛 (AKS data source testing.) The wrong arguments passed in. Updated the arguments to align with new refactored function for configuration. * Fixing the outstanding PR comments

…view

…_updates azurerm_lb_probe: backport azurestack review comments

* Splitting `command` into `commands` * Refactoring to remove nil-pointer crashes * 🇬🇧 -> 🇺🇸 * Make fmt-ing

remove errwrap

…ack_updates azurerm_lb_nat_pool: backporting azurestack changes

* Add new Action Group resource of Azure Monitor * Add documentation of azurerm_action_group * Fix location description in documentation. * Add azurerm_action_group page to the ToC * Add acceptance tests for azurerm_action_group * Add import tests for azurerm_action_group * Add action group resource back to providers. * Modify the code according to the feedbacks * Upgrade to the latest Go SDK * Include import test as one step after normal tests * Rename from action_group to monitor_action_group * Fix minor issues according to the feedback * Change the code logic according to the feedback * Add more test scenarios from the feedback * Fix code according to the 16th iteration

… the `azurerm_automation_schedule` resource

* azurerm_lb_rule: backport of azure stack PR review comments * Fixing the import

…ng-props azurerm_automation_schedule - Add missing properties for the advanced schedule

New data source: azurerm_log_analytics_workspace

application gateway docs: url_path_map -> url_path_map_name

* Added max_pods to agent_pool_profiles in azurerm_kubernetes_cluster * Added ForceNew and Default to max_pods * Added max_pods to data_source_kubernetes_cluster agent_profile * Updated the docs to include max_pods * Fixed my terrible English. (I'm a flawed person) * Changed max_pods to computed field * Fixed max_pods field (added optional flag back in) * Conditionally passing max_pods to SDK * Removed default pod count from documentation * Added test coverage for max_pods * Fixed intentation * Trying to fix indentations

* Added kubernetes_cluster advanced network creation * Changed network_profile from TypeSet to TypeList * Added kubernetes_cluster advanced network creation * Changed network_profile from TypeSet to TypeList * Updated ForceNew attributes on kubernetes_cluster.network_profile params * Added advanced network read functionality * Added tests for kubernetes_cluster.network_profile * Fixed indentations * Fixed function name in tests * Fixed property name in test * Fixed variable name * working on data source for kubernetes cluster * Fixed issue with datasource not working * Added network_policy and fixed read * Removed network_policy as unsupported * Added example of advanced networking * Added test for data_source * Made address space more sensible * Removing kubenet test. This is default when network_profile is not specified. We already test this. * Made network_plugin a mandatory field. Better to make this explicit. * Updated documentation to include network_profile * Fixing the build * Added ForceNew to network_profile * Made the docs a little clearer * Documenting a required field * Rephrasing the data sources * Making the `network_profile` block computed Tests pass: ``` $ acctests azurerm TestAccAzureRMKubernetesCluster_basic === RUN TestAccAzureRMKubernetesCluster_basic --- PASS: TestAccAzureRMKubernetesCluster_basic (1329.57s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 1329.613s ``` * Fixing the field we're asserting on * Conditionally expanding the network_profile block. The ip fields are now Computed too * Validation to ensure that a Subnet ID is assigned to the cluster when the network_profile blocks specified Example: ``` Error: Error running plan: 1 error(s) occurred: * azurerm_kubernetes_cluster.test: 1 error(s) occurred: * azurerm_kubernetes_cluster.test: If a `network_profile` block is specified, the Agent Pools must be attached to a Subnet ``` * Updating the documentation to mention the new behaviour * Adding independent tests for Kubenet and Azure networking profiles * Conditional validation of the `docker_bridge_cidr`, `dns_service_ip` and `service_cidr` fields. * Updating the docs * Fixing the tests * Adding back in the changes from PR #1502 since they were lost in the merge * Renaming the methods to `addonProfiles` to match the sdk * fixing the quotes

…work_plugin is set to 'azure'. (#1763) * Added validation for pod_cidr * Changed wording of error message

Fixes #1762

sync with master fork #1

sync with master fork #1

Commits on Jul 4, 2018

Commits on Jul 5, 2018

Commits on Jul 6, 2018

Commits on Jul 7, 2018

Commits on Jul 9, 2018

Commits on Jul 10, 2018

Commits on Jul 11, 2018

Commits on Jul 12, 2018

Commits on Jul 13, 2018

Commits on Jul 15, 2018

Commits on Jul 16, 2018

Commits on Jul 17, 2018

Commits on Jul 18, 2018

Commits on Jul 19, 2018

Commits on Jul 20, 2018

Commits on Jul 21, 2018

Commits on Jul 22, 2018

Commits on Jul 23, 2018

Commits on Jul 24, 2018

Commits on Jul 25, 2018

Commits on Jul 26, 2018

Commits on Jul 27, 2018

Commits on Jul 28, 2018

Commits on Jul 29, 2018

Commits on Jul 30, 2018

Commits on Jul 31, 2018

Commits on Aug 1, 2018

Commits on Aug 2, 2018

Commits on Aug 3, 2018

Commits on Aug 6, 2018

Commits on Aug 8, 2018

Commits on Aug 9, 2018

Commits on Aug 10, 2018

Commits on Aug 11, 2018

Commits on Aug 12, 2018

Commits on Aug 13, 2018

Commits on Aug 14, 2018

Commits on Aug 15, 2018