Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract size ci task #133

Merged
merged 2 commits into from
Aug 17, 2023
Merged

contract size ci task #133

merged 2 commits into from
Aug 17, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Aug 11, 2023

  • new ci task that checks contract storage size. This allows us to track through each branch how much storage size the contracts take up
  • cache foundry build to speed up sub foundry build tasks, and group them together into a single worfklow

Screenshot 2023-08-11 at 4.35.47 PM.png

current contract size: 24.569

@oveddan
Copy link
Collaborator Author

oveddan commented Aug 11, 2023

@oveddan oveddan marked this pull request as draft August 11, 2023 18:22
@oveddan oveddan force-pushed the contract-size-ci branch 5 times, most recently from 4aac2f8 to 2182077 Compare August 11, 2023 23:15
@oveddan oveddan marked this pull request as ready for review August 11, 2023 23:37
@oveddan oveddan marked this pull request as draft August 11, 2023 23:49
Copy link
Collaborator Author

@oveddan oveddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason, tests dont seem to be caching in down the line files

* Caching foundry build for different test tasks
* Combined test and coverage into single workflow file
@oveddan oveddan merged commit ad73d1e into main Aug 17, 2023
6 checks passed
@kulkarohan kulkarohan mentioned this pull request Aug 29, 2023
iainnash pushed a commit that referenced this pull request Jan 11, 2024
* new ci task that checks contract storage size.  This allows us to track through each branch how much storage size the contracts take up
* cache foundry build to speed up sub foundry build tasks, and group them together into a single worfklow

![Screenshot 2023-08-11 at 4.35.47 PM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/ApIDvpfodCPhycVfvWex/01d32552-2b0e-468b-b8ed-2ab9e9503ab8/Screenshot%202023-08-11%20at%204.35.47%20PM.png)

current contract size: 24.569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants