Premint #149
Closed
Premint #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2023
Merged
Merged
Closed
Closed
Closed
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
oveddan
changed the base branch from
fix-creator-attribution-tests
to
contract-size-ci
This was referenced Aug 16, 2023
|
There is a merge conflict here. |
This was referenced Aug 17, 2023
…#144) * reduce optimizer runs to get contracts to build * Premint V2 - Creator Attribution (#128) * wip on move premint to creator attribution style * updated readme to reflect new contracts * Revert "undo changes to js sdk" This reverts commit 4deabf5. * better comments * Added methods to get status of creator attribution, and validate signatures, useful for the backend * better comments * fixed back fork test * slightly more comments
Created a release
Premint V2 - npm tag
…tracts Premint V2 - deployed contracts
Premint/Gasless
Merged
fix: factory tests
This was referenced Sep 6, 2023
Merged
refactor: remove legacy mint fee manager
feat: first minter
oveddan
commented
Sep 7, 2023
| @@ -732,6 +732,12 @@ contract ZoraCreator1155Impl is | |||
| error PremintAlreadyExecuted(); | |||
|
|
|||
| function delegateSetupNewToken(PremintConfig calldata premintConfig, bytes calldata signature) public nonReentrant returns (uint256 newTokenId) { | |||
| // if a token has already been created for a premint config with this uid: | |||
| if (delegatedTokenId[premintConfig.uid] != 0) { | |||
There was a problem hiding this comment.
nice way to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.