-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premint v1 and v2 sigs - 1155 now takes in encoded premint config and decodes it #284
Closed
oveddan
wants to merge
12
commits into
premint-fix-priced-minter-no-recipient
from
encoded-bytes-in-sig
Closed
Premint v1 and v2 sigs - 1155 now takes in encoded premint config and decodes it #284
oveddan
wants to merge
12
commits into
premint-fix-priced-minter-no-recipient
from
encoded-bytes-in-sig
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
Merged
Merged
oveddan
force-pushed
the
encoded-bytes-in-sig
branch
from
October 19, 2023 22:52
4f58b9e
to
19611b2
Compare
oveddan
changed the base branch from
fix-create-referral-sig
to
premint-fix-priced-minter-no-recipient
October 20, 2023 23:23
oveddan
force-pushed
the
encoded-bytes-in-sig
branch
from
October 20, 2023 23:23
19611b2
to
87a2b98
Compare
This was referenced Oct 20, 2023
oveddan
force-pushed
the
encoded-bytes-in-sig
branch
from
October 21, 2023 00:06
87a2b98
to
6d4233a
Compare
This was referenced Oct 24, 2023
This was referenced Oct 31, 2023
Merged
This was referenced Nov 9, 2023
Closed
Merged
Closed
This was referenced Nov 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the erc1155 contract's delegateSetupNewToken to take an encoded premint config, and premint config version, and send it to an external library to decode. This allows the contract to support multiple versions of the encoded premint without increasing code size