Premint - better mint arguments. Mint recipient is specified #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2023
Merged
This was referenced Oct 24, 2023
Merged
oveddan
force-pushed
the
premint_create_referral
branch
from
41211db
to
b900b66
Compare
oveddan
force-pushed
the
premint-better-mint-arguments
branch
from
1720bf2
to
dcf6b6a
Compare
oveddan
force-pushed
the
premint_create_referral
branch
from
b900b66
to
4a78775
Compare
oveddan
force-pushed
the
premint-better-mint-arguments
branch
from
dcf6b6a
to
0012402
Compare
|
todo:
|
This was referenced Oct 25, 2023
oveddan
force-pushed
the
premint_create_referral
branch
from
4a78775
to
4bb2f92
Compare
oveddan
force-pushed
the
premint-better-mint-arguments
branch
from
0012402
to
1da50ec
Compare
iainnash
reviewed
Oct 26, 2023
| @@ -43,6 +43,12 @@ interface ILegacyZoraCreator1155PremintExecutor { | |||
| ) external payable returns (uint256 newTokenId); | |||
| } | |||
|
|
|||
| struct MintArguments { | |||
There was a problem hiding this comment.
Natspec here for where these get passed?
MintRecipient and MintComment go to fixedpriceminter, while mintReferral is used in the 1155impl contract.
iainnash
reviewed
Oct 26, 2023
| @@ -151,7 +156,7 @@ contract ZoraCreator1155PremintExecutorImpl is | |||
| uint256 quantityToMint, | |||
| address fixedPriceMinter, | |||
| uint32 uid, | |||
| bytes memory mintArguments | |||
| MintArguments memory mintArguments | |||
There was a problem hiding this comment.
can this be calldata here?
iainnash
approved these changes
Oct 26, 2023
This was referenced Oct 31, 2023
This was referenced Nov 9, 2023
Closed
Merged
Closed
This was referenced Nov 17, 2023
Merged
oveddan
added a commit
that referenced
this pull request
Apr 8, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## Does this change the ABI/API? - [ ] This changes the ABI/API <!-- If so, please describe how and what potential impact this may have --> ## What tests did you add/modify to account for these changes <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New module / feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] i added a changeset to account for this change ## Reviewer Checklist: - [ ] My review includes a symposis of the changes and potential issues - [ ] The code style is enforced - [ ] There are no risky / concerning changes / additions to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mint arguments are a struct, and now mint recipient can be specified