-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated prettier formatting in all packages, and formatted code #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainnash
previously approved these changes
Nov 14, 2023
IsabellaSmallcombe
previously approved these changes
Nov 14, 2023
oveddan
dismissed stale reviews from IsabellaSmallcombe and iainnash
November 15, 2023 00:45
The base branch was changed.
oveddan
force-pushed
the
formatted-prettier
branch
from
November 15, 2023 00:45
3b665b7
to
164e5a1
Compare
This was referenced Nov 15, 2023
Merged
Merged
Closed
oveddan
force-pushed
the
formatted-prettier
branch
from
November 15, 2023 01:10
164e5a1
to
140e699
Compare
This was referenced Nov 17, 2023
Merged
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
fixed prettier checks in all projects. formatted incorrectly formatted code
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
fixed prettier checks in all projects. formatted incorrectly formatted code
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
fixed prettier checks in all projects. formatted incorrectly formatted code
oveddan
added a commit
that referenced
this pull request
May 10, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description Make sure to save/load erc20 minter from the deployment config, so that when we run `copy-deployed-contracts` its not removed ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## Does this change the ABI/API? - [ ] This changes the ABI/API <!-- If so, please describe how and what potential impact this may have --> ## What tests did you add/modify to account for these changes <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New module / feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] i added a changeset to account for this change ## Reviewer Checklist: - [ ] My review includes a symposis of the changes and potential issues - [ ] The code style is enforced - [ ] There are no risky / concerning changes / additions to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed prettier checks in all projects.
formatted incorrectly formatted code