Premint - can execute premint on legacy version of contracts #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2023
Merged
Merged
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
ccd7297
to
d1cdc3d
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
fa8a0fb
to
4d8f817
Compare
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
d1cdc3d
to
28dafdd
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
4d8f817
to
b13aecc
Compare
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
28dafdd
to
bf025b1
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
b13aecc
to
987a31f
Compare
This was referenced Oct 30, 2023
Merged
oveddan
changed the base branch from
rename-royalty-recipient-to-funds-recipient
to
premint_create_referral
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
987a31f
to
13bec21
Compare
This was referenced Oct 31, 2023
oveddan
force-pushed
the
premint_create_referral
branch
from
1aeeabd
to
6e178ec
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
94f103c
to
fab7fcc
Compare
oveddan
force-pushed
the
premint_create_referral
branch
from
6e178ec
to
a1da19c
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
fab7fcc
to
58b0ceb
Compare
oveddan
force-pushed
the
premint_create_referral
branch
from
a1da19c
to
9d8548b
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
58b0ceb
to
cbcd00e
Compare
This was referenced Nov 15, 2023
Closed
oveddan
force-pushed
the
premint_create_referral
branch
from
9d8548b
to
9d2c585
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
cbcd00e
to
3a22cd0
Compare
oveddan
force-pushed
the
premint_create_referral
branch
from
9d2c585
to
7bf9aac
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
3a22cd0
to
e7fcba1
Compare
oveddan
force-pushed
the
premint_create_referral
branch
from
7bf9aac
to
46afabc
Compare
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
e7fcba1
to
4e5a9e9
Compare
Merge activity
|
oveddan
dismissed stale reviews from IsabellaSmallcombe, kulkarohan, and iainnash
The base branch was changed.
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
4e5a9e9
to
83ba3eb
Compare
This was referenced Nov 17, 2023
Merged
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments. This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments. This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments. This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an 1155 contract was created with the old function delegateSetupNewToken() - the upgraded premint executor could not execute that function cause it expected the newer signature with different arguments. This PR will have the premint executor check if the contract supports the new function, and if it doesn't, then it calls the old function