Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Lists and Keys page #7

Merged
merged 15 commits into from
Feb 9, 2019
Merged

Translation Lists and Keys page #7

merged 15 commits into from
Feb 9, 2019

Conversation

WendellAdriel
Copy link
Member

#1

@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few changes to make it.

cc: @WendellAdriel @fjoshuajr

koka0012
koka0012 reviewed Feb 8, 2019
View reviewed changes
Copy link
Contributor

@koka0012 koka0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should take a look at this suggestions.

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
fjoshuajr
fjoshuajr requested changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments regarding some changes.

glaucia86
glaucia86 requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to make it

cc: @WendellAdriel

@WendellAdriel
Copy link
Member Author

Hey everyone, I made some changes, if you can please review it again!!! 😉

fjoshuajr
fjoshuajr requested changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there @WendellAdriel

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
fjoshuajr
fjoshuajr previously approved these changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me! ✨

glaucia86
glaucia86 requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @WendellAdriel eu coloquei como 'request changes' devido ao link dos títulos. Acho que tem que ser também traduzidos. Pois na hora que o usuário for clicar no nos títulos, não conseguirá até o local indicado.

O que você também @fjoshuajr ?

@fjoshuajr
Copy link
Collaborator

fjoshuajr commented Feb 8, 2019 •
edited
Loading

@glaucia86 Os links que aparecem junto aos títulos não podem ser traduzidos.

EDIT: Cometi um erro, os links podem ser traduzidos sim.

@cezaraugusto cezaraugusto added needs resolution Something not defined that needs maintainers input and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
@fjoshuajr
Copy link
Collaborator

Resolved the comments. Solid translation here.
I'll go ahead and merge this.

cc: @glaucia86

@fjoshuajr fjoshuajr merged commit 69af38c into reactjs:master Feb 9, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs resolution Something not defined that needs maintainers input labels Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
@fjoshuajr fjoshuajr changed the title Lists and Keys page translation Translation Lists and Keys page Feb 10, 2019
fjoshuajr pushed a commit that referenced this pull request Feb 10, 2019
@tibuurcio @fjoshuajr
Fix some link translations in initial PR's (#58)
74fca93 
* Fix links in lists-and-keys page #7

* Fix links in faq-ajax page #9

* Fix links in faq-build page #12

* Fix links in web-components page #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjoshuajr fjoshuajr fjoshuajr left review comments

@koka0012 koka0012 koka0012 left review comments

@lucasdeassis lucasdeassis lucasdeassis left review comments

@cezaraugusto cezaraugusto cezaraugusto left review comments

@glaucia86 glaucia86 glaucia86 requested changes

@halian-vilela halian-vilela halian-vilela left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WendellAdriel @fjoshuajr @halian-vilela @glaucia86 @cezaraugusto @lucasdeassis @koka0012