Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of the "AJAX and APIs" page #9

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Translation of the "AJAX and APIs" page #9

merged 3 commits into from
Feb 8, 2019

Conversation

lazaroalvarenga
Copy link
Contributor

#1

@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
glaucia86
glaucia86 approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86
Copy link
Member

cc: @cezaraugusto @WendellAdriel can see this PR?! For me looks good to me! :)

@lazaroalvarenga
Copy link
Contributor Author

@glaucia86 I updated with changes to standardize the translation of the word call. It's fine?

@WendellAdriel
Copy link
Member

@glaucia86 @cezaraugusto @lazaroalvarenga
I really think that we shouldn't translate code blocks, I put that as the first item on #4

cezaraugusto
cezaraugusto requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this @lazaroalvarenga. please see comments

content/docs/faq-ajax.md Outdated Show resolved Hide resolved
content/docs/faq-ajax.md Outdated Show resolved Hide resolved
content/docs/faq-ajax.md Outdated Show resolved Hide resolved
@lazaroalvarenga
Copy link
Contributor Author

@glaucia86 @cezaraugusto @lazaroalvarenga
I really think that we shouldn't translate code blocks, I put that as the first item on #4

ok! Sorry for that. I'll unmake the code blocks translation.

@glaucia86
Copy link
Member

@lazaroalvarenga todos os acertos que vc for fazendo de acordo com review marque como 'Resolve Conversation' ;)

@glaucia86
Copy link
Member

cc: @cezaraugusto @lazaroalvarenga already did the changes here. I think that we can approve his request. What do u think?

cezaraugusto
cezaraugusto approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazaroalvarenga way to go, thanks!

@cezaraugusto cezaraugusto merged commit 3eb79dd into reactjs:master Feb 8, 2019
@tesseralis tesseralis mentioned this pull request Feb 8, 2019
Closed
90 tasks
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
fjoshuajr pushed a commit that referenced this pull request Feb 10, 2019
@tibuurcio @fjoshuajr
Fix some link translations in initial PR's (#58)
74fca93 
* Fix links in lists-and-keys page #7

* Fix links in faq-ajax page #9

* Fix links in faq-build page #12

* Fix links in web-components page #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lazaroalvarenga @glaucia86 @WendellAdriel @cezaraugusto