Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-ticket: Replace imports from sage.*.all for namespace packages #34201

Closed
mkoeppe opened this issue Jul 20, 2022 · 17 comments · Fixed by #35110
Closed

Meta-ticket: Replace imports from sage.*.all for namespace packages #34201

mkoeppe opened this issue Jul 20, 2022 · 17 comments · Fixed by #35110

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 20, 2022

This is work toward modularization, see https://doc.sagemath.org/html/en/developer/packaging_sage_library.html#module-level-runtime-dependencies and #29705.

Tickets:

The branch here on the ticket merges the above tickets and makes violations an error again.

Tools:

Other tools (not used):

CC: @GMS103 @alexchandler100

Component: refactoring

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34201

@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 20, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

16efed0src/sage/misc/sage_eval.py: Fix markup
63a433fMerge #34956
965dfc6sage -fiximports src/sage/stats
21b94basrc/sage/libs/giac/auto-methods.pxi: Back out whitespace changes in this autogenerated file
a21254aMerge #34957
7cc4cefsrc/.relint.yml: Allow .all imports in some modules
39b7ca4src/sage/env.py: Hide a legitimate .all import from relint
a8a3d6esrc/sage/tests/startup.py: Hide a legitimate .all import from relint
22fa718Merge #34956
4ab5070src/.relint.yml: Allow .all imports in some more modules

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Commit: 4ab5070

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

vbraun pushed a commit that referenced this issue Feb 12, 2023
The new command `sage --fiximports` replaces imports from
`sage.PAC.KAGE.all` by more specific imports when `sage.PAC.KAGE` is an
implicit namespace package.

Part of Meta-ticket #34201

URL: https://trac.sagemath.org/34945
Reported by: mkoeppe
Ticket author(s): Alex Chandler, Matthias Koeppe
Reviewer(s): Matthias Koeppe, Alex Chandler
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Removed branch from ticket description; replaced by PR #35110

@vbraun vbraun closed this as completed in 80511e1 Mar 26, 2023
vbraun pushed a commit that referenced this issue Jul 1, 2023
…attern

    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

Per #35095, parts of `sage.geometry` will be shipped in sagemath-
modules, sagemath-polyhedra, and sagemath-symbolics. Hence we replace
imports from `sage.geometry...all`.

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
- Continuation of #34201
- Cherry-picked from #35095
- Part of #29705
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35798
Reported by: Matthias Köppe
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant