improve tool/test.dart #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isTravis would only return true on Travis and pub no longer uses Travis.
To run a command in another directory from CWD
This is a merge to keep that branch in history.
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Write the archive to disk before un-taring it. Co-authored-by: Sigurd Meldgaard <[email protected]>
…art-lang#2968)" (dart-lang#3006)" (dart-lang#3008) This reverts commit d2ad13d.
Because it's only accessed inside this class.
* Change terminology for precompilation to building Co-authored-by: Michael Thomsen <[email protected]>
* Add test to ignore dot-files * Add test to check dot-files are not included in while publishing
* fail CI on info level issues; fix directives sorting * some whitespace changes
* Validate and normalize hosted url. We normalize the URL for a _hosted pub server_ to have no slash if the server is just a bare domain like `https://example.com`, but if the URL contains a path like `https://example.com/my-folder` then we always normalize to `https://example.com/my-folder/`. The reason for normalizing the URL is to improve consistency in `pubspec.lock` and make it easier to implement authentication without risks of being tricked by incorrect prefixes. Additionally, be normalizing to no slash for empty paths, and paths always ending in a slash when path is non-empty, we gain the benefit that relative URLs can always be constructed correctly using `hostedUrl.resolve('api/packages/$package')`. This additionally forbids a few edge cases such as: * querystring in the hosted URL (`https://server.com/?query`), * fragment in the hosted URL (`https://server.com/#hash`), * user-info in the hosted URL (`https://user:[email protected]`). These may have worked with previous versions of the `pub` client, but most likely the _querystring_ or _fragment_ would cause URLs to be garbled. Any user-info would likely have been ignored, this was not tested, any usage of these options is considered unlikely. Previously, `dart pub publish` would ignore the path in the hosted URL and always upload to `/api/packages/new`. This commit fixes this issue.
* Detect Flutter SDK location relative to Dart SDK If the Dart SDK is present inside the Flutter SDK in sub-folder `bin/cache/dart-sdk/`, then we no-longer require the environment variable `FLUTTER_ROOT` to be specified. Instead we simply derive the location of the Flutter SDK from the location of the Dart SDK. We still allow the environment variable `FLUTTER_ROOT` to override the otherwise automatically detected Flutter SDK location. * Check that "version" file is present before deciding that we have found a Flutter SDK
* Add executables to allErrors * Improve tests of executables
Always precompile apps before running them, even if they aren't immutable
Use `dart run instead` ↓ Use `dart run` instead
Use stdout.hasTerminal instead of stdioType(stdout)
sigurdm
force-pushed
the
improve_test_script
branch
from
7ff0afb
to
bdae5ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart runto invoke the test runner