Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Batch of editorial improvements #2896

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Editorial: Batch of editorial improvements #2896

merged 10 commits into from
Jun 14, 2024

Commits on Jun 13, 2024

  1. Editorial: Formalize structured headers of parsing operations 

    This adds correct structured headers to all parsing operations, complete
with definitions of Records used. The Records use ~empty~ instead of
*undefined* to indicate absence of a particular element of the ISO string,
which requires some changes in the calling operations to accommodate this.

When returning ISO Date-Time Parse Records everywhere,
ParseTemporalDateString becomes redundant.
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c4b66fd View commit details
    Browse the repository at this point in the history

  2. Editorial: Fix outdated AO description

    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b6bf8cc View commit details
    Browse the repository at this point in the history

  3. Editorial: Allow returning UNSET from DifferenceZonedDateTimeWithRoun… 

    …ding

When calling DifferenceZonedDateTimeWithRounding with smallestUnit and
largestUnit not the same unit, it's possible to hit the NudgeToZonedTime
path, where [[Total]] is UNSET. This should be reflected in the structured
header's return type.

Closes: #2879
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c66b3b0 View commit details
    Browse the repository at this point in the history

  4. Editorial: Pass year/month/day to DifferencePlainDateTimeWithRounding 

    Since #2758 we no longer need to keep this PlainDate object for passing to
calendar methods. This allows removing an unnecessary object creation that
implementations would be able to optimize out anyway because it's
unobservable.

Closes: #2875
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d8a07e7 View commit details
    Browse the repository at this point in the history

  5. Editorial: Change Duration.p.round smallestUnit check to assertion 

    If the smallestUnit is a calendar unit, the largestUnit is also a calendar
unit, so the check was redundant. However, keep it as an explicit
assertion, for clarity to the reader.

Closes: #2874
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7b4cb17 View commit details
    Browse the repository at this point in the history

  6. Editorial: Fix argument order to Add24HourDaysToNormalizedTimeDuration 

    In 3 places the arguments were reversed.

Closes: #2872
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3f45022 View commit details
    Browse the repository at this point in the history

  7. Editorial: Fix returned value of UnbalanceDateDurationRelative 

    This operation returns a number of days, not a Date Duration Record.

Closes: #2871
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5207927 View commit details
    Browse the repository at this point in the history

  8. Docs: Add missing time of day

    @gibson042 @ptomato
    gibson042 authored and ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    32158cf View commit details
    Browse the repository at this point in the history

  9. Docs: Use consistent language when referencing the POSIX epoch

    @gibson042 @ptomato
    gibson042 authored and ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    01d4d8a View commit details
    Browse the repository at this point in the history

  10. Editorial: Fix character entity 

    Closes: #2887
    @ptomato
    ptomato committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    8e3ce61 View commit details
    Browse the repository at this point in the history