fix(ndt_scan_matcher): delete diagnostic thread and its dependencies #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arefoundation#4286) Fixed as pointed out by clang-tidy Signed-off-by: Shintaro SAKODA <[email protected]>
…tate (autowarefoundation#4853) fix skip_publishing_num status Co-authored-by: kminoda <[email protected]>
…foundation#4815) * feat(ndt_scan_matcher): add diag lidar_topic_delay_time_sec Signed-off-by: yamato-ando <Yamato ANDO> * fix param Signed-off-by: yamato-ando <Yamato ANDO> * fix stoi to stod Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * update readme Signed-off-by: yamato-ando <Yamato ANDO> --------- Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…l_transformation_likelihood: For deciding does NDT have problems while matching scans (autowarefoundation#4854) * exe time added to diagnostics and switch state by voxel likelihood * style(pre-commit): autofix * type casting corrected * ndt score condition parameterized * remove exe_time from diagnostic * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…n#5045) * Added logging initial pose Signed-off-by: Shintaro SAKODA <[email protected]> * Added #include <string> to util_func.hpp Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
* Removed all default values from the c++ source code. Modified the declaration of ndt_base_frame_ so that it works if it is not declared in the param.yaml file Signed-off-by: TaikiYamada4 <[email protected]> * Added ndt_scan_matcher.schema.json file Signed-off-by: TaikiYamada4 <[email protected]> * Removed redundant static_cast<int> on declare_paramter Signed-off-by: TaikiYamada4 <[email protected]> * style(pre-commit): autofix * Added neighborhood_search_method parameter to ndt_scan_matcher.param.yaml. This is same to the one in autoware_launch Signed-off-by: TaikiYamada4 <[email protected]> * Deleted schema.json for now Signed-off-by: TaikiYamada4 <[email protected]> * Delete ndt_scan_matcher.schema.json for now Signed-off-by: TaikiYamada4 <[email protected]> * Deleted parameter neighborhood_search_method from ndt_scan_matcher.param.yaml, which was inserted by mistake. Signed-off-by: TaikiYamada4 <[email protected]> * Added ndt_base_frame to ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Updated README by adding ndt_base_frame in the parameters list Signed-off-by: TaikiYamada4 <[email protected]>
…untime_monitor (autowarefoundation#4916) * adding exe time to diagnostics * Update localization/ndt_scan_matcher/config/ndt_scan_matcher.param.yaml Co-authored-by: kminoda <[email protected]> * order of the parameters in constructor corrected * spell check * Update localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp Co-authored-by: kminoda <[email protected]> * Update localization/ndt_scan_matcher/config/ndt_scan_matcher.param.yaml Co-authored-by: Motz <[email protected]> * Update localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp Co-authored-by: Motz <[email protected]> * rebase branch to main * the actual execution time added to diagnostics message * execution_time parameter corrected * integration with header file * style(pre-commit): autofix * parameter naming --------- Co-authored-by: kminoda <[email protected]> Co-authored-by: Motz <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…atcher_core.cpp (autowarefoundation#5155) * Removed default paramters in the constructor in ndt_scan_matcher_core.cpp Extracted paramter map_frame to ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> * Updated README.md to match ndt_scan_matcher.param.yaml Fixed minor grammar mistakes. Signed-off-by: TaikiYamada4 <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * Fixed minor grammar mistakes Signed-off-by: TaikiYamada4 <[email protected]> * Removed unnecessary value initialization for parameters that should be defined in ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…um` to 200 (autowarefoundation#5220) Changed initial_estimate_particles_num to 200 Signed-off-by: Shintaro Sakoda <[email protected]>
…foundation#5319) Added initial_to_result_relative_pose Signed-off-by: Shintaro Sakoda <[email protected]>
…utowarefoundation#5351) * Renamed align_using_monte_carlo to align_pose Signed-off-by: Shintaro SAKODA <[email protected]> * Removed the waste arg ndt_ptr Signed-off-by: Shintaro SAKODA <[email protected]> * Fixed log messages Signed-off-by: Shintaro SAKODA <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro SAKODA <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…on#5354) Fixed validate_num_iteration Signed-off-by: Shintaro SAKODA <[email protected]>
…5532) Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
shmpwk
requested review from
KYabuuchi,
kminoda and
YamatoAndo
as code owners
github-actions
bot
added
documentation
shmpwk
changed the title
|
We will take in autowarefoundation#5532 in v0.44.0.0 because there are too many dependencies which may cause other bugs for minor version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick autowarefoundation#5532
This cherry-pick needs a lot of dependent commit.
I cherry-picked one by one until the conflicts are resolved.
We need to cherry-pick autowarefoundation#5532 because we have diag using stod
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.