feat: disable namespace `lane_start_bound` #314

h-ohta · 2022-05-18T09:39:49Z

PR Type

Improvement

Description

disable lane_start_bound namespace

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Code follows coding guidelines
Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
Code follows coding guidelines
(Optional) Unit tests have been written for new behavior
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets
Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

yukkysaito · 2022-05-18T11:59:55Z

LGTM
draft解除されたらapproveします

* chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]>

* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> * add calibration status launcher to external_api_adaptor Signed-off-by: TakumiKozaka-T4 <[email protected]> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <[email protected]> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <[email protected]> * pull the latest tier4/universe Signed-off-by: TakumiKozaka-T4 <[email protected]> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <[email protected]> * fixed unnecessary change. Signed-off-by: TakumiKozaka-T4 <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]>

* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <[email protected]> * fix(stop_line): add ros_parameter (#347) * fix(stop_line): add ros_parameter Signed-off-by: k-obitsu <[email protected]> * fix(perception_launch): fix vehicle param in perception launch Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: k-obitsu <[email protected]>

* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <[email protected]> * fix(stop_line): add ros_parameter (#347) * fix(stop_line): add ros_parameter Signed-off-by: k-obitsu <[email protected]> * add localization score relay node Signed-off-by: TakumiKozaka-T4 <[email protected]> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: k-obitsu <[email protected]>

feat: disable lane_bound

c521675

taikitanaka3 requested a review from yukkysaito May 18, 2022 10:14

fix: lane_start_bound

74e3ee2

h-ohta changed the title ~~feat: disable lane bound~~ feat: disable namespace lane_start_bound May 19, 2022

h-ohta marked this pull request as ready for review May 19, 2022 11:17

h-ohta mentioned this pull request May 20, 2022

feat(map_loader): visualize center line by points autowarefoundation/autoware.universe#931

Merged

4 tasks

feat: add center_line_arrows to disable

0caa771

taikitanaka3 approved these changes May 20, 2022

View reviewed changes

kenji-miyake changed the base branch from tier4/universe to awf-sync May 20, 2022 06:28

h-ohta merged commit 66b4732 into awf-sync May 20, 2022

h-ohta deleted the feat/disable_lane_bound branch May 20, 2022 06:37

This was referenced May 21, 2022

chore: sync awf-latest #322

Merged

chore: sync awf-latest #325

Merged

tier4-autoware-public-bot bot mentioned this pull request May 26, 2022

chore: sync awf-latest #331

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: disable namespace `lane_start_bound` #314

feat: disable namespace `lane_start_bound` #314

h-ohta commented May 18, 2022 •

edited

Loading

yukkysaito commented May 18, 2022

feat: disable namespace lane_start_bound #314

feat: disable namespace lane_start_bound #314

Conversation

h-ohta commented May 18, 2022 • edited Loading

PR Type

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

yukkysaito commented May 18, 2022

feat: disable namespace `lane_start_bound` #314

feat: disable namespace `lane_start_bound` #314

h-ohta commented May 18, 2022 •

edited

Loading