test(modules): ensure relative paths work correctly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
reviewed
May 5, 2017
test/e2e/support/modules/plus.js
Outdated
| return a + b | ||
| } | ||
| export default plus |
There was a problem hiding this comment.
We should remove this default import, since we're exporting the function above
appsforartists
force-pushed
the
feat/esmodule
branch
from
a5855f8
to
591c0b1
Compare
|
Removed the default exports. |
- Remove polling usage for file change watching with chokidar on Mac OS Closes karma-runner#2669
- Remove active testing of node versions below 4
- renamed batchInterval to autoWatchBatchDelay to aid in greppability. - Modified debouncing tests to wait on promises. - Added documentation explaining how list.removeFile is different from list.addFile and list.changeFile. Closes karma-runner#2331
chore(travis): only update npm in Node<5 and only to npm@3
…-autowatchbatchdelay feat(watcher): Debounce autoWatchBatchDelay
fix(file-list): Stop polluting global environment with core-js
- Update dependencies as part of process to drop support for versions of Node.js below 4 Closes karma-runner#1812 Closes karma-runner#2688
feat(ci): disable testing of node versions below 4
feat(config): remove polling usage
chore: update dependencies
…read-file-error fix(preprocessor): retry if fs.readFile fails
We only validate comment message when `VALIDATE_COMMIT_MSG` is set, and don't run Travis twice anymore. Fixes karma-runner#2766
We pass the path relative to the .git directory, which is what `validate-commit-msg` is expecting. A few extra items will also be traced in case anything breaks in the future. Fixes karma-runner#2753
Fix Travis commit message checks
Update cucumber tests to address the following incompatibilities: 1. usage of `defineSupportCode` instead of relying on invocation with appropriate `this` the modules `require`d by cucumber-js 2. replace regex literals with cucumber expression strings, as the former cause issues when non-existent capture groups are parsed 3. migrate from old-style tag selection syntax Fixes karma-runner#2764
The contributors file contains two entries for me, at: https://github.com/karma-runner/karma/blob/69978ee83e42c88b9cb048b2cb7a07d6e5c20e5b/package.json#L46 and: https://github.com/karma-runner/karma/blob/69978ee83e42c88b9cb048b2cb7a07d6e5c20e5b/package.json#L54 This is because in Unicode `ę` can be written in two ways: 1. As a separate letter: `ę` (`"ę".length === 1`) 2. As "e" plus "Combining Ogonek" ("ogonek" means "a little tail" in Polish; `"ę".length === 2`, try it yourself), see http://www.fileformat.info/info/unicode/char/0328/index.htm This `.mailmap` entry will collapse those two entries.
…upon config/cli-options.
fix(config): Call debug log methods after setting the loglevel based upon config/cli-options
appsforartists
force-pushed
the
feat/esmodule
branch
6 times, most recently
from
86d5def
to
f8806ac
Compare
Document port collision scenario
…upon config/cli-options.
Now that the minimum version of Node that we support is 4, we can stop shimming things everyhwere on the server side code.
Better string representation of errors
appsforartists
force-pushed
the
feat/esmodule
branch
3 times, most recently
from
71efdc4
to
5ca62bb
Compare
- Add support for ES modules via `esModule` property in file config object
`esModule: true` is now `type: 'module'`. Test updated to reflect that.
appsforartists
force-pushed
the
feat/esmodule
branch
from
5ca62bb
to
fa24808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.