First pass at a Contact Form block #27688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The information text was “renews annually”, which is only true for yearly plan. This patch adds two other information texts: “renews biennially” and “renews monthly”. Fix #26847.
Syncing stuff from Automattic/jetpack#10256
georgestephanis
added
DO NOT MERGE
[Goal] Gutenberg
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
Gutenberg: use v1.2 endpoint to create auto-draft
* Reader: make featured posts keyboard-accessible * Match styling of existing block * Prevent multiple requests for the same posts on re-mount * Remove magic number * Use padding shorthand
Migrates Chart styles to Webpack's build pipeline.
This PR refactors the Chart component to be a PureComponent. This prevents unnecessary re-renders when mousing over the chart bars (and triggering a re-render of each `<Bar />` in addition to the new `<Tooltip />`). - Chart: Clean up xAxis - Chart: Clean up barContainer, convert to PureComp - Chart: Modularize bar tooltip into separate comp - Chart: Remove Chart.componentWillReceiveProps - Chart: Convert Label into PureComponent - Chart: Modularize LegendItem, convert to PureComp
Changes the ChartLegend component into a non-pure Component. This is necessary due to how we determine `legendItems` in the render function.
5 tasks
* Swap `dispatchRequest()` for `dispatchRequestEx()` in the users selector. * Begin updating tests to remove spies. * Update tests * Remove inaccurate code comments * Update tests * Oops, the `receiveSuccess` function was not returning anything. * Users State: add USERS_RECEIVE action to receive a list of users * Users State: migrate reducer test to Jest expectations * Users State: use USERS_RECEIVE to store page of user results, fix issuing request for next page Improve the `receiveSuccess` handler to first store the just-received page of user results using the `USERS_RECEIVE` action, and then optionally issue a request for the next page. * Users State: update JSDoc comments and make the data-layer handler file ESLint-clean * Users State: update the data layer tests for USERS_REQUEST
* Framework: Run eslint --fix on client/
* Some manual cleanup
- Remove unused debug
- Add {Ex,In}ternal import headers
- Remove unused _.includes
- Sort imports
- Split variable declarations
- Use const over let for single assignment variables
This adds a new webpack plugin that detects and reports on packages that are bundled more than once, even across major revisions. This can help us catch cases where we're shipping more than one version of the same package, bloating our overall bundle size.
This removes the pages of CSS extract output from the build report in dev mode.
fix tracking handler on 'view all' button.
…racks Activity log: fix view all tracking
* Import in Signup: Pass the provided url to the import section * Feed URL from context to the section component * Kick off an import when wix service is in the path * Pull supported query arguments into state & discard the rest * Provide the service at the conclusion of the flow * Fix the error reducer handler (it needs to be a fn) * Provide all siteDetails from API as a dependency * Connect `startImport` to flux dispatcher * Progress to site verification / preview when query arg is present * Add `fetchIsSiteImportable` call back in. * bail if there's already an import * only auto start the import once
…ipsis Activity Log: Fix Double Ellipsis inside aggregated activities
* Import: Pass engine and url to new user endpoint * Change import_from_url to import_from_site
…#27659) * Gutenberg: Fetch real time related posts * Gutenberg: Use realtime related posts in block preview * Gutenberg: No request duplication, refresh after save * Use dates provided from the API * Use human readable dates in example posts * Fix image schema in example posts * Handle related posts request failures
* Fix StickyPanel placement in certain scenarios. StickyPanel now determines its desired position every time it scrolls, so that changes in size in other components above it are reflected. In addition, it also takes the Master Bar height into account now, leading to a smoother transition between states. * Add IntersectionObserver-based StickyPanel implementation. This implementation requires much less layout work. It should only be needed on startup and when transitioning between intersection states, rather than constantly during scroll. * Use module functions instead of inheritance for StickyPanel * Make some tweaks to StickyPanel after code review * Fix scroll-based StickyPanel implementation * Add some basic dimensioning and logic tests to StickyPanel * Reimplement StickyPanel tests without sinon * Fix incorrect StickyPanel test.
We only allow new domain purchases in this flow. Users shouldn't see the `Already own a domain?` option.
The existing mapping of allowed types to enabled filters was no longer accurate after the package update. This fixes the mapping and refactors the code to handle the cases when multiple allowed types can be returned.
Syncing stuff from Automattic/jetpack#10256
…r xplatform with calypso
…omattic/wp-calypso into try/gutenblocks/contact-form
|
Did you need help with rebasing? There are unrelated commits here. It might be easier to start fresh or squash down commits before trying a rebase with master to tidy this up. |
|
Closing in favor of #27996 as I really mangled a rebase. 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing stuff from Automattic/jetpack#10256
Changes proposed in this Pull Request
Testing instructions