feat(statistics tools): support statistics tools for experiments launched by omnisafe #157

muchvo · 2023-03-17T16:59:47Z

Description

Support statistics tools for experiments launched by omnisafe.
Once finished experiments are launched by the experiment grid, users can utilize statistics tools to compare the effect of any parameter. Enjoy these tools which boost your efficiency of running experiments!
Here is an example:

Then you can get the graphs you want in seconds.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds core functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (update in the documentation)

Implemented Tasks

Subtask 1
Subtask 2
Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

I have read the CONTRIBUTION guide. (required)
My change requires a change to the documentation.
I have updated the tests accordingly. (required for a bug fix or a new feature)
I have updated the documentation accordingly.
I have reformatted the code using make format. (required)
I have checked the code using make lint. (required)
I have ensured make test pass. (required)

…ent#131)

Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: ruiyang sun <[email protected]>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]>

Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: borong <[email protected]> Co-authored-by: friedmainfunction <[email protected]>

…nment#147) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…thms (PKU-Alignment#148) Co-authored-by: borong <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: zmsn-2077 <[email protected]>

Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: friedmainfunction <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: Ruiyang Sun <[email protected]> Co-authored-by: Jiayi Zhou <[email protected]> Co-authored-by: 1Asan <[email protected]> fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122) fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignment#131) fix typo. (PKU-Alignment#134) fix(ppo): fix entropy loss (PKU-Alignment#135) fix bugs (PKU-Alignment#136) fix: support new config for exp_grid (PKU-Alignment#142) fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145) fix(on-policy): fix the second order algorithms performance (PKU-Alignment#147)

codecov · 2023-03-19T02:27:03Z

Codecov Report

Patch coverage: 82.80% and project coverage change: -0.22 ⚠️

Comparison is base (e6b07a7) 86.32% compared to head (a54c122) 86.11%.

❗ Current head a54c122 differs from pull request most recent head 6cfa4f2. Consider uploading reports for the commit 6cfa4f2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #157      +/-   ##
==========================================
- Coverage   86.32%   86.11%   -0.22%     
==========================================
  Files          80       82       +2     
  Lines        3760     4111     +351     
==========================================
+ Hits         3246     3540     +294     
- Misses        514      571      +57

Impacted Files	Coverage Δ
omnisafe/utils/command_app.py	`75.55% <61.90%> (-4.70%)`	⬇️
omnisafe/utils/plotter.py	`72.58% <72.58%> (ø)`
omnisafe/utils/tools.py	`86.77% <85.71%> (+5.33%)`	⬆️
omnisafe/common/statistics_tools.py	`88.41% <88.41%> (ø)`
omnisafe/algorithms/algo_wrapper.py	`92.85% <100.00%> (+1.19%)`	⬆️
omnisafe/common/experiment_grid.py	`89.57% <100.00%> (+1.09%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…lignment#162) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: borong <[email protected]>

Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: friedmainfunction <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: Ruiyang Sun <[email protected]> Co-authored-by: Jiayi Zhou <[email protected]> Co-authored-by: 1Asan <[email protected]> fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122) fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignment#131) fix typo. (PKU-Alignment#134) fix(ppo): fix entropy loss (PKU-Alignment#135) fix bugs (PKU-Alignment#136) fix: support new config for exp_grid (PKU-Alignment#142) fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145) fix(on-policy): fix the second order algorithms performance (PKU-Alignment#147)

…lignment#162) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: borong <[email protected]>

…lignment#164) Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…omnisafe into support_statistics_tools

* refactor(wrapper): refactor the cuda setting * chore: revert train_policy.py * chore: set device in safety_gymnasium_env.py * fix: [pre-commit.ci] auto fixes [...] * fix(safety_gymnasium_env.py): fix device interface --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…_statistics_tools

Gaiejj · 2023-03-27T08:06:02Z

README.md

+omnisafe train-config ./saved_source/train_config.yaml
+```
+
+


Please delete this duplicate part.

Gaiejj · 2023-03-27T08:08:29Z

...ocity-v4:::763a242578801da3979d68673a8eb89474ab4570fe6d3fa9a686117f63020872/exps_config.json

+        "vector_env_nums": 2
+    },
+    "logger_cfgs": {
+        "log_dir": "/home/borong/code/pr_typer_3_16/omnisafe/benchmark/test_statistics_tools/SafetyAntVelocity-v4:::763a242578801da3979d68673a8eb89474ab4570fe6d3fa9a686117f63020872/"


Is the log_dir needed to be change?

Gaiejj

LGTM.

zmsn-2077

LGTM.

…ched by omnisafe (#157)

* feat(statistics tools): support statistics tools for experiments launched by omnisafe (#157) * docs: update API documentation * chore: clean the code * fix: fix duplicate files * fix: delete duplicate conf.py * docs: update tools docs * chore: clean the docs * docs: update app docs * fix: fix conf.py * fix: fix cli docs * docs: update omnisafe usage * fix: [pre-commit.ci] auto fixes [...] * refactor: refactor docs structure * docs(foundations): rename docs file * docs: update introduction * fix: [pre-commit.ci] auto fixes [...] * fix: fix spelling * fix: [pre-commit.ci] auto fixes [...] * fix: fix code block * docs: update comment --------- Co-authored-by: muchvo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(statistics tools): support statistics tools for experiments launched by omnisafe (#157) * docs: update API documentation * chore: clean the code * fix: fix duplicate files * fix: delete duplicate conf.py * docs: update tools docs * chore: clean the docs * docs: update app docs * fix: fix conf.py * fix: fix cli docs * docs: update omnisafe usage * fix: [pre-commit.ci] auto fixes [...] * refactor: refactor docs structure * docs(foundations): rename docs file * docs: update introduction * fix: [pre-commit.ci] auto fixes [...] * fix: fix spelling * fix: [pre-commit.ci] auto fixes [...] * fix: fix code block * docs: update comment * docs: fix ggrammer * docs(models, envs): update api docs * docs: update title * docs: update model docs * docs(adapters): update API docs * style: clean the docs * fix: revert ruff * docs: fix spelling * docs: update start example * docs: fix typo * docs: update notation table * docs: fix notation table * docs(CUP): update cup docs * docs(TRPO): update trpo docs * fix: fix exp grid * fix: fix exp grid * chore: update version --------- Co-authored-by: muchvo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…ched by omnisafe (PKU-Alignment#157)

rockmagma02 and others added 17 commits March 15, 2023 02:53

refactor: change architecture of omnisafe (PKU-Alignment#121)

4987e80

fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122)

90f7549

chore: support num_thread setting (PKU-Alignment#124)

16be6a8

feat: update architecture of config.yaml (PKU-Alignment#126)

51e7f96

fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignm…

2aa1417

…ent#131)

chore: fix typo. (PKU-Alignment#134)

04477eb

fix(ppo): fix entropy loss (PKU-Alignment#135)

fe686bb

test: add more test case, and fix bugs (PKU-Alignment#136)

63dc035

fix: support new config for exp_grid (PKU-Alignment#142)

8b32d73

Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

feat: support policy evaluation (PKU-Alignment#137)

06dcbdb

Co-authored-by: ruiyang sun <[email protected]>

feat(off-policy): add DDPG, TD3 SAC (PKU-Alignment#128)

c232fcf

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]>

fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145)

78ec6bd

Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: borong <[email protected]> Co-authored-by: friedmainfunction <[email protected]>

fix(on-policy): fix the second order algorithms performance (PKU-Alig…

817edf9

…nment#147) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

docs: update README.md (PKU-Alignment#149)

cb633d6

docs: update changelog and release v0.1.0

ba48512

chore: update yaml (PKU-Alignment#155)

8463ca5

friedmainfunction changed the title ~~feat(statistics tools): support statistics tools for experiments launched by omnisafe.~~ feat(statistics tools): support statistics tools for experiments launched by omnisafe Mar 18, 2023

Gaiejj and others added 2 commits March 18, 2023 10:02

chore: update github workflow (PKU-Alignment#156)

5068262

friedmainfunction force-pushed the support_statistics_tools branch from cfbc781 to 427a5d2 Compare March 19, 2023 02:21

Dtrc2207 and others added 5 commits March 19, 2023 17:13

fix(onpolicy_adapter): fix the calculation of last state value (PKU-A…

973b363

…lignment#162) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: borong <[email protected]>

chore: update yaml (PKU-Alignment#155)

60c901e

chore: update github workflow (PKU-Alignment#156)

d955dd8

fix(onpolicy_adapter): fix the calculation of last state value (PKU-A…

eb45923

…lignment#162) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: borong <[email protected]>

zmsn-2077 force-pushed the dev branch from 973b363 to eb45923 Compare March 19, 2023 16:37

muchvo and others added 2 commits March 20, 2023 00:54

Merge branch 'PKU-MARL:dev' into dev

afdb8bc

fix(onpolicy_adapter): fix the calculation of last state value (PKU-A…

4d96546

…lignment#164) Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

muchvo and others added 7 commits March 26, 2023 16:55

Merge branch 'PKU-MARL:dev' into dev

c8796dc

recover files

ba1b330

fix isort

0c0aef0

fix: fix autoreset wrapper (PKU-Alignment#167)

68b9be8

recover files

21cda5b

Merge branch 'PKU-MARL:dev' into dev

16e60b6

rebase dev

d321721

friedmainfunction force-pushed the support_statistics_tools branch from bb9bee5 to d321721 Compare March 26, 2023 10:04

muchvo and others added 7 commits March 26, 2023 18:18

add warning for num_pool

9173cdc

fix: [pre-commit.ci] auto fixes [...]

568b081

Merge branch 'support_statistics_tools' of https://github.com/muchvo/…

5d62c99

…omnisafe into support_statistics_tools

docs: update README and the usage of CLI (PKU-Alignment#138)

d077842

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Merge branch 'dev' into support_statistics_tools

f423941

update readme

57b957d

zmsn-2077 force-pushed the dev branch from d077842 to e6b07a7 Compare March 27, 2023 05:18

muchvo added 2 commits March 27, 2023 13:49

Merge branch 'dev' of https://github.com/muchvo/omnisafe into support…

87f8796

…_statistics_tools

fix typo

6cfa4f2

Gaiejj self-requested a review March 27, 2023 08:04

Gaiejj requested changes Mar 27, 2023

View reviewed changes

Gaiejj approved these changes Mar 27, 2023

View reviewed changes

zmsn-2077 approved these changes Mar 27, 2023

View reviewed changes

friedmainfunction merged commit c3993bf into PKU-Alignment:dev Mar 27, 2023

friedmainfunction deleted the support_statistics_tools branch March 27, 2023 08:27

zmsn-2077 pushed a commit that referenced this pull request Mar 27, 2023

feat(statistics tools): support statistics tools for experiments laun…

eb5358e

…ched by omnisafe (#157)

Gaiejj pushed a commit to Gaiejj/omnisafe_zjy that referenced this pull request Apr 11, 2023

feat(statistics tools): support statistics tools for experiments laun…

bc4541d

…ched by omnisafe (PKU-Alignment#157)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(statistics tools): support statistics tools for experiments launched by omnisafe #157

feat(statistics tools): support statistics tools for experiments launched by omnisafe #157

muchvo commented Mar 17, 2023 •

edited

Loading

codecov bot commented Mar 19, 2023 •

edited

Loading

Gaiejj Mar 27, 2023

Gaiejj Mar 27, 2023

Gaiejj left a comment

zmsn-2077 left a comment

feat(statistics tools): support statistics tools for experiments launched by omnisafe #157

feat(statistics tools): support statistics tools for experiments launched by omnisafe #157

Conversation

muchvo commented Mar 17, 2023 • edited Loading

Description

Motivation and Context

Types of changes

Implemented Tasks

Checklist

codecov bot commented Mar 19, 2023 • edited Loading

Codecov Report

Gaiejj Mar 27, 2023

Choose a reason for hiding this comment

Gaiejj Mar 27, 2023

Choose a reason for hiding this comment

Gaiejj left a comment

Choose a reason for hiding this comment

zmsn-2077 left a comment

Choose a reason for hiding this comment

muchvo commented Mar 17, 2023 •

edited

Loading

codecov bot commented Mar 19, 2023 •

edited

Loading