Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Advanced settings on create Team and Channel #32867

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jul 23, 2024

SIDE-133

Proposed changes (including videos or screenshots)

image image

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: b49018d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.97%. Comparing base (dd42703) to head (b49018d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32867   +/-   ##
========================================
  Coverage    54.96%   54.97%           
========================================
  Files         2595     2595           
  Lines        55992    55964   -28     
  Branches     11592    11578   -14     
========================================
- Hits         30778    30766   -12     
+ Misses       22569    22555   -14     
+ Partials      2645     2643    -2     
Flag Coverage Δ
unit 72.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review July 23, 2024 20:23
@juliajforesti juliajforesti requested a review from a team as a code owner July 23, 2024 20:23
dougfabris
dougfabris previously approved these changes Jul 23, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jul 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2024
@juliajforesti juliajforesti added the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2024
@kodiakhq kodiakhq bot merged commit 0c919db into develop Aug 1, 2024
54 checks passed
@kodiakhq kodiakhq bot deleted the feat/advanced-settings branch August 1, 2024 17:56
gabriellsh added a commit that referenced this pull request Aug 5, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits)
  chore: saveAnalyticsData with accumulator (#32961)
  regression: fix dispatchInquiryPosition not being fired on room creation (#32972)
  chore: create `orm` for specific cases (#32948)
  chore: create `afterOmnichannelSaveMessage` (#32970)
  fix: `Menu` onPointerUp event behavior (#32968)
  Release 6.11.0-rc.2
  feat: add `Advanced settings` on create Team and Channel (#32867)
  Revert "fix: Login services button colors" (#32955)
  chore: Use index on `unlockAll` query called when changing OM routing methods (#32860)
  chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944)
  chore: Remove `ui-kit` from `yarn fuselage` script (#32942)
  Release 6.10.2
  fix: Client crashing on firefox private window (#32950)
  fix: Apps-Engine patch (#32935)
  test: Remove mockDate and fix unit tests (#32947) (#32949)
  fix: validate `bhType` before registering it (#32931)
  test: Remove mockDate and fix unit tests (#32947)
  Bump 6.10.2
  Release 6.11.0-rc.1
  regression: notify user properly on logout (#32920)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants