chore: saveAnalyticsData with accumulator #32961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
ggazzo
force-pushed
the
chore/saveAnalyticsData-accumulator
branch
2 times, most recently
from
fe711ac
to
b2dcf34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32961 +/- ##
===========================================
- Coverage 55.00% 55.00% -0.01%
===========================================
Files 2596 2596
Lines 56007 56006 -1
Branches 11589 11589
===========================================
- Hits 30805 30804 -1
Misses 22559 22559
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
chore/saveAnalyticsData-accumulator
branch
from
345fecd
to
130aff9
Compare
ggazzo
reviewed
Aug 2, 2024
ggazzo
reviewed
Aug 2, 2024
ggazzo
force-pushed
the
chore/saveAnalyticsData-accumulator
branch
from
801a947
to
1679cbe
Compare
ggazzo
force-pushed
the
chore/saveAnalyticsData-accumulator
branch
from
1679cbe
to
db5e20a
Compare
ggazzo
approved these changes
Aug 2, 2024
gabriellsh
added a commit
that referenced
this pull request
Aug 5, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits) chore: saveAnalyticsData with accumulator (#32961) regression: fix dispatchInquiryPosition not being fired on room creation (#32972) chore: create `orm` for specific cases (#32948) chore: create `afterOmnichannelSaveMessage` (#32970) fix: `Menu` onPointerUp event behavior (#32968) Release 6.11.0-rc.2 feat: add `Advanced settings` on create Team and Channel (#32867) Revert "fix: Login services button colors" (#32955) chore: Use index on `unlockAll` query called when changing OM routing methods (#32860) chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944) chore: Remove `ui-kit` from `yarn fuselage` script (#32942) Release 6.10.2 fix: Client crashing on firefox private window (#32950) fix: Apps-Engine patch (#32935) test: Remove mockDate and fix unit tests (#32947) (#32949) fix: validate `bhType` before registering it (#32931) test: Remove mockDate and fix unit tests (#32947) Bump 6.10.2 Release 6.11.0-rc.1 regression: notify user properly on logout (#32920) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per OPI-24, this PR modifies
saveAnalyticsDatahook to work with updater accumulator. This marks the initial implementation of the updater in practice. Additionally, this change will facilitate the integration of allafterOmnichannelSaveMessagecalls into the accumulator in the near future.Also related with #32948 and #32970.