fix: Menu onPointerUp event behavior
#32968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7d583f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32968 +/- ##
========================================
Coverage 54.97% 54.97%
========================================
Files 2595 2595
Lines 55964 55964
Branches 11578 11578
========================================
Hits 30766 30766
Misses 22555 22555
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 5, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits) chore: saveAnalyticsData with accumulator (#32961) regression: fix dispatchInquiryPosition not being fired on room creation (#32972) chore: create `orm` for specific cases (#32948) chore: create `afterOmnichannelSaveMessage` (#32970) fix: `Menu` onPointerUp event behavior (#32968) Release 6.11.0-rc.2 feat: add `Advanced settings` on create Team and Channel (#32867) Revert "fix: Login services button colors" (#32955) chore: Use index on `unlockAll` query called when changing OM routing methods (#32860) chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944) chore: Remove `ui-kit` from `yarn fuselage` script (#32942) Release 6.10.2 fix: Client crashing on firefox private window (#32950) fix: Apps-Engine patch (#32935) test: Remove mockDate and fix unit tests (#32947) (#32949) fix: validate `bhType` before registering it (#32931) test: Remove mockDate and fix unit tests (#32947) Bump 6.10.2 Release 6.11.0-rc.1 regression: notify user properly on logout (#32920) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPC-30
Proposed changes (including videos or screenshots)
When there is not enough space for the menu popover to be placed above/below its trigger, it will overlap the trigger. This causes the popover to be immediately closed and whatever item is underneath the pointer will be selected.
The issue is caused by conflicting event handlers. This PR bumps the package
@rocket.chat/fuselagewith the necessary fix.Issue(s)
Steps to test or reproduce
Further comments