Revert "fix: Login services button colors" #32955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1566412.
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.11.0 #32955 +/- ##
==================================================
+ Coverage 55.69% 55.70% +0.01%
==================================================
Files 2637 2637
Lines 57439 57439
Branches 11903 11903
==================================================
+ Hits 31988 31996 +8
+ Misses 22763 22730 -33
- Partials 2688 2713 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
approved these changes
Aug 1, 2024
dougfabris
changed the title
dougfabris
approved these changes
Aug 1, 2024
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 5, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits) chore: saveAnalyticsData with accumulator (#32961) regression: fix dispatchInquiryPosition not being fired on room creation (#32972) chore: create `orm` for specific cases (#32948) chore: create `afterOmnichannelSaveMessage` (#32970) fix: `Menu` onPointerUp event behavior (#32968) Release 6.11.0-rc.2 feat: add `Advanced settings` on create Team and Channel (#32867) Revert "fix: Login services button colors" (#32955) chore: Use index on `unlockAll` query called when changing OM routing methods (#32860) chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944) chore: Remove `ui-kit` from `yarn fuselage` script (#32942) Release 6.10.2 fix: Client crashing on firefox private window (#32950) fix: Apps-Engine patch (#32935) test: Remove mockDate and fix unit tests (#32947) (#32949) fix: validate `bhType` before registering it (#32931) test: Remove mockDate and fix unit tests (#32947) Bump 6.10.2 Release 6.11.0-rc.1 regression: notify user properly on logout (#32920) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1566412 , PR - #32570
WHY?
The PR #32570 fixes an issue related to login button colors. The PR fixes the issue but introduces another issue related to colors not following our design system. The default value of this setting resolves to blue color, making all login services buttons of blue color but according to our design system these should be of gray color.
A more apt and proper fix would be to ship the above fix with a migration which changes the setting default value to gray color. This fix will have to wait for a major release as this will be a breaking change.