Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tier4_perception_launch): pass pointcloud_container params to pointcloud_map_filter in detection module #1312

Merged
merged 2 commits into from
Jul 12, 2022
Merged

fix(tier4_perception_launch): pass pointcloud_container params to pointcloud_map_filter in detection module #1312

merged 2 commits into from
Jul 12, 2022

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Jul 12, 2022

Description

As the title says.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yukke42 yukke42 changed the title fix(perception_launch): pass pointcloud_container params to map_based_filter in detection module fix(perception_launch): pass pointcloud_container params to pointcloud_map_filter in detection module Jul 12, 2022
yukkysaito
yukkysaito approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 enabled auto-merge (squash) July 12, 2022 05:06
@yukke42
Copy link
Contributor Author

yukke42 commented Jul 12, 2022 •
edited
Loading

Required test is failed due to the CUDA environment error.

Screenshot from 2022-07-12 14-16-23

@yukke42 yukke42 changed the title fix(perception_launch): pass pointcloud_container params to pointcloud_map_filter in detection module fix(tier4_perception_launch): pass pointcloud_container params to pointcloud_map_filter in detection module Jul 12, 2022
@yukke42 yukke42 mentioned this pull request Jul 12, 2022
Merged
8 tasks
@yukke42
Copy link
Contributor Author

yukke42 commented Jul 12, 2022

related issue about CI error #1311

miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@1222-takeshi @mitsudome-r
@harihitode @wep21 @yukkysaito @kosuke55 @nnmm @simon-t4 @nik-tier4 @kmiya @scepter914 @kenji-miyake @taikitanaka3 @tkimura4 @TakaHoribe @isamu-takagi @vios-fish @adamdbrw @aohsato @KeisukeShima @h-ohta @IshitaTakeshi @kminoda @yukke42
feat: add traffic_light_recognition packages (autowarefoundation#94)
7da1565 
* release v0.4.0

* check if gdown command exists (autowarefoundation#707)

* Add nodelets of tlr nodes (autowarefoundation#715)

* Add classifier nodelet

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Replace boost::shared_ptr into std::shared_ptr

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Add lock guard

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Add detetcor nodelet

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Integrate main into node

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Add SubscriberStatusCallback

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* add image_transport_decompresser nodelet

Signed-off-by: Yukihiro Saito <[email protected]>

* Add visualizer nodelet

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* fixed bug

Signed-off-by: Yukihiro Saito <[email protected]>

* Fix plugin name

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Launch nodelet

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Fix classifier constructor

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* add decompresser node

Signed-off-by: Yukihiro Saito <[email protected]>

* fix typo

Signed-off-by: Yukihiro Saito <[email protected]>

* fixed bug

Signed-off-by: Yukihiro Saito <[email protected]>

* fixed bug

Signed-off-by: Yukihiro Saito <[email protected]>

* cosmetic change

Signed-off-by: Yukihiro Saito <[email protected]>

* add param

Signed-off-by: Yukihiro Saito <[email protected]>

* fix bug

Signed-off-by: Yukihiro Saito <[email protected]>

* Fix build warning

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* change rgb

Signed-off-by: Yukihiro Saito <[email protected]>

* change rgb

Signed-off-by: Yukihiro Saito <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>

* remove libutils dependency when unable gpu (autowarefoundation#761)

* Fix typo cliped -> clipped (autowarefoundation#776)

Signed-off-by: Kosuke Takeuchi <[email protected]>

* install launch when disable gpu (autowarefoundation#829)

* add launch and xml install when disable gpu

* remove unnecessary install

* change raw pointer to vector and shared_ptr (#817)

* change raw pointer to vector and shared_ptr

* fix bug

* Fix/cublas dependency (autowarefoundation#849)

* fix cublas depencency

* fix cublas depencency

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit 9b343cf4c11815735a176ef31f9e6e9948f20c74.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Rename launch files to launch.xml (autowarefoundation#28)

* Port traffic light classifier (autowarefoundation#70)

* port package.xml and CMakeLists.txt

Signed-off-by: mitsudome-r <[email protected]>

* port ROS messages

Signed-off-by: mitsudome-r <[email protected]>

* port to ros2

Signed-off-by: mitsudome-r <[email protected]>

* make wget buildtool_depend

Signed-off-by: mitsudome-r <[email protected]>

* remove main function

Signed-off-by: mitsudome-r <[email protected]>

* add connectCb as a timer callback

Signed-off-by: mitsudome-r <[email protected]>

* fix indentation

Signed-off-by: mitsudome-r <[email protected]>

* remove catkin includes and libraries from CMakeLists.txt

Signed-off-by: mitsudome-r <[email protected]>

* [traffic_light_ssd_fine_detector] port to ROS2 (autowarefoundation#113)

Signed-off-by: mitsudome-r <[email protected]>

* Ros2 port traffic light map (autowarefoundation#99)

* remove colcon ignore

* ported CMakelists

* port package

* remove colcon ignore

* ported CMakelists

* port package

* ported traffic_light_map_detector to ROS2 - compiling

* port launch and config files, tidied up

* change rclcpp duration arguments

* launch file corrections

* lookupTransform uses exact timestamp

* Convert calls of Duration to Duration::from_seconds where appropriate (autowarefoundation#131)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* fixing trasient_local in ROS2 packages (autowarefoundation#160)

* adding linters in traffic_light_map_based_detector (autowarefoundation#179)

* traffic_light_classifier: Fix engine save dir (autowarefoundation#250)

Signed-off-by: wep21 <[email protected]>

* traffic light map based detector: Fix launch (autowarefoundation#253)

Signed-off-by: wep21 <[email protected]>

* Ros2 v0.8.0 traffic light map based detector (autowarefoundation#262)

* change alpha (autowarefoundation#903)

Signed-off-by: Yukihiro Saito <[email protected]>

* fix typos in perception (autowarefoundation#862)

Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>

* Ros2 v0.8.0 traffic light classifier (autowarefoundation#261)

* fix typos in perception (autowarefoundation#862)

* update README.md in perception (autowarefoundation#1007)

* update traffic light recognition model (autowarefoundation#1086)

* update traffic light recognition model

* download model when hash has changed

* fix CMakeLists

* udpate tl model to scale ai dataset one (autowarefoundation#1118)

Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Satoshi Tanaka <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>

* Ros2 v0.8.0 traffic light ssd fine detector (autowarefoundation#260)

* fix typos in perception (autowarefoundation#862)

* update README.md in perception (autowarefoundation#1007)

* update traffic light recognition model (autowarefoundation#1086)

* update traffic light recognition model

* download model when hash has changed

* fix CMakeLists

* udpate tl model to scale ai dataset one (autowarefoundation#1118)

Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Satoshi Tanaka <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <[email protected]>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <[email protected]>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <[email protected]>

* Ros2 v0.8.0 beta rm std msgs ssd traffic light (autowarefoundation#395) (autowarefoundation#400)

* rm std_msgs float32

* fix typo

Co-authored-by: taikitanaka3 <[email protected]>

* add use_sim-time option (autowarefoundation#454)

* Fix rolling build errors (autowarefoundation#1225)

* Add missing include files

Signed-off-by: Kenji Miyake <[email protected]>

* Replace rclcpp::Duration

Signed-off-by: Kenji Miyake <[email protected]>

* Use reference for exceptions

Signed-off-by: Kenji Miyake <[email protected]>

* Use from_seconds

Signed-off-by: Kenji Miyake <[email protected]>

* Sync public repo (autowarefoundation#1228)

* [simple_planning_simulator] add readme (autowarefoundation#424)

* add readme of simple_planning_simulator

Signed-off-by: Takamasa Horibe <[email protected]>

* Update simulator/simple_planning_simulator/README.md

* set transit_margin_time to intersect. planner (autowarefoundation#460)

* Fix pose2twist (autowarefoundation#462)

Signed-off-by: Takagi, Isamu <[email protected]>

* Ros2 vehicle info param server (autowarefoundation#447)

* add vehicle_info_param_server

* update vehicle info

* apply format

* fix bug

* skip unnecessary search

* delete vehicle param file

* fix bug

* Ros2 fix topic name part2 (autowarefoundation#425)

* Fix topic name of traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of traffic_light_visualization

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of traffic_light_map_based_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_recognition

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix issues in hdd_reader (autowarefoundation#466)

* Fix some issues detected by Coverity Scan and Clang-Tidy

* Update launch command

* Add more `close(new_sock)`

* Simplify the definitions of struct

* fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463)

* Rviz overlay render fix (autowarefoundation#461)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <[email protected]>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <[email protected]>

* uncrustified

Signed-off-by: Adam Dabrowski <[email protected]>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <[email protected]>

* back to RTD as superclass

Signed-off-by: Adam Dabrowski <[email protected]>

* Rviz overlay render in update (autowarefoundation#465)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <[email protected]>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <[email protected]>

* uncrustified

Signed-off-by: Adam Dabrowski <[email protected]>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <[email protected]>

* removed unnecessary includes and some dead code

Signed-off-by: Adam Dabrowski <[email protected]>

* Adepted remaining vehicle plugin classes to render-in-update concept. Returned to MFD superclass

Signed-off-by: Adam Dabrowski <[email protected]>

* restored RTD superclass

Signed-off-by: Adam Dabrowski <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Makoto Tokunaga <[email protected]>
Co-authored-by: Adam Dąbrowski <[email protected]>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* handle wrong route (autowarefoundation#1312)

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>

* Dealing with wrong image size (autowarefoundation#1320)

* Dealing with wrong image size

* Fix typo

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>

* Perception components (autowarefoundation#1368)

* [bev_optical_flow]: component node

Signed-off-by: wep21 <[email protected]>

* [object_merger]: component node

Signed-off-by: wep21 <[email protected]>

* [object_range_splitter]: component node

Signed-off-by: wep21 <[email protected]>

* [shape_estimation]: component node

Signed-off-by: wep21 <[email protected]>

* [map_based_prediction]: component node

Signed-off-by: wep21 <[email protected]>

* [naive_path_prediction]: component node

Signed-off-by: wep21 <[email protected]>

* [roi_image_saver]: component node

Signed-off-by: wep21 <[email protected]>

* [lidar_apollo_instance_segmentation]: component node

Signed-off-by: wep21 <[email protected]>

* [object_flow_fusion]: component node

Signed-off-by: wep21 <[email protected]>

* [traffic_light_map_based_detector]: component node

Signed-off-by: wep21 <[email protected]>

* [dynamic_object_visualization]: component node

Signed-off-by: wep21 <[email protected]>

* Fix typo

Signed-off-by: wep21 <[email protected]>

* Use sensor data qos for traffic light recognition (autowarefoundation#1440)

Signed-off-by: wep21 <[email protected]>

* Fix/ssd fine detector (autowarefoundation#1421) (autowarefoundation#1468)

* modify fitInFrame

* cosmetic change

* bug fix

* bug fix

* cosmetic change

Co-authored-by: Yukihiro Saito <[email protected]>

* Feature/tl map based detector ros2 (autowarefoundation#1475)

* refactor and rectified distortion (autowarefoundation#1397)

* refactor and rectified distortion

* fix typo

* cosmetic change

* add readme

* cosmetic change

* cosmetic change

* update readme

* Update perception/traffic_light_recognition/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Akihito Ohsato <[email protected]>

* use image geometry (autowarefoundation#1439)

Co-authored-by: Akihito Ohsato <[email protected]>

* Apply lint

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Akihito Ohsato <[email protected]>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <[email protected]>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: pre-commit <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* Fix build error with TensorRT v8 (autowarefoundation#1612)

* Fix build error with TensorRT v8

Signed-off-by: wep21 <[email protected]>

* Fix typo

Signed-off-by: wep21 <[email protected]>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* suppress warnings for declare parameters (autowarefoundation#1724)

* fix for lanelet2_extension

* fix for traffic light ssd fine detector

* fix for topic_state_monitor

* fix for dummy diag publisher

* fix for remote cmd converter

* fix for vehicle_info_util

* fix for multi object tracker

* fix for freespace planner

* fix for autoware_error_monitor

* add Werror for multi object tracker

* fix for multi object tracker

* add Werror for liraffic light ssd fine detector

* add Werror for topic state monitor

* add Werror

* add Werror

* add Werror

* add Werror

* fix style

* suppress warnings for traffic light classifier (autowarefoundation#1762)

* add Werror

* fix type

* fix unused

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>

* Fix compiler warnings (autowarefoundation#1837)

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-variable

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wformat-security

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Winvalid-constexpr

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wdelete-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Winconsistent-missing-override

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <[email protected]>

* Fix "invalid application of 'sizeof' to an incomplete type"

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wgnu-anonymous-struct and -Wnested-anon-types

Signed-off-by: Kenji Miyake <[email protected]>

* Fix lint

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wno-deprecated-declarations in CUDA-related packages

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix clang warnings (autowarefoundation#1859)

* Fix -Wreturn-std-move

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wnonportable-include-path for mussp

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-const-variable

Signed-off-by: Kenji Miyake <[email protected]>

* Fix "can not be used when making a shared object"

Signed-off-by: Kenji Miyake <[email protected]>

* Invoke code formatter at pre-commit (autowarefoundation#1935)

* Run ament_uncrustify at pre-commit

* Reformat existing files
* Fix copyright and cpplint errors

Signed-off-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Fix readme traffic light map based detector (autowarefoundation#2282)

* fix type of ~input/route in readme

* fix some grammar mistakes

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* [traffic_light_ssd_fine_detector] support autoware auto msgs (autowarefoundation#514)

* remove COLCON_IGNORE

* support autoware auto msgs

* fix sort pacakagge

* [traffic_light_map_based_detector] support autoware auto msgs (autowarefoundation#511)

* [traffic_light_classifier] support autoware auto msgs (autowarefoundation#504)

* update README of traffic_light_classifier (autowarefoundation#649)

* update README of traffic_light_classifier

* Update label explanation (autowarefoundation#652)

* Update README.md

* fix format

* fix markdown lint

* update readme

Co-authored-by: Taichi Higashide <[email protected]>

* add readme for traffic light ssd fine detector (autowarefoundation#637)

* declare variable before subscriber registration (autowarefoundation#705)

* update traffic light classifier readme (autowarefoundation#726)

* Update traffic light topic name (autowarefoundation#729)

* Update traffic light topic name

Signed-off-by: wep21 <[email protected]>

* Update traffic light topic name in perception

Signed-off-by: wep21 <[email protected]>

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Daichi Murakami <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: simon-t4 <[email protected]>
Co-authored-by: nik-tier4 <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Satoshi Tanaka <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Makoto Tokunaga <[email protected]>
Co-authored-by: Adam Dąbrowski <[email protected]>
Co-authored-by: Akihito Ohsato <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: pre-commit <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takeshi Ishita <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: kminoda <[email protected]>
Co-authored-by: Yusuke Muramatsu <[email protected]>
@yukke42 yukke42 force-pushed the fix-perception-launch-of-pointcloud-container branch from 249fa65 to 2b69918 Compare July 12, 2022 11:52
@codecov
Copy link

codecov bot commented Jul 12, 2022 •
edited
Loading

Codecov Report

Merging #1312 (2b69918) into main (db01212) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 2b69918 differs from pull request most recent head 86c31f2. Consider uploading reports for the commit 86c31f2 to get more accurate results

@@          Coverage Diff          @@
##            main   #1312   +/-   ##
=====================================
  Coverage   9.51%   9.51%           
=====================================
  Files       1096    1096           
  Lines      76148   76148           
  Branches   16991   16991           
=====================================
  Hits        7244    7244           
  Misses     62292   62292           
  Partials    6612    6612
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 9.49% <0.00%> (ø) Carriedforward from db01212

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
map/lanelet2_extension/lib/query.cpp 9.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74427a8...86c31f2. Read the comment docs.

@yukke42 yukke42 force-pushed the fix-perception-launch-of-pointcloud-container branch from 2b69918 to 3087e5e Compare July 12, 2022 11:58
@yukke42 yukke42 disabled auto-merge July 12, 2022 12:06
@yukke42 yukke42 force-pushed the fix-perception-launch-of-pointcloud-container branch from 3087e5e to 86c31f2 Compare July 12, 2022 13:31
@yukke42 yukke42 enabled auto-merge (squash) July 12, 2022 13:31
@yukke42 yukke42 merged commit c36e22e into autowarefoundation:main Jul 12, 2022
@yukke42 yukke42 deleted the fix-perception-launch-of-pointcloud-container branch July 12, 2022 15:37
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 13, 2022
Merged
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
@yukke42 @kosuke55
fix(tier4_perception_launch): pass pointcloud_container params to poi…
a955e37 
…ntcloud_map_filter in detection module (#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
shmpwk referenced this pull request in tier4/autoware.universe Jul 14, 2022
@yukke42 @shmpwk
fix(tier4_perception_launch): pass pointcloud_container params to poi…
9c3a6aa 
…ntcloud_map_filter in detection module (#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
yukke42 referenced this pull request in tier4/autoware.universe Aug 9, 2022
@yukke42
fix(tier4_perception_launch): pass pointcloud_container params to poi…
2a0c5e7 
…ntcloud_map_filter in detection module (#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@yukke42 @boyali
fix(tier4_perception_launch): pass pointcloud_container params to poi…
3243fe4 
…ntcloud_map_filter in detection module (tier4#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@yukke42 @boyali
fix(tier4_perception_launch): pass pointcloud_container params to poi…
061e170 
…ntcloud_map_filter in detection module (tier4#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@yukke42 @boyali
fix(tier4_perception_launch): pass pointcloud_container params to poi…
34d36ca 
…ntcloud_map_filter in detection module (tier4#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 7, 2022
@yukke42 @1222-takeshi
fix(tier4_perception_launch): pass pointcloud_container params to poi…
ab9f9b9 
…ntcloud_map_filter in detection module (#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
@1222-takeshi 1222-takeshi mentioned this pull request Oct 7, 2022
Merged
4 tasks
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 7, 2022
@yukke42 @1222-takeshi
fix(tier4_perception_launch): pass pointcloud_container params to poi…
db94c1c 
…ntcloud_map_filter in detection module (#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
yukke42 added a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@yukke42
fix(tier4_perception_launch): pass pointcloud_container params to poi…
f5076f0 
…ntcloud_map_filter in detection module (autowarefoundation#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@yukke42 @boyali
fix(tier4_perception_launch): pass pointcloud_container params to poi…
3075cc9 
…ntcloud_map_filter in detection module (tier4#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
@yukke42 @satoshi-ota
fix(tier4_perception_launch): pass pointcloud_container params to poi…
e90c887 
…ntcloud_map_filter in detection module (autowarefoundation#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 2, 2023
@yukke42 @badai-nguyen
fix(tier4_perception_launch): pass pointcloud_container params to poi…
e17c9cd 
…ntcloud_map_filter in detection module (autowarefoundation#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jun 12, 2024
@shmpwk
Merge pull request autowarefoundation#1312 from tier4/cherry-pick/pr7146
1d0e185 
chore(blind_spot): PR7110 and PR7164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukke42 @yukkysaito