Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_merger): refactor object merger #146

Merged
merged 10 commits into from
Oct 14, 2022

Conversation

1222-takeshi
Copy link

@1222-takeshi 1222-takeshi commented Oct 7, 2022

Description

Note: Do NOT squash merge this PR.

Related Links

PR List:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@1222-takeshi 1222-takeshi changed the title Feat/refactor object merger feat(object_merger): refactor object merger Oct 7, 2022
takayuki5168 and others added 10 commits October 7, 2022 16:18
* feat(perception_utils): add new package

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* add test

Signed-off-by: Takayuki Murooka <[email protected]>

* add more functions

Signed-off-by: Takayuki Murooka <[email protected]>

* fix ci build error

Signed-off-by: Takayuki Murooka <[email protected]>

* Update common/perception_utils/include/perception_utils/geometry.hpp

Co-authored-by: Yukihiro Saito <[email protected]>

* fix ci error

Signed-off-by: Takayuki Murooka <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>
…on#1908)

* refactor(perception_utils): add label util function

Signed-off-by: scepter914 <[email protected]>

* fix hpp define

Signed-off-by: scepter914 <[email protected]>

* Update common/perception_utils/include/perception_utils/object_classification.hpp

Co-authored-by: Kenji Miyake <[email protected]>

* fix isVehicle function

Signed-off-by: scepter914 <[email protected]>

* add CarLikeVehicle function

Signed-off-by: scepter914 <[email protected]>

Signed-off-by: scepter914 <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
…eption_launch (#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ntcloud_map_filter in detection module (#1312)

* fix(tier4_perception_launch): pass pointcloud_container to detection module

Signed-off-by: yukke42 <[email protected]>

* fix(tier4_perception_launch): container name in detection

Signed-off-by: yukke42 <[email protected]>
* fix(tier4_perception_launch): add group tag

Signed-off-by: Xinyu Wang <[email protected]>

* fix missing tag

Signed-off-by: Xinyu Wang <[email protected]>
* cosmetic change

Signed-off-by: Yukihiro Saito <[email protected]>

* fix bug

Signed-off-by: Yukihiro Saito <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* cosmetic change

Signed-off-by: Yukihiro Saito <[email protected]>

* fix bug

Signed-off-by: Yukihiro Saito <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…1902)

* feat(object_merger): add distance threshold

Signed-off-by: Shin-kyoto <[email protected]>

* feat(object_merger): remove param from declare_parameter

Signed-off-by: Shin-kyoto <[email protected]>

* feat(object_merger): add distance_threshold_list

Signed-off-by: Shin-kyoto <[email protected]>

* feat(object_merger): use map instead of list, and use yaml for param

Signed-off-by: Shin-kyoto <[email protected]>

* feat(object_merger): add function converting list to map

Signed-off-by: Shin-kyoto <[email protected]>

* feat(object_merge): added extended scale and tuned parameter

Signed-off-by: Shin-kyoto <[email protected]>

* feat(perception_utils): add generalized IoU

Signed-off-by: Shin-kyoto <[email protected]>

* feat(object_merger): use generalized IoU threshold instead of extended_scale

Signed-off-by: Shin-kyoto <[email protected]>

* fix(perception_utils): move 2 functions to anonymous namespace and use MinMax instead of MaxMin

Signed-off-by: Shin-kyoto <[email protected]>

* ci(pre-commit): autofix

* refactor(perception_utils): use convex hull instead of convex rectangle

Signed-off-by: Shin-kyoto <[email protected]>

Signed-off-by: Shin-kyoto <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat(tier4_autoware_utils): add boost_polygon_utils.hpp

Signed-off-by: Takayuki Murooka <[email protected]>

* minor fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix build error

Signed-off-by: Takayuki Murooka <[email protected]>

* add test

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix build error

Signed-off-by: Takayuki Murooka <[email protected]>

* Revert "fix build error"

This reverts commit eb86a92.

* ClockWise -> Clockwise

Signed-off-by: Takayuki Murooka <[email protected]>
tkimura4
tkimura4 previously approved these changes Oct 7, 2022
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 changed the base branch from beta/v0.5.2 to beta/v0.5.2-odaiba October 14, 2022 02:59
@tkimura4 tkimura4 dismissed their stale review October 14, 2022 02:59

The base branch was changed.

@tkimura4 tkimura4 marked this pull request as ready for review October 14, 2022 02:59
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 268a8ac into beta/v0.5.2-odaiba Oct 14, 2022
@tkimura4 tkimura4 deleted the feat/refactor-object-merger branch October 14, 2022 03:00
tkimura4 pushed a commit that referenced this pull request Oct 24, 2022
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
* ci: add build CI

Signed-off-by: Kenji Miyake <[email protected]>

* feat: add files for Ansible Galaxy

Signed-off-by: Kenji Miyake <[email protected]>

* feat: copy ansible files from tier4's proposal

Remove cache_valid_time

Signed-off-by: Kenji Miyake <[email protected]>

v0.4.0

Signed-off-by: mitsudome-r <[email protected]>

copy setup

Signed-off-by: Takamasa Horibe <[email protected]>

add ros2 ansible roles

Signed-off-by: Takamasa Horibe <[email protected]>

ansible add ubuntu20 setup

Signed-off-by: Takamasa Horibe <[email protected]>

ansible fix pacmod

Signed-off-by: Takamasa Horibe <[email protected]>

temp disable cuda & tensorrt

Signed-off-by: Takamasa Horibe <[email protected]>

ansible fix kvaser library repo

Signed-off-by: Takamasa Horibe <[email protected]>

temporally comment out for unused modules

Signed-off-by: Takamasa Horibe <[email protected]>

remove unused codes

Signed-off-by: Takamasa Horibe <[email protected]>

Install osqp only once (tier4#95)

* update readme and fix osqp_vendor tag

* Remove ansible osqp role

fix: ansbile role

Closes tier4#140

add ansible for cuda 11.1 & tensorrt 7.2.1 & cudnn 8.0.5

Signed-off-by: Takamasa Horibe <[email protected]>

add script for install livox sdk

Signed-off-by: kosuke murakami <[email protected]>

add ansible sdk task

Signed-off-by: kosuke murakami <[email protected]>

Use Livox vendor package (tier4#156)

* Use Livox vendor package

* Removed Livox SDK from ansible

* Use upstream Livox ROS2 driver

Install kvaser library

Signed-off-by: wep21 <[email protected]>

Update ansible/localhost-setup-ubuntu20.04-devpc.yml

Install kvaser library from origin

Signed-off-by: wep21 <[email protected]>

Update ansible/localhost-setup-ubuntu20.04-devpc.yml

install vcstool and do vcs import in ansible setup (tier4#170)

Update documents and fix typos

* update install instructions
* remove redundant statements
* fix typos

Separate Ansible tasks related to vcs import to new role (tier4#180)

* Separate Ansible tasks related to vcs import to new role

* Move the Ansible task to install vcstool to the ROS2 role

Add rmw-cyclonedds-cpp to ansible (tier4#67)

* Add rmw-cyclonedds-cpp to ansible

Signed-off-by: Kenji Miyake <[email protected]>

* Add settings to .bashrc

Signed-off-by: Kenji Miyake <[email protected]>

Fix setup script typos (tier4#202) (tier4#73)

Signed-off-by: Lalith Vipulananthan <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>

Revive pacmod role (tier4#103)

* Revert "Install kvaser library from origin"

This reverts commit 3859fffd60164febbaacc2f68b045d3b0d07f3d6.

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ROS role

Signed-off-by: Kenji Miyake <[email protected]>

install pip before rosdep (tier4#72)

Fix: Update GPG key download task for ROS2 (tier4#125)

* Fix: Update GPG key download task for ROS2

* Fix: Update comments, source list

Add pre-commit CI (tier4#167)

* Add pre-commit CI

Signed-off-by: Kenji Miyake <[email protected]>

* Add .prettierrc.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore some markdownlint rules

Signed-off-by: Kenji Miyake <[email protected]>

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

Move to ROS2 Galactic (tier4#107)

* Fix rosdistro in ansible

Fix rosdistro other than autoware in ansible (tier4#146)

* Use upstream grid_map

Signed-off-by: Kenji Miyake <[email protected]>

* Remove rosbag2

Signed-off-by: kosuke55 <[email protected]>

* Change position of ecu_system_setup section

Signed-off-by: Kenji Miyake <[email protected]>

* Add missing_packages in galactic

Signed-off-by: Kenji Miyake <[email protected]>

* Add ros2/rosbag2 galactic to repos

Signed-off-by: kosuke55 <[email protected]>

* Purge installed rosbag2 to build it from source

Signed-off-by: kosuke55 <[email protected]>

* Add TODO comment to repos

Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: kosuke55 <[email protected]>

Install ros-galactic-ros2cli-common-extensions in ansible (tier4#183)

* Signed-off-by: kosuke55 <[email protected]>

Install ros-galactic-ros2cli-common-extensions in ansible

Signed-off-by: kosuke55 <[email protected]>

* Add descriptions of rosbag2 purge

Use apt installed rosbag2 (tier4#189)

Signed-off-by: kosuke55 <[email protected]>

Remove vcs import in ansible (tier4#198)

* Remove vcs import in ansible

Signed-off-by: kosuke55 <[email protected]>

* Update installation steps

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

fix gdown install command (tier4#214)

Simplify ansible files (tier4#122)

* Simplify ansible files

Signed-off-by: Kenji Miyake <[email protected]>

* Add build-pr.yml

Signed-off-by: Kenji Miyake <[email protected]>

add libtorch (tier4#131) (tier4#191)

* add libtorch (tier4#131)

* add libtorch

* update libtorch 1.6.0 -> 1.8.1

* libtorch for CUDA 11.1

* use the same command

* libtorch 1.8.1 -> 1.6.0

* add LibTorch for CUDA 11.1

* change install order

* Deprecate 18.04 support for libtorch

Signed-off-by: wep21 <[email protected]>

* pre-commit fixes

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yusuke Muramatsu <[email protected]>

fix libtorch install (tier4#196)

Feature/remove pacmod3 (tier4#349)

* remove pacmod3

* Remove kvaser_interface from repos

Signed-off-by: wep21 <[email protected]>

* Fix ansible

Signed-off-by: wep21 <[email protected]>

* Fix vcs import action

Signed-off-by: wep21 <[email protected]>

* Run pre-commit

Signed-off-by: wep21 <[email protected]>

Co-authored-by: wep21 <[email protected]>

add go dependency for pre-commit (tier4#388)

* add go dependency by snap install --classic

* move install-go from autoware/ to pre-commit/

* update playbook.yml

* use apt without snap to install golang

* chore: clean up files

Signed-off-by: Kenji Miyake <[email protected]>

* fix: specify pip3 executable to prevent pipx to be used

Signed-off-by: Kenji Miyake <[email protected]>

* feat: add docker role

Signed-off-by: Kenji Miyake <[email protected]>

* fix: use ansible_user_id instead of ansible_env.USER

root user doesn't have ansible_env.USER.

Signed-off-by: Kenji Miyake <[email protected]>

* chore: fix verbose option

Signed-off-by: Kenji Miyake <[email protected]>

* feat: remove libtorch

Signed-off-by: Kenji Miyake <[email protected]>

* feat: add --no-nvidia option

Signed-off-by: Kenji Miyake <[email protected]>

* style: rename ansible_options to ansible_args

Signed-off-by: Kenji Miyake <[email protected]>

* feat: update CUDA versions

Signed-off-by: Kenji Miyake <[email protected]>

* chore: fix scripts around sudo

Signed-off-by: Kenji Miyake <[email protected]>

* feat: support arm64-sbsa in CUDA role

Signed-off-by: Kenji Miyake <[email protected]>

* ci: add ARM build

Signed-off-by: Kenji Miyake <[email protected]>

* chore: comment out simulator repositories

autowarefoundation/autoware#21
Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants