Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dummy_perception_publisher): change raytrace param #414

Conversation

taikitanaka3
Copy link
Contributor

Related Issue(required)

#413

Description(required)

set raytracing param for relatively better

image

Review Procedure(required)

launch psim and enable occ grid tab to visualize
image

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #414 (a977252) into tier4/proposal (0e70c77) will decrease coverage by 10.10%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           tier4/proposal    #414       +/-   ##
==================================================
- Coverage           10.10%   0.00%   -10.11%     
==================================================
  Files                 705      12      -693     
  Lines               49295     449    -48846     
  Branches             6265       0     -6265     
==================================================
- Hits                 4980       0     -4980     
+ Misses              40248     449    -39799     
+ Partials             4067       0     -4067     
Impacted Files Coverage Δ
simulator/dummy_perception_publisher/src/node.cpp 0.00% <ø> (ø)
system/system_monitor/src/net_monitor/nl80211.cpp
...ule/intersection/scene_merge_from_private_road.cpp
...n/include/traffic_light_roi_visualizer/nodelet.hpp
...onstants_manager/src/vehicle_constants_manager.cpp
...acker/src/tracker/model/normal_vehicle_tracker.cpp
...include/shape_estimation/model/model_interface.hpp
.../scenario_selector_node/scenario_selector_node.cpp
...analysis/src/control_performance_analysis_core.cpp
...tion_testing/src/motion_testing/motion_testing.cpp
... and 684 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e70c77...a977252. Read the comment docs.

@yukkysaito yukkysaito merged commit 288db04 into autowarefoundation:tier4/proposal Feb 21, 2022
@yukkysaito
Copy link
Contributor

The voxel-based ray trace has limitations, so we will change to something like embree in the future.

taikitanaka3 referenced this pull request in tier4/autoware.universe Feb 21, 2022
mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this pull request Mar 1, 2022
* release v0.4.0

* Support G29 controller in autoware_joy_controller (autowarefoundation#699)

* Add map for G29 controller

* Add new line at end of file

* Change structure of JoyConverterBase class

* Rename PS4 -> DS4

* Rename controler_type -> joy_type

* Set joy_type by console input

* Change doc

* Remap g29 controller

* Remap AccelPedal -> accel, BrakePedal -> brake

* Remove [autoware_joy_controller] from ROS_INFO

Co-authored-by: Fumiya Watanabe <[email protected]>

* Change key map for G29 controller and set deadzone parameter (autowarefoundation#740)

* Add missing dependencies of autoware_joy_controller (autowarefoundation#755)

Signed-off-by: Kenji Miyake <[email protected]>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* add sample ros2 packages

Signed-off-by: mitsudome-r <[email protected]>

* remove ROS1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit c98294b0b159fb98cd3091d34a626d06f29fdece.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Rename launch files to launch.xml (autowarefoundation#28)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Port autoware joy controller (autowarefoundation#124)

* Port

Signed-off-by: Servando German Serrano <[email protected]>

* Fixed package.xml

* now() to use node clock

Signed-off-by: Servando German Serrano <[email protected]>

* Fix include

Signed-off-by: Servando German Serrano <[email protected]>

* Clear compilation warnings

Signed-off-by: Servando German Serrano <[email protected]>

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* [update to v0.8.0] autoware joy controller (autowarefoundation#251)

* restore filename to original for version update

Signed-off-by: Takamasa Horibe <[email protected]>

* Enable to change sensitivity (autowarefoundation#868)

* Improve remote emergency stop (autowarefoundation#900)

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Rename emergency to system_emergency in vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Add emergency stop feature to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Fix frame_id of vehicle_cmd_gate output

Signed-off-by: Kenji Miyake <[email protected]>

* Rename /remote/emergency to /remote/emergency_stop in autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Rename /remote/emergency to /remote/emergency_stop in remote_cmd_converter

Signed-off-by: Kenji Miyake <[email protected]>

* Rename /remote/emergency to /remote/emergency_stop in autoware_api

Signed-off-by: Kenji Miyake <[email protected]>

* Check emergency_stop timeout in remote_cmd_converter

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore timeout = 0.0

Signed-off-by: Kenji Miyake <[email protected]>

* Add config_file to arg

Signed-off-by: Kenji Miyake <[email protected]>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <[email protected]>

* Remove unnecessary lines

Signed-off-by: Kenji Miyake <[email protected]>

* Wait for first heartbeat

Signed-off-by: Kenji Miyake <[email protected]>

* Add clear_emergency_stop service

Signed-off-by: Kenji Miyake <[email protected]>

* Call clear_external_emegency_stop service from autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Rename function

Signed-off-by: Kenji Miyake <[email protected]>

* Revert: Wait for first heartbeat

Signed-off-by: Kenji Miyake <[email protected]>

* Fix console messages

Signed-off-by: Kenji Miyake <[email protected]>

* Move emergency_stop diag to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Add heartbeat to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Revert: Move emergency_stop diag to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* patch in real-vehicle

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Change default parameter

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: jpntaxi4943-autoware <[email protected]>

* restore file name

Signed-off-by: Takamasa Horibe <[email protected]>

* [tmp] fix build error

Signed-off-by: Takamasa Horibe <[email protected]>

* fix service

Signed-off-by: Takamasa Horibe <[email protected]>

* fix format

Signed-off-by: Takamasa Horibe <[email protected]>

* fix service usage

Signed-off-by: Takamasa Horibe <[email protected]>

* fix launch var

Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: jpntaxi4943-autoware <[email protected]>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <[email protected]>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <[email protected]>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <[email protected]>

* remove using in global namespace (autowarefoundation#379)

* remove using in global namespace (autowarefoundation#1166)

* remove using in global namespace

* Revert "remove using in global namespace"

This reverts commit 7f120509c9e3a036a38e84883868f6036bca23ad.

* Add package namespace

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* [autoware_joy_controller] add lint tests

Signed-off-by: mitsudome-r <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* fix namespace (autowarefoundation#414)

* add use_sim-time option (autowarefoundation#454)

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <[email protected]>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <[email protected]>

* Make control modules components (autowarefoundation#1262)

Signed-off-by: wep21 <[email protected]>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* Remove autoware_debug_msgs from autoware_joy_controller (autowarefoundation#1303)

Signed-off-by: Kenji Miyake <[email protected]>

* Porting remote cmd selector (autowarefoundation#1286)

* Feature/add remote cmd selector (autowarefoundation#1179)

* Add in/out args of remote_cmd_converter.launch

Signed-off-by: Kenji Miyake <[email protected]>

* Change remote input topic of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Add msgs for remote_cmd_selector

Signed-off-by: Kenji Miyake <[email protected]>

* Add remote_cmd_selector

Signed-off-by: Kenji Miyake <[email protected]>

* Rename remote_cmd_selector to external_cmd_selector

Signed-off-by: Kenji Miyake <[email protected]>

* Remove VehicleCommand support in autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix porting miss

Signed-off-by: Kenji Miyake <[email protected]>

* fix missing function

* modify xml format

* fix include guard

* add callback group

* modify remap name

* Revert "modify remap name"

This reverts commit 169cc8d28442825b1d61b0439b9892c913304527.

* change topic name

* use rclcpp_component

* Remove autoware_debug_msgs from autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Change default mode of autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* Ros2/create/external commands (autowarefoundation#1299)

* add remote message

* add remote commands

* fix topic

* remove unnecessary topic

* remove unused topic

* add external cmd instead

* ToExternalComd

* fix topic in joy con

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>

* Add autoware api (autowarefoundation#1979)

* Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030)

* Use EmergencyState instead of deprecated EmergencyMode

Signed-off-by: Kenji Miyake <[email protected]>

* Use stamped type

Signed-off-by: Kenji Miyake <[email protected]>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Add selected external command API (autowarefoundation#2053)

* submit engage with api service from joy controller (autowarefoundation#2320)

* fix engagew with api

* delete unused

* fix for uncrustify

* revive vehicle_engage

* some fix

* revive autoware name

* fix service name

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* port autoware joy controller (autowarefoundation#588)

* port autoware joy controller

* fix compile error

* use odometry instead of twist

* update launch

Co-authored-by: Takayuki Murooka <[email protected]>

* update README.md in autoware_joy_controller (autowarefoundation#593)

* update README.md

* update README.md

* fix typo

* Update control/autoware_joy_controller/README.md

Co-authored-by: taikitanaka3 <[email protected]>

* update README.md

Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>

* fix format

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Servando <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: jpntaxi4943-autoware <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takeshi Miura <[email protected]>
taikitanaka3 added a commit to taikitanaka3/autoware.universe that referenced this pull request Mar 2, 2022
TakaHoribe referenced this pull request in tier4/autoware.universe Mar 3, 2022
taikitanaka3 added a commit that referenced this pull request Mar 3, 2022
* Revert "chore(dummy_perception_publisher): change raytrace param (#414)"

This reverts commit d29e0e1.

Signed-off-by: taikitanaka <[email protected]>

* chore(dummy_perception): revert change leaf size and disable raytrace

Signed-off-by: taikitanaka <[email protected]>
@taikitanaka3 taikitanaka3 deleted the 413-dummy-perception-publisher-change-raytrace-param branch April 14, 2022 00:52
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <[email protected]>

Co-authored-by: h-ohta <[email protected]>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants