-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v15.1.0 release proposal #35948
v15.1.0 release proposal #35948
Commits on Nov 3, 2020
-
src: add --heapsnapshot-near-heap-limit option
This patch adds a --heapsnapshot-near-heap-limit CLI option that takes heap snapshots when the V8 heap is approaching the heap size limit. It will try to write the snapshots to disk before the program crashes due to OOM. PR-URL: #33010 Refs: #27552 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7f37bc - Browse repository at this point
Copy the full SHA a7f37bcView commit details -
deps: V8: backport 4263f8a5e8e0
Original commit message: parser: better error message for await+tla Bug: v8:9344, v8:6513 Change-Id: I1854e483515e7da99192367b6764a0ec7c8b41d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2411687 Reviewed-by: Marja Hölttä <[email protected]> Commit-Queue: Gus Caplan <[email protected]> Cr-Commit-Position: refs/heads/master@{#70099} Refs: v8/v8@4263f8a PR-URL: #35650 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 894419c - Browse repository at this point
Copy the full SHA 894419cView commit details -
test: add windows and C++ coverage
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11eca36 - Browse repository at this point
Copy the full SHA 11eca36View commit details -
v8: implement v8.takeCoverage()
Add an v8.takeCoverage() API that allows the user to write the coverage started by NODE_V8_COVERAGE to disk on demand. The coverage can be written multiple times during the lifetime of the process, each time the execution counter will be reset. When the process is about to exit, one last coverage will still be written to disk. Also refactors the internal profiler connection code so that we use the inspector response id to identify the profile response instead of using an ad-hoc flag in C++. PR-URL: #33807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 15ffed5 - Browse repository at this point
Copy the full SHA 15ffed5View commit details -
v8: implement v8.stopCoverage()
Add a v8.stopCoverage() API to stop the coverage collection started by NODE_V8_COVERAGE - this would be useful in conjunction with v8.takeCoverage() if the user don't want to emit the coverage at the process exit but still want to collect it on demand at some point. PR-URL: #33807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7bfa872 - Browse repository at this point
Copy the full SHA 7bfa872View commit details -
build: add license-builder GitHub Action
PR-URL: #35712 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a9c0924 - Browse repository at this point
Copy the full SHA a9c0924View commit details -
doc: add Installing Node.js header in BUILDING.md
PR-URL: #35710 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f269c6c - Browse repository at this point
Copy the full SHA f269c6cView commit details -
doc,esm: document experimental warning removal
PR-URL: #35750 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 05a888a - Browse repository at this point
Copy the full SHA 05a888aView commit details -
doc,src,test: revise C++ code for linter update
PR-URL: #35719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 564aade - Browse repository at this point
Copy the full SHA 564aadeView commit details -
https://github.com/cpplint/cpplint/releases/tag/1.5.0 PR-URL: #35719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 042d4dd - Browse repository at this point
Copy the full SHA 042d4ddView commit details -
tools: refloat 7 Node.js patches to cpplint.py
Cherry-pick 12c8b4d Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: #17373 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Refs: 12c8b4d Cherry-pick fc81e80 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: #21521 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: fc81e80 Cherry-pick cbc3dd9 Original commit message: src, tools: add check for left leaning pointers This commit adds a rule to cpplint to check that pointers in the code base lean to the left and not right, and also fixes the violations reported. PR-URL: #21010 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: cbc3dd9 Cherry-pick 9029981 Original commit message: tools: fix cpplint.py header rules THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT. PR-URL: #26306 Reviewed-By: Gireesh Punathil <[email protected]> Refs: 9029981 Cherry-pick 0a25ace Original commit message: tools: move cpplint configuration to .cpplint PR-URL: #27098 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Refs: 0a25ace Cherry-pick afa9a72 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: #30876 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Refs: afa9a72 Cherry-pick e23bf8f Original commit message: tools,src: refloat forbid usage of v8::Persistent `v8::Persistent` comes with the surprising catch that it requires manual cleanup. `v8::Global` doesn’t, making it easier to use, and additionally provides move semantics. New code should always use `v8::Global`. PR-URL: #31018 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> PR-URL: #35569 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> PR-URL: #35719 Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 66da122 - Browse repository at this point
Copy the full SHA 66da122View commit details -
doc: update package.json field definitions
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: #35741 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6590f8c - Browse repository at this point
Copy the full SHA 6590f8cView commit details -
deps: update to [email protected]
PR-URL: #35745 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e0a1541 - Browse repository at this point
Copy the full SHA e0a1541View commit details -
stream: fix duplicate logic in stream destroy
Fix duplicate logic in stream destroy as the same logic is being shared across methods and thus can be encapsulated into a single method. PR-URL: #35727 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 88eb619 - Browse repository at this point
Copy the full SHA 88eb619View commit details -
doc: this prints replaced with this is printed
PR-URL: #35515 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1892532 - Browse repository at this point
Copy the full SHA 1892532View commit details -
doc: improve text for breakOnSigint
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: #35692 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 890b03e - Browse repository at this point
Copy the full SHA 890b03eView commit details -
doc: add missing link in Node.js 14 Changelog
Refs: #35525 PR-URL: #35782 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 292b529 - Browse repository at this point
Copy the full SHA 292b529View commit details -
doc: update console.error example
Signed-off-by: Lee, Bonggi <[email protected]> PR-URL: #34964 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4b7708a - Browse repository at this point
Copy the full SHA 4b7708aView commit details -
test: add additional deprecation warning tests for rmdir recursive
PR-URL: #35683 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c5e8ed - Browse repository at this point
Copy the full SHA 0c5e8edView commit details -
http2: remove unsupported %.* specifier
The debug sprintf doesn't support %.* specifiers Fixes: #35688 PR-URL: #35694 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: David Carlier <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cfe61b8 - Browse repository at this point
Copy the full SHA cfe61b8View commit details -
dns: add setLocalAddress to Resolver
Fixes: #34818 PR-URL: #34824 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 548f91a - Browse repository at this point
Copy the full SHA 548f91aView commit details -
doc: document changes for
*/promises
alias modulesFixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]> Co-authored-by: Rich Trott <[email protected]> PR-URL: #34002 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55b7a6c - Browse repository at this point
Copy the full SHA 55b7a6cView commit details -
http2: add updateSettings to both http2 servers
Allow the user to update the server settings after using http2.createSecureServer() or after using http2.createServer(). Fixes: #35353 PR-URL: #35383 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 883ed4b - Browse repository at this point
Copy the full SHA 883ed4bView commit details -
http2: reinject data received before http2 is attached
Reinject the data already received from the TLS socket when the HTTP2 client is attached with a delay Fixes: #35475 PR-URL: #35678 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5833007 - Browse repository at this point
Copy the full SHA 5833007View commit details -
We reinject when the sockets has already waiting data, remarked by @mildsunrise Co-authored-by: Alba Mendez <[email protected]> PR-URL: #35678 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 86ed87b - Browse repository at this point
Copy the full SHA 86ed87bView commit details -
doc: add a example code to API doc property
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6aa7c8 - Browse repository at this point
Copy the full SHA f6aa7c8View commit details -
timers: correct explanation in comment
PR-URL: #35437 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a41e3eb - Browse repository at this point
Copy the full SHA a41e3ebView commit details -
stream: remove redundant context from comments
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: #35728 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 70c41a8 - Browse repository at this point
Copy the full SHA 70c41a8View commit details -
doc: mark optional parameters in timers.md
PR-URL: #35764 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 368ae95 - Browse repository at this point
Copy the full SHA 368ae95View commit details -
doc: remove stability warning in v8 module doc
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: #35774 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f49afb5 - Browse repository at this point
Copy the full SHA f49afb5View commit details -
doc: fix header level in fs.md
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: #35771 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e9acf8 - Browse repository at this point
Copy the full SHA 0e9acf8View commit details -
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: #35767 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 110ef8a - Browse repository at this point
Copy the full SHA 110ef8aView commit details -
doc: fix a typo in CHANGELOG_V12
PR-URL: #35786 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c0a4fac - Browse repository at this point
Copy the full SHA c0a4facView commit details -
doc: use kbd element in readline doc prose
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: #35737 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for afbe23d - Browse repository at this point
Copy the full SHA afbe23dView commit details -
build: turn off Codecov comments
Turns off coverage comments for the time being, until we can sort out issues. PR-URL: #35800 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 34281cd - Browse repository at this point
Copy the full SHA 34281cdView commit details -
doc: modified memory set statement set size
PR-URL: #35517 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7b3743d - Browse repository at this point
Copy the full SHA 7b3743dView commit details -
doc: add require statement in the example
PR-URL: #35554 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6211ffd - Browse repository at this point
Copy the full SHA 6211ffdView commit details -
Revert "src: ignore GCC -Wcast-function-type for v8.h"
This reverts commit f21cf45 as this has now been included in the V8 version being used. PR-URL: #35758 Refs: v8/v8@f08cbfd Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01d7c46 - Browse repository at this point
Copy the full SHA 01d7c46View commit details -
src: use MaybeLocal.ToLocal instead of IsEmpty
PR-URL: #35716 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4b8b5fe - Browse repository at this point
Copy the full SHA 4b8b5feView commit details -
src: remove ignore GCC -Wcast-function-type for v8
This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit 2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has now been included in the V8 version being used. PR-URL: #35768 Refs: v8/v8@f08cbfd Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: David Carlier <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4128eef - Browse repository at this point
Copy the full SHA 4128eefView commit details -
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c365867 - Browse repository at this point
Copy the full SHA c365867View commit details -
This adds support for nullish coalescing, optional chaining and numeric separators. The acorn-numeric-separator plugin can be removed. PR-URL: #35791 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 52a77db - Browse repository at this point
Copy the full SHA 52a77dbView commit details -
doc: add a subsystems header in pull-requests.md
PR-URL: #35718 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6513a58 - Browse repository at this point
Copy the full SHA 6513a58View commit details -
doc: fix _construct example params order
PR-URL: #35790 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c2e6a4b - Browse repository at this point
Copy the full SHA c2e6a4bView commit details -
http: lazy create IncomingMessage.headers
When rawHeaders is enough don't create the headers object. PR-URL: #35281 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6b7a3b - Browse repository at this point
Copy the full SHA b6b7a3bView commit details -
worker: add eventLoopUtilization()
Allow calling eventLoopUtilization() directly on a worker thread: const worker = new Worker('./foo.js'); const elu = worker.performance.eventLoopUtilization(); setTimeout(() => { worker.performance.eventLoopUtilization(elu); }, 10); Add a new performance object on the Worker instance that will hopefully one day hold all the other performance metrics, such as nodeTiming. Include benchmarks and tests. PR-URL: #35664 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 221e283 - Browse repository at this point
Copy the full SHA 221e283View commit details -
n-api: revert change to finalization
Fixes: #35620 This reverts commit a6b6556 which changed finalization behavior related to N-API. We will investigate the original issue with the test separately. PR-URL: #35777 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c17dbd - Browse repository at this point
Copy the full SHA 0c17dbdView commit details -
doc: consolidate and clarify breakOnSigInt text
PR-URL: #35787 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b07f4a3 - Browse repository at this point
Copy the full SHA b07f4a3View commit details -
doc,test: update v8 method doc and comment
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 092c6c4 - Browse repository at this point
Copy the full SHA 092c6c4View commit details -
test: add upstream test cases to urlsearchparam
Refs: web-platform-tests/wpt#26126 PR-URL: #35792 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 76991c0 - Browse repository at this point
Copy the full SHA 76991c0View commit details -
doc: use case-sensitive in the example
PR-URL: #35624 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3db4354 - Browse repository at this point
Copy the full SHA 3db4354View commit details -
src: remove ERR prefix in WebCryptoKeyExportStatus
This commit suggests removing the ERR prefix in the WebCryptoKeyExportStatus enum. The motivation for this is that I think it improves the readability of the code. For example, the following line had me look twice to see what was going on: case WebCryptoKeyExportStatus::ERR_OK: // Success! PR-URL: #35639 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c922578 - Browse repository at this point
Copy the full SHA c922578View commit details -
child_process: add ChildProcess 'spawn' event
The new event signals that the subprocess has spawned successfully and no 'error' event will be emitted from failing to spawn. Fixes: #35288 PR-URL: #35369 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8169902 - Browse repository at this point
Copy the full SHA 8169902View commit details -
doc: update MessagePort documentation for EventTarget inheritance
Refs: #34057 Refs: #35835 PR-URL: #35839 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4e76a3c - Browse repository at this point
Copy the full SHA 4e76a3cView commit details -
tls: allow reading data into a static buffer
Refs: #25436 PR-URL: #35753 Refs: #25436 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee15142 - Browse repository at this point
Copy the full SHA ee15142View commit details -
doc: make small improvements to REPL doc
* button -> key * apply missing kbd element * revise "Recoverable errors" text for brevity and clarity PR-URL: #35808 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8074f69 - Browse repository at this point
Copy the full SHA 8074f69View commit details -
events: make eventTarget.removeAllListeners() return this
Fixes: #35762 PR-URL: #35805 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 438d9de - Browse repository at this point
Copy the full SHA 438d9deView commit details -
events: make abort_controller event trusted
The AbortController abort event is trusted, currently we fire all events with isTrusted: false. Allow dispatching events internally with `isTrusted: true` and add a test for it. Co-Authored-By: ExE Boss <[email protected]> Fixes: #35748 PR-URL: #35811 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f08e2c0 - Browse repository at this point
Copy the full SHA f08e2c0View commit details -
test: add upstream test cases to encoding
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd3cbb4 - Browse repository at this point
Copy the full SHA dd3cbb4View commit details -
doc: add conditional example for setBreakpoint()
The `node-inspect` debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to `true` in the current context, the breakpoint pauses execution; otherwise the execution continues. This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation. PR-URL: #35823 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5e8d821 - Browse repository at this point
Copy the full SHA 5e8d821View commit details -
I've had to update this one too many times, and much of it can be automated, so let's do that! The maintenance instructions have also been updated. PR-URL: #35822 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for afb3e24 - Browse repository at this point
Copy the full SHA afb3e24View commit details -
doc: stabilize packages features
These features are being used in production and are ready to be considered stable. Refs: nodejs/modules#564 PR-URL: #35742 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d291e3a - Browse repository at this point
Copy the full SHA d291e3aView commit details -
test: add onerror test cases to policy
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8958af4 - Browse repository at this point
Copy the full SHA 8958af4View commit details -
deps: upgrade to [email protected]
PR-URL: #35871 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 20accb0 - Browse repository at this point
Copy the full SHA 20accb0View commit details -
tools: add msvc /P output to .gitignore
PR-URL: #35735 Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 31753ec - Browse repository at this point
Copy the full SHA 31753ecView commit details -
doc: fix reference to googletest test fixture
PR-URL: #35813 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0580258 - Browse repository at this point
Copy the full SHA 0580258View commit details -
crypto: fix webcrypto ECDH JWK import
This fixes the importKey operation when importing a JWK for the ECDH algorithm. As per the Web Crypto API specification the JWK `alg` property is not checked (as opposed to ECDSA). PR-URL: #35855 Fixes: #35812 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for abd7c94 - Browse repository at this point
Copy the full SHA abd7c94View commit details -
build,tools: add lint-js-doc target
Add a build target to lint JS code in Markdown files only. PR-URL: #35708 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 273e147 - Browse repository at this point
Copy the full SHA 273e147View commit details -
build: add vcbuilt test-doc target
PR-URL: #35708 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5fa849 - Browse repository at this point
Copy the full SHA a5fa849View commit details -
doc: recommend test-doc instead of lint-md
The documentation style guide used to recommend checking changes in the docs by running `make lint-md`. This leaves out some important checks which are contained in the `test-doc` build target. This commit also replaces `lint` by `lint-md` in the list of `test-doc`'s prerequisites. PR-URL: #35708 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c2b179 - Browse repository at this point
Copy the full SHA 8c2b179View commit details -
crypto: fixup scrypt regressions
Fixes a handful of regressions in scrypt support following the refactor. Fixes: #35815 PR-URL: #35821 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79a8fb6 - Browse repository at this point
Copy the full SHA 79a8fb6View commit details -
lib: use primordials when calling methods of Error
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: #35837 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b1e531a - Browse repository at this point
Copy the full SHA b1e531aView commit details -
build,tools: gitHub Actions: use Node.js Fermium
PR-URL: #35840 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4447ff1 - Browse repository at this point
Copy the full SHA 4447ff1View commit details -
doc: move ronkorving to emeritus
In email, ronkorving indicated that he could/should be moved to emeritus at this time. PR-URL: #35828 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c14889b - Browse repository at this point
Copy the full SHA c14889bView commit details -
doc: fix a typo in CHANGELOG_V15
Signed-off-by: Takuya Noguchi <[email protected]> PR-URL: #35804 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9703219 - Browse repository at this point
Copy the full SHA 9703219View commit details -
test: fix reference to WPT testharness.js
The W3C testharness.js was moved to the `web-platform-tests/wpt` repository a while ago. PR-URL: #35814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for de3dcd7 - Browse repository at this point
Copy the full SHA de3dcd7View commit details -
assert,repl: enable ecmaVersion 2021 in acorn parser
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d95013f - Browse repository at this point
Copy the full SHA d95013fView commit details -
module: runtime deprecate subpath folder mappings
PR-URL: #35747 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0f5a8c5 - Browse repository at this point
Copy the full SHA 0f5a8c5View commit details -
test: mark test-http2-respond-file-error-pipe-offset flaky
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: #35881 PR-URL: #35883 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7691b67 - Browse repository at this point
Copy the full SHA 7691b67View commit details -
n-api: napi_make_callback emit async init with resource of async_context
instead of emit async init with receiver of the callback. PR-URL: #32930 Fixes: #32898 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d16e2fa - Browse repository at this point
Copy the full SHA d16e2faView commit details -
zlib: test BrotliCompress throws invalid arg value
PR-URL: #35830 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 102d7df - Browse repository at this point
Copy the full SHA 102d7dfView commit details -
test: mark test-worker-eventlooputil flaky
This is consistently failing in CI right now. Lets mark it flaky while we figure out what is going on. Refs: #35844 PR-URL: #35886 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 830b789 - Browse repository at this point
Copy the full SHA 830b789View commit details -
doc: add on statement in the APIs docs
PR-URL: #35610 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 337bfcf - Browse repository at this point
Copy the full SHA 337bfcfView commit details -
crypto: rename check to createJob
This commit renames the check function to createJob which seems to be more descriptive of what this function does. PR-URL: #35858 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 644c416 - Browse repository at this point
Copy the full SHA 644c416View commit details -
test: add test to fs/promises setImmediate
Add test pattern to setImmediate when ref's type is not boolean PR-URL: #35852 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 66ad4be - Browse repository at this point
Copy the full SHA 66ad4beView commit details -
lib: create diagnostics_channel module
PR-URL: #34895 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b38a43d - Browse repository at this point
Copy the full SHA b38a43dView commit details -
http: report request start and end with diagnostics_channel
PR-URL: #34895 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f861733 - Browse repository at this point
Copy the full SHA f861733View commit details -
tools: update ESLint to 7.12.0
Update ESLint to 7.12.0 PR-URL: #35799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d20b318 - Browse repository at this point
Copy the full SHA d20b318View commit details -
tools: update ESLint to 7.12.1
Update ESLint to 7.12.1 PR-URL: #35799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a07d1af - Browse repository at this point
Copy the full SHA a07d1afView commit details -
deps: update to [email protected]
PR-URL: #35901 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1303a1f - Browse repository at this point
Copy the full SHA 1303a1fView commit details -
lib: let abort_controller target be EventTarget
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: #35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2f574b - Browse repository at this point
Copy the full SHA d2f574bView commit details -
test: integrate abort_controller tests from wpt
Refs: web-platform-tests/wpt#9361 PR-URL: #35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da612df - Browse repository at this point
Copy the full SHA da612dfView commit details -
doc: move bnoordhuis to emeritus
It's been ten years and it's time for a change. September 30 was my last day at IBM and my last day as a full-time Node.js maintainer. I feel Deno is the future and that's why I'm joining that scrappy startup, Deno Land Inc., to make that future happen. PR-URL: #35865 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4899998 - Browse repository at this point
Copy the full SHA 4899998View commit details -
doc: update crypto.createSecretKey history
Passing strings to `crypto.createSecretKey` was not added until v15.0.0 (specifically with commit dae283d). The existing documentation implies its availability in prior versions which may cause confusion. PR-URL: #35874 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ac4a6a - Browse repository at this point
Copy the full SHA 0ac4a6aView commit details -
https://github.com/cpplint/cpplint/releases/tag/1.5.1 PR-URL: #35866 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3955ccd - Browse repository at this point
Copy the full SHA 3955ccdView commit details -
tools: refloat 7 Node.js patches to cpplint.py
Cherry-pick 12c8b4d Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: #17373 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Refs: 12c8b4d Cherry-pick fc81e80 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: #21521 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: fc81e80 Cherry-pick cbc3dd9 Original commit message: src, tools: add check for left leaning pointers This commit adds a rule to cpplint to check that pointers in the code base lean to the left and not right, and also fixes the violations reported. PR-URL: #21010 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: cbc3dd9 Cherry-pick 9029981 Original commit message: tools: fix cpplint.py header rules THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT. PR-URL: #26306 Reviewed-By: Gireesh Punathil <[email protected]> Refs: 9029981 Cherry-pick 0a25ace Original commit message: tools: move cpplint configuration to .cpplint PR-URL: #27098 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Refs: 0a25ace Cherry-pick afa9a72 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: #30876 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Refs: afa9a72 Cherry-pick e23bf8f Original commit message: tools,src: refloat forbid usage of v8::Persistent `v8::Persistent` comes with the surprising catch that it requires manual cleanup. `v8::Global` doesn’t, making it easier to use, and additionally provides move semantics. New code should always use `v8::Global`. PR-URL: #31018 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> PR-URL: #35569 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> PR-URL: #35719 Reviewed-By: Antoine du Hamel <[email protected]> PR-URL: #35866
Configuration menu - View commit details
-
Copy full SHA for c09fdba - Browse repository at this point
Copy the full SHA c09fdbaView commit details -
deps: upgrade to [email protected]
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5cb77f2 - Browse repository at this point
Copy the full SHA 5cb77f2View commit details -
PR-URL: #35908 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55adee0 - Browse repository at this point
Copy the full SHA 55adee0View commit details -
Refs: #35708 PR-URL: #35927 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b11c737 - Browse repository at this point
Copy the full SHA b11c737View commit details -
errors: do not call resolve on URLs with schemes
We were incorrectly trying to run path.resolve on absolute sources URLs. This was breaking webpack:// URLs in stack trace output. Refs: #35325 PR-URL: #35903 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7c8b5e5 - Browse repository at this point
Copy the full SHA 7c8b5e5View commit details -
doc: adjust table alignment for remark v13
Addresses table-cell-padding rule issues PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb55462 - Browse repository at this point
Copy the full SHA eb55462View commit details -
doc: disable no-undefined-references workarounds
The manual links appear to be specific workarounds, so just ignore them PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59b36af - Browse repository at this point
Copy the full SHA 59b36afView commit details -
doc: temporarily disable list-item-bullet-indent
Not an issue with v13 remark, but seems to be a glitch in the disabled lines in v12 conflicting. PR-URL: #35647 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c5b9422 - Browse repository at this point
Copy the full SHA c5b9422View commit details -
doc: update tables in README files for linting changes
PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7937fbe - Browse repository at this point
Copy the full SHA 7937fbeView commit details -
tools: bump remark-lint-preset-node to 2.0.0
Update [email protected], [email protected] and other dependencies in the lint-md rollup. PR-URL: #35905 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd027cd - Browse repository at this point
Copy the full SHA fd027cdView commit details
Commits on Nov 4, 2020
-
PR-URL: #35953 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d3f1cde - Browse repository at this point
Copy the full SHA d3f1cdeView commit details -
PR-URL: #35806 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1cdfaa8 - Browse repository at this point
Copy the full SHA 1cdfaa8View commit details -
src: remove redundant OpenSSLBuffer
Replace the OpenSSLBuffer utility with ByteSource and remove OpenSSLBuffer. Signed-off-by: James M Snell <[email protected]> PR-URL: #35663 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb71964 - Browse repository at this point
Copy the full SHA fb71964View commit details -
benchmark: add startup benchmark for loading public modules
Adding a new benchmark for testing the performance of loading available public modules. PR-URL: #35816 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b549c1 - Browse repository at this point
Copy the full SHA 9b549c1View commit details -
benchmark: make the benchmark tool work with Node 10
Avoid using class fields in the benchmark tools since they are not available in Node 10. This can be reverted when Node 10 reaches EOL. PR-URL: #35817 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 76ebae4 - Browse repository at this point
Copy the full SHA 76ebae4View commit details -
test: correct test-worker-eventlooputil
The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: #35891 Fixes: #35844 Refs: #35886 Refs: #35664 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 231af88 - Browse repository at this point
Copy the full SHA 231af88View commit details -
test: add missing ref comments to parallel.status
PR-URL: #35896 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d61e3d - Browse repository at this point
Copy the full SHA 5d61e3dView commit details -
stream: fix regression on duplex end
Decide the return status of writeOrBuffer before calling stream.write which can reset state.length Add unit test for #35926 Refs: #35926 PR-URL: #35941 Fixes: #35926 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2868f52 - Browse repository at this point
Copy the full SHA 2868f52View commit details -
crypto: pass empty passphrases to OpenSSL properly
Fixes: #35898 PR-URL: #35914 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ebf44b - Browse repository at this point
Copy the full SHA 0ebf44bView commit details -
2020-11-04, Version 15.1.0 (Current)
Notable changes: child_process: * (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) #35369 dns: * (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) #34824 http: * (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) #34895 http2: * (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) #35383 lib: * (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) #34895 src: * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) #35664 PR-URL: #35948
Configuration menu - View commit details
-
Copy full SHA for 2291e07 - Browse repository at this point
Copy the full SHA 2291e07View commit details