Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 559 / support front matter #561

Merged
merged 19 commits into from
Nov 1, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Oct 19, 2023

Describe what your pull request addresses

  • [ ]

Test Instructions

  • test with https://deploy-preview-561--gateway-edit.netlify.app/
  • should see 'front' selection before verse 1 in the verse field of the bible reference selector.
  • navigate to Psalms 3:front
  • edit the text after the \d and add a word like EDIT
  • click alignment icon and should be able to do alignment - align some words and click accept
  • do save to make sure that works
  • after save completes, verify the displayed text matches the last edit
  • then click the alignment icon and make sure alignment matches your last alignment.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #561 (857ea14) into develop (af6952c) will decrease coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
- Coverage    51.52%   51.48%   -0.04%     
===========================================
  Files           43       43              
  Lines         1312     1313       +1     
===========================================
  Hits           676      676              
- Misses         636      637       +1     
Files Coverage Δ
src/components/BibleReference.js 75.00% <ø> (ø)
src/components/WordAlignerDialog.js 44.44% <100.00%> (+2.13%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature 559 / support front matter alignments Feature 559 / support front matter Oct 24, 2023
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Verified that error message displays when there are no alignments!

PhotoNomad0 added 2 commits November 1, 2023 11:39
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review November 1, 2023 15:45
@PhotoNomad0 PhotoNomad0 closed this Nov 1, 2023
@PhotoNomad0 PhotoNomad0 reopened this Nov 1, 2023
@PhotoNomad0 PhotoNomad0 merged commit e2d994b into develop Nov 1, 2023
8 of 11 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature-mcleanb-559-supportFrontMatter branch November 1, 2023 16:30
PhotoNomad0 added a commit that referenced this pull request Dec 6, 2023
* Replace hard coded card names in merge dialog to resource titles

* Replace BranchMergerContext with state in app context

* Update single-scripture-rcl version for #546 (#558)

* Update issue templates

* Add button to TSV Resource Cards to Add another TSV resource

* Moved add button in TWL to actions column in table

* Feature 559 / support front matter (#561)

* added front to demo

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* add error message handling

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Save to DCS on TSV Add & Navigate to new TSV Row (#571)

* Changes to save new TSV row to DCS on add

* Changes to navigate to newly created tsv row

* Only generate Tsv data if resource is tsv

* Change const, clarify ternary, update scrip-tsv version

* feature 524 / added alignment reset and multi-select. (#576)

* added alignment reset and multi-select.

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Update version of scripture-tsv to 0.2.1 (#584)

* Fix for 500 errors (#583)

Updated versions of gitea-react-toolkit and single-scripture-rcl

Co-authored-by: PhotoNomad0 <[email protected]>

* Feature kintsoogi 484 delete tsv (#587)

* Add delete tsv functionality and pure setItemIndex

* Small fix for newQuote

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* upgrades translation-helps-rcl to 3.5.13

* Display add button in header for TWL when no items (#597)

- Display add button in header for TWL when no items
- Do not display delete button if no items in tsv resource card

* Updated version of scripture-resources-rcl

Fixes problem where empty last tsv item in book throws errors

* fixes build error while building with node >= 18

__This is a temporary fix__

Any machine building with node >= 18 runs into this issue:
unfoldingWord/translation-helps-rcl#121

I've modified the build scripts to use the set-env.sh scripts
to determine what the NODE_OPTIONS should be when building.

* Bump version to 2.2.0

* qaFail 602 / Save button is enabled when edit box is clicked (#608)

update single-scripture-rcl

* Bugfix 570 / Fix highlighting errors with right quote in Greek Word (#604)

fixes for highlighting right quotes in original languages

---------

Co-authored-by: kintsoogi <[email protected]>
Co-authored-by: Kintsoogi <[email protected]>
Co-authored-by: elsylambert <[email protected]>
Co-authored-by: PhotoNomad0 <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants