Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 524 / added alignment reset and multi-select. #576

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Nov 13, 2023

Describe what your pull request addresses

  • implements multi-select in alignment wordbank
  • also implements: Clear/reset the alignments  #569
  • add support for clearing all alignments
  • add support for multiple selections with shift-click

Test Instructions

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #576 (ec7704f) into develop (621ea8c) will decrease coverage by 1.41%.
The diff coverage is 35.29%.

❗ Current head ec7704f differs from pull request most recent head 3e884ce. Consider uploading reports for the commit 3e884ce to get more accurate results

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
- Coverage    51.55%   50.15%   -1.41%     
===========================================
  Files           43       43              
  Lines         1315     1330      +15     
===========================================
- Hits           678      667      -11     
- Misses         637      663      +26     
Files Coverage Δ
src/components/WordAlignerDialog.js 40.47% <35.29%> (-3.97%) ⬇️

... and 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review November 13, 2023 20:57
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhotoNomad0 PhotoNomad0 merged commit f845565 into develop Nov 14, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature-mcleanb-524-multiselect-and-reset branch November 14, 2023 12:54
PhotoNomad0 added a commit that referenced this pull request Dec 6, 2023
* Replace hard coded card names in merge dialog to resource titles

* Replace BranchMergerContext with state in app context

* Update single-scripture-rcl version for #546 (#558)

* Update issue templates

* Add button to TSV Resource Cards to Add another TSV resource

* Moved add button in TWL to actions column in table

* Feature 559 / support front matter (#561)

* added front to demo

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* add error message handling

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Save to DCS on TSV Add & Navigate to new TSV Row (#571)

* Changes to save new TSV row to DCS on add

* Changes to navigate to newly created tsv row

* Only generate Tsv data if resource is tsv

* Change const, clarify ternary, update scrip-tsv version

* feature 524 / added alignment reset and multi-select. (#576)

* added alignment reset and multi-select.

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Update version of scripture-tsv to 0.2.1 (#584)

* Fix for 500 errors (#583)

Updated versions of gitea-react-toolkit and single-scripture-rcl

Co-authored-by: PhotoNomad0 <[email protected]>

* Feature kintsoogi 484 delete tsv (#587)

* Add delete tsv functionality and pure setItemIndex

* Small fix for newQuote

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* upgrades translation-helps-rcl to 3.5.13

* Display add button in header for TWL when no items (#597)

- Display add button in header for TWL when no items
- Do not display delete button if no items in tsv resource card

* Updated version of scripture-resources-rcl

Fixes problem where empty last tsv item in book throws errors

* fixes build error while building with node >= 18

__This is a temporary fix__

Any machine building with node >= 18 runs into this issue:
unfoldingWord/translation-helps-rcl#121

I've modified the build scripts to use the set-env.sh scripts
to determine what the NODE_OPTIONS should be when building.

* Bump version to 2.2.0

* qaFail 602 / Save button is enabled when edit box is clicked (#608)

update single-scripture-rcl

* Bugfix 570 / Fix highlighting errors with right quote in Greek Word (#604)

fixes for highlighting right quotes in original languages

---------

Co-authored-by: kintsoogi <[email protected]>
Co-authored-by: Kintsoogi <[email protected]>
Co-authored-by: elsylambert <[email protected]>
Co-authored-by: PhotoNomad0 <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants