Feature kintsoogi 484 delete tsv #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #587 +/- ##
===========================================
+ Coverage 50.15% 51.71% +1.56%
===========================================
Files 43 43
Lines 1330 1338 +8
===========================================
+ Hits 667 692 +25
+ Misses 663 646 -17 ☔ View full report in Codecov by Sentry. |
|
@kintsoogi My first attempt adding a new tN resulted in not being able to edit the support references on any note. I deleted my edit branch and started over. Now I cannot reproduce the problem and the edit branch is gone - so no clues there. |
|
@kintsoogi Also when I tried to delete the note I added it said it could not find the note. |
PhotoNomad0
added a commit
that referenced
this pull request
Dec 6, 2023
* Replace hard coded card names in merge dialog to resource titles * Replace BranchMergerContext with state in app context * Update single-scripture-rcl version for #546 (#558) * Update issue templates * Add button to TSV Resource Cards to Add another TSV resource * Moved add button in TWL to actions column in table * Feature 559 / support front matter (#561) * added front to demo * update dependencies * update dependencies * update dependencies * update dependencies * add error message handling * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies * update dependencies --------- Co-authored-by: PhotoNomad0 <[email protected]> * Save to DCS on TSV Add & Navigate to new TSV Row (#571) * Changes to save new TSV row to DCS on add * Changes to navigate to newly created tsv row * Only generate Tsv data if resource is tsv * Change const, clarify ternary, update scrip-tsv version * feature 524 / added alignment reset and multi-select. (#576) * added alignment reset and multi-select. * update dependencies * update dependencies --------- Co-authored-by: PhotoNomad0 <[email protected]> * Update version of scripture-tsv to 0.2.1 (#584) * Fix for 500 errors (#583) Updated versions of gitea-react-toolkit and single-scripture-rcl Co-authored-by: PhotoNomad0 <[email protected]> * Feature kintsoogi 484 delete tsv (#587) * Add delete tsv functionality and pure setItemIndex * Small fix for newQuote * update dependencies --------- Co-authored-by: PhotoNomad0 <[email protected]> * upgrades translation-helps-rcl to 3.5.13 * Display add button in header for TWL when no items (#597) - Display add button in header for TWL when no items - Do not display delete button if no items in tsv resource card * Updated version of scripture-resources-rcl Fixes problem where empty last tsv item in book throws errors * fixes build error while building with node >= 18 __This is a temporary fix__ Any machine building with node >= 18 runs into this issue: unfoldingWord/translation-helps-rcl#121 I've modified the build scripts to use the set-env.sh scripts to determine what the NODE_OPTIONS should be when building. * Bump version to 2.2.0 * qaFail 602 / Save button is enabled when edit box is clicked (#608) update single-scripture-rcl * Bugfix 570 / Fix highlighting errors with right quote in Greek Word (#604) fixes for highlighting right quotes in original languages --------- Co-authored-by: kintsoogi <[email protected]> Co-authored-by: Kintsoogi <[email protected]> Co-authored-by: elsylambert <[email protected]> Co-authored-by: PhotoNomad0 <[email protected]> Co-authored-by: Noah Harvey <[email protected]> Co-authored-by: Noah Harvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what your pull request addresses
Test Instructions